script: complete `resolve_module_specifier` by wusyong · Pull Request #37552 · servo/servo

wusyong · 2025-06-19T09:26:34Z

Implement whole spec of resolve_module_specifier. Servo can now support script element with import map type!

Testing: tests/wpt/tests/import-map
Fixes: #37316 #36394

Signed-off-by: Wu Yu Wei <[email protected]>

wusyong · 2025-06-19T09:37:43Z

tests/wpt/meta/import-maps/multiple-import-maps/already-resolved-dropped.html.ini

@@ -0,0 +1,2 @@
+[already-resolved-dropped.html]
+  expected: CRASH


There are three crash tests and one failed test regression because of outdated module hook in script_module.
I opened a tracking issue #37553 for further improvement. These hooks seems to have similar large scope like resolving module specifiers.

Signed-off-by: Wu Yu Wei <[email protected]>

github-actions · 2025-06-19T10:01:28Z

🔨 Triggering try run (#15755134944) for Linux (WPT)

github-actions · 2025-06-19T10:39:26Z

Test results for linux-wpt from try job (#15755134944):

Flaky unexpected result (17)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
OK /css/css-align/blocks/align-content-block-002.html (#37361)
- PASS [expected FAIL] subtest: .test 1: start
- PASS [expected FAIL] subtest: .test 4: baseline
- PASS [expected FAIL] subtest: .test 6: flex-start
- PASS [expected FAIL] subtest: .test 8: unsafe start
- PASS [expected FAIL] subtest: .test 11: safe start
- PASS [expected FAIL] subtest: .test 15: space-between
- PASS [expected FAIL] subtest: .test 17: normal
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy same-origin destination
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
PASS [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
FAIL [expected PASS] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic test (normal form)
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker.html (#33909)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Dynamic import failed"
```
TIMEOUT /preload/preload-resource-match.https.html
- TIMEOUT [expected FAIL] subtest: Loading script (use-credentials) with link (no-cors) should discard the preloaded response
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Loading script (use-credentials) with link (anonymous) should discard the preloaded response
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```

Stable unexpected results that are known to be intermittent (24)

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resizeTo.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '400 425' over '350 399'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 0deg' should prefer 'oblique -40deg -30deg' over 'italic'
FAIL [expected PASS] /css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001.html (#37162)
ERROR [expected TIMEOUT] /fetch/fetch-later/quota/same-origin-iframe/max-payload.tentative.https.window.html (#35210)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url with document.write and href navigation
```
assert_array_equals: expected property 1 to be "href" but got "click" (expected array ["write", "href"] got ["write", "click"])
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- PASS [expected FAIL] subtest: link click
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

OK /html/browsers/windows/browsing-context-names/duplicate-name-order.html (#34623)
- FAIL [expected PASS] subtest: Duplicate name lookup order
```
assert_equals: subtree first expected "ChildA" but got "PopupA"
```

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"

CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK [expected TIMEOUT] /performance-timeline/navigation-id-detached-frame.tentative.html (#34773)
- PASS [expected TIMEOUT] subtest: The navigation_id getter does not crash a window of detached frame

OK /preload/preload-error.sub.html (#37177)

FAIL [expected PASS] subtest: 404 (style): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.css?pipe=status%28404%29&amp;label=style should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: 404 (script): main

FAIL [expected PASS] subtest: success (xhr): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?label=xhr should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: 404 (xhr): main
PASS [expected FAIL] subtest: Decode-error (script): main

FAIL [expected PASS] subtest: MIME-error (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.css?pipe=header%28Content-Type%2Ctext%2Fnotjavascript%29&amp;label=script should be loaded expected a number greater than 0 but got 0

OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)
- FAIL [expected PASS] subtest: X Stitched sine-wave buffers at sample rate 43800 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732959747314453,0.4248766601085663,0.480754554271698,0.5347436666488647,0.5866320133209229,0.6362156271934509,0.6832997798919678,0.7276994585990906,0.7692402601242065,0.8077589869499207...] with an element-wise tolerance of {"absoluteThreshold":0.0038986,"relativeThreshold":0}. Index Actual Expected AbsError RelError Test threshold [14650] -1.9264118456320000e+12 8.6956524848937988e-1 1.9264118456328696e+12 2.2153735432498682e+12 3.8985999999999999e-3 [14651] 3.0547976493835449e-1 8.9879405498504639e-1 5.9331429004669189e-1 6.6012262403823208e-1 3.8985999999999999e-3 Max AbsError of 1.9264118456328696e+12 at index of 14650. Max RelError of 2.2153735432498682e+12 at index of 14650.
```
assert_true: expected true got false
```
- FAIL [expected PASS] subtest: X SNR (-202.26089685778032 dB) is not greater than or equal to 65.737. Got -202.26089685778032.
```
assert_true: expected true got false
```
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```

github-actions · 2025-06-19T10:40:28Z

✨ Try run (#15755134944) succeeded.

tests/wpt/meta/import-maps/not-overridden/dynamic.html.ini

gterzian

A few initial comments, will have to go through it line by line tomorrow...

components/script/dom/globalscope.rs

components/script/script_module.rs

Signed-off-by: Wu Yu Wei <[email protected]>

gterzian

LGTM with some minor things to address.

components/script/dom/globalscope.rs

components/script/dom/htmlscriptelement.rs

components/script/script_module.rs

Signed-off-by: Wu Yu Wei <[email protected]>

wusyong added 8 commits June 19, 2025 17:53

Add resolve_imports_match

a47e6eb

Signed-off-by: Wu Yu Wei <[email protected]>

Fix parameters of resolve_module_specifier

0a90ad5

Signed-off-by: Wu Yu Wei <[email protected]>

Pass module script

3b1f92c

Signed-off-by: Wu Yu Wei <[email protected]>

Expand resolve module specifier

76262aa

Signed-off-by: Wu Yu Wei <[email protected]>

Add resolved module set

e246b97

Signed-off-by: Wu Yu Wei <[email protected]>

Improve console warnings

223be09

Signed-off-by: Wu Yu Wei <[email protected]>

Update wpt results

1bcaf42

Signed-off-by: Wu Yu Wei <[email protected]>

mach test-tidy

c94de23

Signed-off-by: Wu Yu Wei <[email protected]>

wusyong commented Jun 19, 2025

View reviewed changes

mach clippy

0bd4f77

Signed-off-by: Wu Yu Wei <[email protected]>

wusyong mentioned this pull request Jun 19, 2025

Can't load JS modules that rely on import maps #36394

Closed

wusyong marked this pull request as ready for review June 19, 2025 10:01

wusyong requested a review from gterzian as a code owner June 19, 2025 10:01

wusyong added the T-linux-wpt Do a try run of the WPT label Jun 19, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jun 19, 2025

Taym95 reviewed Jun 19, 2025

View reviewed changes

tests/wpt/meta/import-maps/not-overridden/dynamic.html.ini Show resolved Hide resolved

gterzian reviewed Jun 19, 2025

View reviewed changes

Address changes

781c2f4

Signed-off-by: Wu Yu Wei <[email protected]>

wusyong requested review from Taym95 and gterzian June 19, 2025 15:03

gterzian approved these changes Jun 20, 2025

View reviewed changes

Address more changes

0a0ce3b

Signed-off-by: Wu Yu Wei <[email protected]>

wusyong enabled auto-merge June 21, 2025 05:47

wusyong added this pull request to the merge queue Jun 21, 2025

Merged via the queue into servo:main with commit 927573d Jun 21, 2025
21 checks passed

wusyong deleted the resolve-map branch June 21, 2025 06:45

		@@ -0,0 +1,2 @@
		[already-resolved-dropped.html]
		expected: CRASH

Uh oh!

Conversation

wusyong commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wusyong Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

Uh oh!

gterzian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gterzian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wusyong commented Jun 19, 2025 •

edited

Loading