Implement actions_by_tick for webdriver#37153
Merged
xiaochengh merged 4 commits intoservo:mainfrom Jun 3, 2025
Merged
Conversation
Signed-off-by: batu_hoang <[email protected]>
longvatrong111
force-pushed
the
webdriver-tick-actions-impl
branch
from
c108577 to
37bef77
Compare
PotatoCP
reviewed
May 28, 2025
xiaochengh
reviewed
May 28, 2025
Contributor
xiaochengh
left a comment
xiaochengh
left a comment
There was a problem hiding this comment.
Seems good in general.
Signed-off-by: batu_hoang <[email protected]>
PotatoCP
reviewed
May 29, 2025
Signed-off-by: batu_hoang <[email protected]>
longvatrong111
force-pushed
the
webdriver-tick-actions-impl
branch
from
bd7126d to
3ee428f
Compare
xiaochengh
reviewed
May 30, 2025
Contributor
xiaochengh
left a comment
xiaochengh
left a comment
There was a problem hiding this comment.
Got a question about process_an_input_source_action_sequence, plus some minor coding style suggestions.
longvatrong111
force-pushed
the
webdriver-tick-actions-impl
branch
2 times, most recently
from
8b7ad95 to
1ec4606
Compare
yezhizhen
reviewed
Jun 2, 2025
longvatrong111
commented
Jun 2, 2025
Contributor
Author
longvatrong111
left a comment
longvatrong111
left a comment
There was a problem hiding this comment.
Update according to the review
Contributor
|
Please fix lint and DCO |
Signed-off-by: batu_hoang <[email protected]>
longvatrong111
force-pushed
the
webdriver-tick-actions-impl
branch
from
fb99c5e to
eeca802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
actions by tickaccording to the spec.The major change is
dispatch_actionsshould receive aactions by ticksas param.https://w3c.github.io/webdriver/#dispatching-actions
Reference for types in webdriver:
https://hackmd.io/b59NiPcLR_Gagh7r6r7BEw?view
cc: @xiaochengh