refactor: merge cross_realm_transform_* fields into one#37102
Merged
wusyong merged 2 commits intoservo:mainfrom May 27, 2025
Merged
refactor: merge cross_realm_transform_* fields into one#37102wusyong merged 2 commits intoservo:mainfrom
cross_realm_transform_* fields into one#37102wusyong merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Jason Tsai <[email protected]>
Taym95
reviewed
May 23, 2025
| /// for the message port used by the transfered stream. | ||
| #[derive(Clone, JSTraceable, MallocSizeOf)] | ||
| #[cfg_attr(crown, crown::unrooted_must_root_lint::must_root)] | ||
| pub(crate) enum CrossRealmTransform { |
Member
There was a problem hiding this comment.
this looks like https://streams.spec.whatwg.org/#generictransformstream, I am not sure if we should introduce a new type, what do you think @gterzian ?
Member
There was a problem hiding this comment.
I don't think it applies here, otherwise the standard would have used it to specify the transfer. I think it's meant when actually making it available to script.
gterzian
approved these changes
May 26, 2025
Member
gterzian
left a comment
gterzian
left a comment
There was a problem hiding this comment.
Looks good but one doc needs to be corrected.
pewsheen
force-pushed
the
merge-cross-realm-transform-field
branch
from
9a18916 to
3e26c44
Compare
gterzian
reviewed
May 26, 2025
Signed-off-by: Jason Tsai <[email protected]>
pewsheen
force-pushed
the
merge-cross-realm-transform-field
branch
from
3e26c44 to
b05a3c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #36977, when transferring
TransformStream,CrossRealmTransform::WritableandCrossRealmTransform::Readableare set to different message ports. The message port will not be readable and writable at the same time when transferring the stream, so we can now mergecross_realm_transform_readableandcross_realm_transform_writableinto a single fieldcross_realm_transform.Testing: WPT (passed on try branch)
Fixes: #37084