Fix webdriver wait for response from constellation#37095
Merged
jdm merged 1 commit intoservo:mainfrom Jun 3, 2025
Merged
Conversation
yezhizhen
reviewed
May 26, 2025
yezhizhen
reviewed
May 26, 2025
longvatrong111
force-pushed
the
webdriver-actions-wait-response
branch
2 times, most recently
from
21378d5 to
35828db
Compare
PotatoCP
reviewed
Jun 2, 2025
Member
|
Can we resolve conflict and merge this one first? |
Signed-off-by: batu_hoang <[email protected]>
longvatrong111
force-pushed
the
webdriver-actions-wait-response
branch
from
35828db to
531c2d6
Compare
Contributor
Author
|
Hi @xiaochengh , this PR is ready for review now after #37153 is merged. |
jdm
approved these changes
Jun 3, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
Fix a mistake from #37095 cc: @xiaochengh Signed-off-by: batu_hoang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webdriver actions only wait for response from constellation if
dispatch_tick_actionssends at least 1 event.Testing:
./mach test-wpt -r --product servodriver ./tests/wpt/tests/webdriver/tests/classic/perform_actions/perform.pycc: @xiaochengh, @yezhizhen