Remove accidentally re-added logic to WebDriverSession::input_cancel_list#37081
Merged
mrobinson merged 1 commit intoservo:mainfrom May 23, 2025
Merged
Remove accidentally re-added logic to WebDriverSession::input_cancel_list#37081mrobinson merged 1 commit intoservo:mainfrom
WebDriverSession::input_cancel_list#37081mrobinson merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
changed the title
WebDriverSession::input_cancel_list logic in #37010 which was regressed by #36932
Member
|
I'm happy to review this, but I'm a bit confused, because the description of the change is "bring back logic" but this just removes code. Do you mind clarifying? |
Member
Author
mrobinson
changed the title
WebDriverSession::input_cancel_list logic in #37010 which was regressed by #36932WebDriverSession::input_cancel_list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-remove deleted logic from
WebDriverSession::input_cancel_listlogic in #37010 which was re-adedd during merge resolution in #36932. Otherwise, duplicate items would be registered in Release Actions.