Fix WebDriverSession::input_cancel_list related logic#37010
Merged
xiaochengh merged 5 commits intoservo:mainfrom May 19, 2025
Merged
Fix WebDriverSession::input_cancel_list related logic#37010xiaochengh merged 5 commits intoservo:mainfrom
WebDriverSession::input_cancel_list related logic#37010xiaochengh merged 5 commits intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
force-pushed
the
fix-input-cancel-list
branch
from
b93c113 to
b894583
Compare
yezhizhen
commented
May 15, 2025
Contributor
longvatrong111
left a comment
longvatrong111
left a comment
There was a problem hiding this comment.
The logic looks good to me. There are only some minor suggestions.
xiaochengh
reviewed
May 16, 2025
…up_action`` Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
force-pushed
the
fix-input-cancel-list
branch
from
1a9acf6 to
8436d6e
Compare
yezhizhen
commented
May 17, 2025
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
force-pushed
the
fix-input-cancel-list
branch
from
c6d2473 to
3691a3b
Compare
xiaochengh
approved these changes
May 19, 2025
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
added a commit
to yezhizhen/servo
that referenced
this pull request
May 22, 2025
Signed-off-by: Euclid Ye <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 23, 2025
…_list` (#37081) Re-remove deleted logic from `WebDriverSession::input_cancel_list` logic in #37010 which was re-adedd during merge resolution in #36932. Otherwise, duplicate items would be registered in Release Actions. Signed-off-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input_cancel_listindispatch_keyup_actionKeyDownandPointerDown, delay the addition toinput_cancel_listuntil "Dispatching action algorithm" is done to match the spec. Previously the addition is done before notifying constellation. Moreover, this makes sure thatpointerUpis appended even ifdispatch_pointerdown_actionreturns early, so that Release Actions always have the correct order.input_cancel_listindispatch_pointerup_action. This wrongly added "pointerdown" in Release ActionsTesting:
./mach test-wpt -r --log-raw "D:\servo test log\perform-actions.txt" tests\wpt\tests\webdriver\tests\classic\perform_actions --product servodriverhas no new failures so no regression. There are a lot more passing tests, but I think mostly are because there is no CI for webdriver.cc @xiaochengh @jdm @PotatoCP @longvatrong111