Stream implement pipeThrough by Taym95 · Pull Request #36977 · servo/servo

Taym95 · 2025-05-12T12:24:23Z

Part of #34676

#36905 needs to be merged first.

github-actions · 2025-05-12T12:24:46Z

🔨 Triggering try run (#14972142620) for Linux (WPT)

components/script/dom/readablestream.rs

tests/wpt/meta/streams/piping/pipe-through.any.js.ini

tests/wpt/meta/streams/transferable/transform-stream.html.ini

github-actions · 2025-05-12T12:53:50Z

Test results for linux-wpt from try job (#14972142620):

Flaky unexpected result (15)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
FAIL [expected PASS] /css/css-text/i18n/css3-text-line-break-opclns-218.html
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
PASS [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
TIMEOUT [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-transfer.html (#34119)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```

OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)

FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic File test (normal form)
TIMEOUT [expected OK] /html/webappapis/dynamic-markup-insertion/opening-the-input-stream/remove-initial-about-blankness.window.html (#28684)
- TIMEOUT [expected PASS] subtest: document.open() removes the initial about:blank-ness of the document
```
Test timed out
```
OK /resize-observer/change-layout-in-error.html (#32629)
- PASS [expected FAIL] subtest: Changing layout in window error handler should not result in lifecyle loop when resize observer loop limit is reached.

Stable unexpected results that are known to be intermittent (11)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
TIMEOUT [expected OK] /_mozilla/mozilla/window_resizeTo.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- FAIL [expected PASS] subtest: WebGL test #52
```
assert_true: could not create image (SVG) expected true got false
```
PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
OK /css/css-grid/alignment/grid-content-alignment-with-abspos-001.html (#34339)
- PASS [expected FAIL] subtest: .grid 1
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url with document.write and href navigation
```
assert_array_equals: expected property 1 to be "href" but got "click" (expected array ["write", "href"] got ["write", "click"])
```

OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)

FAIL [expected PASS] subtest: form submission

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1=" but got "about:blank"

TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)
- FAIL [expected PASS] subtest: X Stitched sine-wave buffers at sample rate 43800 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732959747314453,0.4248766601085663,0.480754554271698,0.5347436666488647,0.5866320133209229,0.6362156271934509,0.6832997798919678,0.7276994585990906,0.7692402601242065,0.8077589869499207...] with an element-wise tolerance of {"absoluteThreshold":0.0038986,"relativeThreshold":0}. Index Actual Expected AbsError RelError Test threshold [14650] -1.7840824127197266e+0 8.6956524848937988e-1 2.6536476612091064e+0 3.0516947012533651e+0 3.8985999999999999e-3 [14651] 3.0547976493835449e-1 8.9879405498504639e-1 5.9331429004669189e-1 6.6012262403823208e-1 3.8985999999999999e-3 Max AbsError of 2.6536476612091064e+0 at index of 14650. Max RelError of 3.0516947012533651e+0 at index of 14650.
```
assert_true: expected true got false
```
- FAIL [expected PASS] subtest: X SNR (34.74194636816043 dB) is not greater than or equal to 65.737. Got 34.74194636816043.
```
assert_true: expected true got false
```
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results (2)

OK /fetch/api/response/response-stream-disturbed-by-pipe.any.html
- PASS [expected FAIL] subtest: using pipeThrough on Response body should disturb it synchronously
OK /fetch/api/response/response-stream-disturbed-by-pipe.any.worker.html
- PASS [expected FAIL] subtest: using pipeThrough on Response body should disturb it synchronously

github-actions · 2025-05-12T12:53:57Z

⚠️ Try run (#14972142620) failed.

components/script/dom/transformstream.rs

Signed-off-by: Taym Haddadi <[email protected]>

…port Signed-off-by: Taym Haddadi <[email protected]>

github-actions · 2025-05-12T21:02:32Z

🔨 Triggering try run (#14982551314) for Linux (WPT)

gterzian · 2025-05-12T21:25:26Z

sanity check: the transfer without transforms works:

github-actions · 2025-05-12T21:30:53Z

Test results for linux-wpt from try job (#14982551314):

Flaky unexpected result (24)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```

OK /_mozilla/css/offset_properties_inline.html

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

TIMEOUT [expected OK] /_mozilla/mozilla/window_resizeTo.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
FAIL [expected PASS] /css/css-tables/table-cell-overflow-auto-scrolled.html (#35011)

OK /css/css-values/cap-invalidation.html (#32757)

FAIL [expected PASS] subtest: CSS Values and Units Test: cap invalidation

uncaught exception: Error: assert_not_equals: expect the capital height of Ahem and sans-serif to be different got disallowed value 371.3333333333333

OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- PASS [expected FAIL] subtest: sec-fetch-user
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html (#34893)
- TIMEOUT [expected FAIL] subtest: Replace before load, triggered by same-document formElement.submit()
```
Test timed out
```
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
TIMEOUT [expected OK] /html/browsers/sandboxing/sandbox-initial-empty-document-toward-same-origin.html (#35948)
- TIMEOUT [expected PASS] subtest: Check sandbox-flags inheritance in case of javascript window reuse.
```
Test timed out
```
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-serializable.html (#34120)
CRASH [expected OK] /html/semantics/embedded-content/media-elements/offsets-into-the-media-resource/currentTime.html (#36809)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic test (normal form)
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (normal form)
- PASS [expected FAIL] subtest: text/plain: 0x00 in filename (normal form)

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

OK /resize-observer/eventloop.html (#33599)
- FAIL [expected PASS] subtest: test0: multiple notifications inside same event loop
```
assert_equals: new loop expected 1 but got 0
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```

Stable unexpected results that are known to be intermittent (13)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- FAIL [expected PASS] subtest: WebGL test #44
```
assert_true: could not create image (SVG) expected true got false
```
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 10deg' should prefer 'oblique -40deg -30deg' over 'italic'
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/oversized-payload.tentative.https.window.html (#35210)
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url with document.write and href navigation
```
assert_array_equals: expected property 1 to be "href" but got "click" (expected array ["write", "href"] got ["write", "click"])
```

OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)

FAIL [expected PASS] subtest: form submission

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1=" but got "about:blank"

OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

promise_test: Unhandled rejection with value: object "TypeError: w.document.body is null"

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

assert_equals: expected Element node &lt;area autofocus="" href="/common/blank.html"&gt;&lt;/area&gt; but got Element node &lt;body&gt;
&lt;img src="/media/poster.png" usemap="#map"&gt;
&lt;map n...

TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm (#34434)
- FAIL [expected PASS] subtest: default object size after src is removed
```
assert_equals: expected "320px" but got "300px"
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)
- FAIL [expected PASS] subtest: X Stitched sine-wave buffers at sample rate 43800 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732959747314453,0.4248766601085663,0.480754554271698,0.5347436666488647,0.5866320133209229,0.6362156271934509,0.6832997798919678,0.7276994585990906,0.7692402601242065,0.8077589869499207...] with an element-wise tolerance of {"absoluteThreshold":0.0038986,"relativeThreshold":0}. Index Actual Expected AbsError RelError Test threshold [14650] -2.9975518000000000e+7 8.6956524848937988e-1 2.9975518869565248e+7 3.4471845467190772e+7 3.8985999999999999e-3 [14651] 3.0547976493835449e-1 8.9879405498504639e-1 5.9331429004669189e-1 6.6012262403823208e-1 3.8985999999999999e-3 Max AbsError of 2.9975518869565248e+7 at index of 14650. Max RelError of 3.4471845467190772e+7 at index of 14650.
```
assert_true: expected true got false
```
- FAIL [expected PASS] subtest: X SNR (-106.101248243493 dB) is not greater than or equal to 65.737. Got -106.101248243493.
```
assert_true: expected true got false
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results (1)

TIMEOUT [expected OK] /streams/transferable/transform-stream.html

github-actions · 2025-05-12T21:31:00Z

⚠️ Try run (#14982551314) failed.

Taym95 · 2025-05-12T23:35:27Z

sanity check: the transfer without transforms works:

then something is wrong with Transfrom::tramsfer

gterzian · 2025-05-13T07:51:13Z



What's Confirmed from Logs:

    start_promise resolves.

    transform1 and transform2 perform as expected:
    Transforming chunk in transform1: hello
    Transforming chunk in transform2: HELLO
    Received chunk in sink: HELLO HELLO
    Transforming chunk in transform1: there

    But transform2 never receives "THERE", and nothing like Received chunk in sink: THERE THERE shows up.

    Timeout still occurs, which suggests the second chunk never reaches the final sink.

The above is from @Taym95 in zulip, which led me to think that the problem is an early disentanglement, and the below screenshots shows the test passing if you remove all disentanglement:

So it looks like the problem is that ports are disentangled too early because we are using one set of ports, which is option 1, which means we need to go for option 2.

This also means we can address this note, and since each port will in option 2 only ever have one cross realm transform, those two optional members can be merged into one enum, with one variant for each type of cross realm transform.

gterzian

Just a quick note to clarify how to implement the "option 2" mentioned in the previous PR.

components/script/dom/transformstream.rs

Signed-off-by: Taym Haddadi <[email protected]>

github-actions · 2025-05-19T12:01:35Z

🔨 Triggering try run (#15112413332) for Linux (WPT)

github-actions · 2025-05-19T12:30:07Z

Test results for linux-wpt from try job (#15112413332):

Flaky unexpected result (20)

TIMEOUT [expected OK] /_mozilla/mozilla/window_resizeTo.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '501 550' over '502 560'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '501' should prefer '390 410' over '300 350'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 20deg' over 'oblique 30deg 60deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 10deg' should prefer 'oblique 40deg 50deg' over 'oblique 0deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
OK /css/css-grid/alignment/grid-content-alignment-with-abspos-001.html (#34339)
- PASS [expected FAIL] subtest: .grid 1
FAIL [expected PASS] /css/css-overflow/line-clamp/line-clamp-021.tentative.html (#35008)
FAIL [expected PASS] /css/css-overflow/overflow-video.html (#34720)
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html
- FAIL [expected PASS] subtest: listeners are called correct number of times
```
assert_equals: expected 4 but got 6
```
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
OK /html/browsers/windows/browsing-context-names/duplicate-name-order.html (#34623)
- PASS [expected FAIL] subtest: Duplicate name lookup order
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
OK /html/interaction/focus/the-autofocus-attribute/document-with-fragment-valid.html (#28259)
- PASS [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with URL fragments should be skipped.
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK /resize-observer/eventloop.html (#33599)
- FAIL [expected PASS] subtest: test0: multiple notifications inside same event loop
```
assert_equals: new loop expected 1 but got 0
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
OK /service-workers/service-worker/fetch-event.https.html (#36234)
- PASS [expected FAIL] subtest: Service Worker falls back to network in fetch event with POST form

Stable unexpected results that are known to be intermittent (13)

FAIL [expected PASS] /css/css-tables/table-cell-overflow-auto-scrolled.html (#35011)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy same-origin destination
```
Test timed out
```

OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)

FAIL [expected PASS] subtest: form submission

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1=" but got "about:blank"

OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)

FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"

OK /html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm (#34434)
- FAIL [expected PASS] subtest: default object size after src is removed
```
assert_equals: expected "320px" but got "300px"
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
ERROR /service-workers/idlharness.https.any.html (#36250)
- PASS [expected TIMEOUT] subtest: ServiceWorkerContainer interface: operation register((TrustedScriptURL or USVString), optional RegistrationOptions)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation enable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation disable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation setHeaderValue(ByteString)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation getState()
OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)
- FAIL [expected PASS] subtest: X Stitched sine-wave buffers at sample rate 43800 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732959747314453,0.4248766601085663,0.480754554271698,0.5347436666488647,0.5866320133209229,0.6362156271934509,0.6832997798919678,0.7276994585990906,0.7692402601242065,0.8077589869499207...] with an element-wise tolerance of {"absoluteThreshold":0.0038986,"relativeThreshold":0}. Index Actual Expected AbsError RelError Test threshold [14650] 5.4234420011537247e+26 8.6956524848937988e-1 5.4234420011537247e+26 6.2369580782757815e+26 3.8985999999999999e-3 [14651] 3.0547976493835449e-1 8.9879405498504639e-1 5.9331429004669189e-1 6.6012262403823208e-1 3.8985999999999999e-3 Max AbsError of 5.4234420011537247e+26 at index of 14650. Max RelError of 6.2369580782757815e+26 at index of 14650.
```
assert_true: expected true got false
```
- FAIL [expected PASS] subtest: X SNR (-491.25141405851247 dB) is not greater than or equal to 65.737. Got -491.25141405851247.
```
assert_true: expected true got false
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

github-actions · 2025-05-19T12:30:17Z

✨ Try run (#15112413332) succeeded.

gterzian

Lgtm, with one nit. Good to see it all coming together!

components/script/dom/transformstream.rs

Signed-off-by: Taym Haddadi <[email protected]>

Taym95 · 2025-05-20T16:01:28Z

Thanks @gterzian @jdm for review!

In #36977, when transferring `TransformStream`, `CrossRealmTransform::Writable` and `CrossRealmTransform::Readable` are set to different message ports. The message port will not be readable and writable at the same time when transferring the stream, so we can now merge `cross_realm_transform_readable` and `cross_realm_transform_writable` into a single field `cross_realm_transform`. Testing: WPT ([passed on try branch](https://github.com/pewsheen/servo/actions/runs/15209389525/job/42784179519)) Fixes: #37084 --------- Signed-off-by: Jason Tsai <[email protected]>

Taym95 requested a review from jdm May 12, 2025 12:24

Taym95 requested a review from gterzian as a code owner May 12, 2025 12:24

Taym95 added the T-linux-wpt Do a try run of the WPT label May 12, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label May 12, 2025

Taym95 force-pushed the stream-implement-pipeThrough branch from 0b778bd to 469f704 Compare May 12, 2025 12:25

jdm reviewed May 12, 2025

View reviewed changes

components/script/dom/readablestream.rs Outdated Show resolved Hide resolved

tests/wpt/meta/streams/piping/pipe-through.any.js.ini Show resolved Hide resolved

tests/wpt/meta/streams/transferable/transform-stream.html.ini Outdated Show resolved Hide resolved

Taym95 force-pushed the stream-implement-pipeThrough branch from 469f704 to d7f5629 Compare May 12, 2025 12:35

Taym95 force-pushed the stream-implement-pipeThrough branch from 7430115 to 6885f7f Compare May 12, 2025 13:05

gterzian requested changes May 12, 2025

View reviewed changes

components/script/dom/transformstream.rs Outdated Show resolved Hide resolved

Taym95 added 3 commits May 12, 2025 22:56

Stream: implement pipeThrough

cb6ff86

Signed-off-by: Taym Haddadi <[email protected]>

Add an entry to Bindings.conf for the CanGc and InRealm

a55d21c

Signed-off-by: Taym Haddadi <[email protected]>

Remove Clone from MessagePortImpl and only transfer_receive a single …

1019bce

…port Signed-off-by: Taym Haddadi <[email protected]>

Taym95 force-pushed the stream-implement-pipeThrough branch from 6885f7f to 1019bce Compare May 12, 2025 21:01

Taym95 added the T-linux-wpt Do a try run of the WPT label May 12, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label May 12, 2025

gterzian mentioned this pull request May 13, 2025

Streams: implement ReadableStream PipeThrough #36598

Closed

gterzian requested changes May 18, 2025

View reviewed changes

components/script/dom/transformstream.rs Show resolved Hide resolved

FIx transform-stream.html TIMEOUT test

b4fdfc1

Signed-off-by: Taym Haddadi <[email protected]>

Taym95 requested review from gterzian and jdm May 19, 2025 12:01

Taym95 added the T-linux-wpt Do a try run of the WPT label May 19, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label May 19, 2025

gterzian approved these changes May 20, 2025

View reviewed changes

components/script/dom/transformstream.rs Outdated Show resolved Hide resolved

Fix arg name

0cd1480

Signed-off-by: Taym Haddadi <[email protected]>

Taym95 enabled auto-merge May 20, 2025 14:01

Taym95 added this pull request to the merge queue May 20, 2025

Merged via the queue into servo:main with commit 5b23057 May 20, 2025
21 checks passed

Taym95 deleted the stream-implement-pipeThrough branch May 20, 2025 15:01

gterzian mentioned this pull request May 22, 2025

Streams: rationalize management of cross realm transforms #37084

Closed

pewsheen mentioned this pull request May 23, 2025

refactor: merge cross_realm_transform_* fields into one #37102

Merged

Uh oh!

Conversation

Taym95 commented May 12, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

gterzian commented May 12, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

Taym95 commented May 12, 2025

Uh oh!

gterzian commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gterzian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

gterzian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Taym95 commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gterzian commented May 13, 2025 •

edited

Loading