Implement inner slot for cryptographic nonce#36965
Conversation
| [Writing 'nonce' IDL attribute.] | ||
| expected: FAIL | ||
|
|
||
| [createElement.nonce.] |
There was a problem hiding this comment.
I am a bit confused why this one isn't passing, but it's been a long evening. So need to investigate later what's going on.
There was a problem hiding this comment.
It has to do with document.currentScript pointing to the wrong value. I think this is not a problem with handling nonces, but a problem in the JS engine. Therefore, let's leave this test failing for now until the JS engine updates are there.
|
Try run has test failures, but they are expected atm: web-platform-tests/wpt#43286 Will look into updating these tests to reflect (no pun intended) the new behavior. |
TimvdLippe
force-pushed
the
pr-timvdlippe-nonce-internal-slot
branch
from
9776899 to
cc9cc60
Compare
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#52506) with upstreamable changes. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#52506) title and body. |
TimvdLippe
force-pushed
the
pr-timvdlippe-nonce-internal-slot
branch
from
cc9cc60 to
d611ea8
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#52506). |
TimvdLippe
force-pushed
the
pr-timvdlippe-nonce-internal-slot
branch
from
d611ea8 to
23e568e
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#52506). |
Also update the `html/dom/reflection-metadata.html` test to handle the case where `nonce` does not reflect back to the attribute after an IDL change. Part of servo#4577 Fixes web-platform-tests/wpt#43286 Signed-off-by: Tim van der Lippe <[email protected]>
TimvdLippe
force-pushed
the
pr-timvdlippe-nonce-internal-slot
branch
from
23e568e to
17d51d3
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#52506). |
3 participants
Also update the
html/dom/reflection-metadata.htmltestto handle the case where
noncedoes not reflect backto the attribute after an IDL change.
Part of #4577
Fixes web-platform-tests/wpt#43286