net: Fix unit tests requiring default resources.#36838
Merged
jdm merged 1 commit intoservo:mainfrom May 5, 2025
Merged
Conversation
Signed-off-by: Josh Matthews <[email protected]>
mukilan
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all unit tests are run, the existing feature flag use from net_traits was enough to ensure the default resources are baked into the test binary. When only the unit tests for the
netcrate are run, that feature flag was not enabled in the build so the tests that require the resources fail.Testing: Ran
./mach test-unit -p netFixes: #36837