Merged
Conversation
|
🔨 Triggering try run (#14825801825) for Linux (WPT) |
nicoburns
approved these changes
May 4, 2025
Contributor
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
Looks good! Not too many changes this time :)
| @@ -24,7 +24,7 @@ use style::stylesheets::container_rule::ContainerSizeQuery; | |||
| use style::stylesheets::layer_rule::LayerOrder; | |||
Contributor
There was a problem hiding this comment.
Not directly relevant to this PR, but these tests (the whole of tests/unit/style) exist upstream in the Mozilla repo. We should start syncing (and running) them in the Stylo repo, and then delete them here. Then we'd get these fixes automatically.
|
Test results for linux-wpt from try job (#14825801825): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (23)
|
|
✨ Try run (#14825801825) succeeded. |
Contributor
Author
|
Pushed some extra change so that Gecko compiles: |
Contributor
Author
|
Oh, and I will need to increase the crate version numbers in order to publish. |
Contributor
Commit for that here: servo/stylo@7377440 (I already prepared it to put up as a PR once you landed the sync, but pushed it now seeing as you mention it here). Ideally we'd also land servo/stylo#163 before publishing so the docs.rs is more consistent (but that can also wait until next time if need be). |
Contributor
Author
I guess it's better to include it into the upgrade. But selectors should also get a new version, there are upstream changes |
Loirooriol
force-pushed
the
stylo-2025-05-01
branch
from
c993964 to
42ca82a
Compare
Narfinger
pushed a commit
to Narfinger/servo
that referenced
this pull request
May 6, 2025
This continues servo#35990 Changelog: - Upstream: servo/stylo@4558df3...ca369cb - Servo fixups: servo/stylo@2bc1e51...7edd19e Stylo tracking issue: servo/stylo#178 --------- Signed-off-by: Oriol Brufau <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
This continues #36835 Changelog: - Upstream: servo/stylo@ca369cb...7e2201c - Servo fixups: servo/stylo@f387e63...2e1f66b Stylo tracking issue: servo/stylo#200 --------- Signed-off-by: Oriol Brufau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #35990
Changelog:
Stylo tracking issue: servo/stylo#178