Script implement TransformStream and TransformStreamDefaultController#36739
Merged
Taym95 merged 11 commits intoservo:mainfrom May 8, 2025
Merged
Conversation
Taym95
changed the title
gterzian
requested changes
Apr 29, 2025
Member
gterzian
left a comment
gterzian
left a comment
There was a problem hiding this comment.
Looks good overall, I think I have found the reason for the timeouts you mentioned earlier.
Taym95
force-pushed
the
script-implement-TransformStream-TransformStreamDefaultController
branch
from
6d3252f to
a2f9d69
Compare
|
🔨 Triggering try run (#14786276365) for Linux (WPT) |
|
|
Taym95
force-pushed
the
script-implement-TransformStream-TransformStreamDefaultController
branch
from
a2f9d69 to
93514d4
Compare
|
🔨 Triggering try run (#14792811506) for Linux (WPT) |
|
Test results for linux-wpt from try job (#14792811506): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (111)
|
|
|
Taym95
force-pushed
the
script-implement-TransformStream-TransformStreamDefaultController
branch
from
93514d4 to
e042d85
Compare
|
🔨 Triggering try run (#14799657436) for Linux (WPT) |
Taym95
commented
May 2, 2025
|
Test results for linux-wpt from try job (#14799657436): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (109)
|
|
|
Taym95
force-pushed
the
script-implement-TransformStream-TransformStreamDefaultController
branch
from
e042d85 to
47aab82
Compare
|
🔨 Triggering try run (#14804808853) for Linux (WPT) |
|
Test results for linux-wpt from try job (#14804808853): Flaky unexpected result (27)
Stable unexpected results that are known to be intermittent (14)
Stable unexpected results (19)
|
|
|
Taym95
force-pushed
the
script-implement-TransformStream-TransformStreamDefaultController
branch
from
47aab82 to
93f7c84
Compare
|
🔨 Triggering try run (#14891053852) for Linux (WPT) |
|
Test results for linux-wpt from try job (#14891053852): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (1)
|
|
|
Member
Signed-off-by: Taym Haddadi <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Taym95
force-pushed
the
script-implement-TransformStream-TransformStreamDefaultController
branch
from
6b246ac to
146aed0
Compare
gterzian
approved these changes
May 7, 2025
| #[ignore_malloc_size_of = "mozjs"] | ||
| chunk: Box<Heap<JSVal>>, | ||
|
|
||
| writable: Dom<WritableStream>, |
Member
There was a problem hiding this comment.
/// The writable used in the fulfillment steps
See also other member below.
| // Return ! TransformStreamDefaultControllerPerformTransform(controller, chunk). | ||
| rooted!(in(*cx) let mut chunk = UndefinedValue()); | ||
| chunk.set(self.chunk.get()); | ||
|
|
Member
There was a problem hiding this comment.
I don't think we need a space here, since all of these are part of the above spec step.
| can_gc, | ||
| ) | ||
| .expect("perform transform failed"); | ||
|
|
Member
There was a problem hiding this comment.
let's add a note that those rejection and fulfillment hanlders do not have to be rooted because they only contain an Rc.
|
|
||
| #[derive(JSTraceable, MallocSizeOf)] | ||
| #[cfg_attr(crown, crown::unrooted_must_root_lint::must_root)] | ||
| struct PerformTransformFulfillment { |
Member
There was a problem hiding this comment.
Would be good to document this and the ones below with links to the spec like is done with other types of handlers.
| } | ||
|
|
||
| impl js::gc::Rootable for FlushPromiseFulfillment {} | ||
| /// Reacting to fulfillment of the flushpromise as part of |
Member
There was a problem hiding this comment.
A space between the impl and the docs would be good.
| // Perform ! TransformStreamDefaultControllerClearAlgorithms(controller). | ||
| controller.clear_algorithms(); | ||
|
|
||
| // React to cancelPromise: |
| transformer_obj.handle(), | ||
| &transformer_dict, | ||
| can_gc, | ||
| ); |
Member
There was a problem hiding this comment.
Note that a ? in the spec would point to a ? here, but I guess it is not noticeable. Perhaps just add a note for now, or file an issue to clean this up across the streams implementation later.
| .error(cx, &self.controller.global(), v, can_gc); | ||
|
|
||
| // Throw r. | ||
| // Note: this is dont on perform_transform() |
| can_gc, | ||
| ); | ||
|
|
||
| match call_result { |
Member
There was a problem hiding this comment.
I would not add a space here(and elsewhere).
| /// <https://streams.spec.whatwg.org/#ts-default-controller-enqueue> | ||
| fn Enqueue(&self, cx: SafeJSContext, chunk: SafeHandleValue, can_gc: CanGc) -> Fallible<()> { | ||
| // Perform ? TransformStreamDefaultControllerEnqueue(this, chunk). | ||
| self.enqueue(cx, &self.global(), chunk, can_gc) |
Member
There was a problem hiding this comment.
For example here, not how the spec uses ? and we also follow that by propagating the error? So we should do that consistently.
…e" and Fix doc and comments Signed-off-by: Taym Haddadi <[email protected]>
Taym95
force-pushed
the
script-implement-TransformStream-TransformStreamDefaultController
branch
from
21311cb to
d1f4dc0
Compare
Signed-off-by: Taym <[email protected]>
Member
Author
Taym95
deleted the
script-implement-TransformStream-TransformStreamDefaultController
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 12, 2025
Part of #34676 #36739 needs to be merged first. --------- Signed-off-by: Taym Haddadi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #34676