Skip to content

Switch to data_url::mime for document content type#36522

Merged
jdm merged 1 commit intoservo:mainfrom
webbeef:charset-from-data-url
Apr 15, 2025
Merged

Switch to data_url::mime for document content type#36522
jdm merged 1 commit intoservo:mainfrom
webbeef:charset-from-data-url

Conversation

@webbeef
Copy link
Copy Markdown
Contributor

@webbeef webbeef commented Apr 14, 2025

The data_url Mime parser has a more conformant behavior in most cases, including dealing with charsets.

Testing: wpt expectations with new passes are updated.

The data_url Mime parser has a more conformant behavior in most
cases, including dealing with charsets.

Signed-off-by: webbeef <[email protected]>
@webbeef webbeef requested a review from gterzian as a code owner April 14, 2025 20:05
@webbeef
Copy link
Copy Markdown
Contributor Author

webbeef commented Apr 14, 2025

Ideally we would switch to data_url::mime::Mime for all our internal mime usage, since the Mime crate is more http compliant than whatwg compliant. This requires a lot more changes though.

Copy link
Copy Markdown
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdm jdm added this pull request to the merge queue Apr 15, 2025
Merged via the queue into servo:main with commit 98884a5 Apr 15, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants