Script Implement ReadableByteStreamTee#35991
Merged
Taym95 merged 2 commits intoservo:mainfrom Dec 3, 2025
Merged
Conversation
Member
|
Is this one ready for review? |
Member
Author
Yes ready, sorry forgot about it |
gterzian
approved these changes
Apr 3, 2025
Member
gterzian
left a comment
gterzian
left a comment
There was a problem hiding this comment.
LGTM with a couple of questions.
| if result.is_null() { | ||
| rooted!(in(*cx) let mut rval = UndefinedValue()); | ||
| assert!(JS_GetPendingException(*cx, rval.handle_mut().into())); | ||
| JS_ClearPendingException(*cx); |
Member
There was a problem hiding this comment.
It seems to me that the duplication of these three lines for all arms could be removed if you move it to outside this match before returning the result.
| can_gc: CanGc, | ||
| ) { | ||
| let mut reader = self.reader.borrow_mut(); | ||
| match &*reader { |
Member
There was a problem hiding this comment.
This doesn't seem correct: I think it should be an if &*reader == eaderType::BYOB(byte_reader), followed by "Let readRequest be a read request with the following items:" that should run for both reader types.
Member
Author
There was a problem hiding this comment.
read request is readerType::Default specific, BYOB reader has read_into.
| can_gc, | ||
| ); | ||
| }, | ||
| ReaderType::Default(default_reader) => { |
Member
There was a problem hiding this comment.
Same here, you want to run the "If reader implements ReadableStreamDefaultReader" only for ReaderType::Default, but the other steps should run for both types.
Member
Author
There was a problem hiding this comment.
same here read_into is ReaderType::BYOB specific.
| let this_reader = this_reader.borrow_mut(); | ||
| match &*this_reader { | ||
| ReaderType::Default(_reader) => { | ||
| // TODO |
Member
There was a problem hiding this comment.
Is the logic not the same for both readers? Seems like it would be worth making byte_tee_append_native_handler_to_closed_promise a function taking all the arguments, including the closed_promised from the reader.
| /// Upon rejection of `reader.closedPromise` with reason `r``, | ||
| fn callback(&self, _cx: SafeJSContext, v: SafeHandleValue, _realm: InRealm, can_gc: CanGc) { | ||
| // If thisReader is not reader, return. | ||
| // TODO: Implement this check. |
Member
There was a problem hiding this comment.
For this I think you would have to add the this_reader: Rc<RefCell<ReaderType>> and also the &self reader from when forward_reader_error was called. Could be a TODO indeed, we should note it in the issue.
| ); | ||
| } | ||
|
|
||
| /// <https://streams.spec.whatwg.org/#read-request-chunk-steps> |
Member
There was a problem hiding this comment.
gterzian
reviewed
Apr 3, 2025
| ); | ||
| } | ||
|
|
||
| /// <https://streams.spec.whatwg.org/#read-request-chunk-steps> |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
I always have hard time founding these links!
Member
There was a problem hiding this comment.
You need to go to the original link, and then click on the name to open this popover that gives you the references, like below.
| } | ||
| } | ||
|
|
||
| /// <https://streams.spec.whatwg.org/#read-request-close-steps> |
Member
There was a problem hiding this comment.
| self.cancel_promise.resolve_native(&(), can_gc); | ||
| } | ||
| } | ||
| /// <https://streams.spec.whatwg.org/#read-request-error-steps> |
Member
There was a problem hiding this comment.
| } | ||
| } | ||
|
|
||
| /// <https://streams.spec.whatwg.org/#read-request-close-steps> |
Member
There was a problem hiding this comment.
| } | ||
| } | ||
| /// <https://streams.spec.whatwg.org/#read-request-error-steps> | ||
| pub(crate) fn error_steps(&self) { |
Member
There was a problem hiding this comment.
|
🔨 Triggering try run (#14419627106) for Linux (WPT) |
|
|
Taym95
force-pushed
the
Script-Implement-ReadableByteStreamTee
branch
2 times, most recently
from
ed97eb0 to
531f053
Compare
|
🔨 Triggering try run (#14537679420) for Linux (WPT) |
|
Test results for linux-wpt from try job (#14537679420): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (4)
|
|
|
Member
|
@Taym95 Do you plan to land this? It's gotten quite stale. |
Member
Author
Yes, I will get back to this in the next few days. |
Taym95
force-pushed
the
Script-Implement-ReadableByteStreamTee
branch
from
531f053 to
c61a34d
Compare
servo-highfive
added
the
S-awaiting-review
Taym95
force-pushed
the
Script-Implement-ReadableByteStreamTee
branch
from
c61a34d to
2924564
Compare
|
🔨 Triggering try run (#19392271271) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19392271271): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (27)
Stable unexpected results (5)
|
|
|
Signed-off-by: Taym Haddadi <[email protected]>
Taym95
force-pushed
the
Script-Implement-ReadableByteStreamTee
branch
from
2924564 to
eafdb0b
Compare
|
🔨 Triggering try run (#19894787408) for Linux (WPT) |
Member
Author
|
I finally had some time to revisit this. All tests/wpt/meta/streams/readable-byte-streams/tee.any.js.ini tests are now passing, and stream tee is fully supported. 🎉, This will improve the fetch spec compliance #40825 |
Signed-off-by: Taym Haddadi <[email protected]>
servo-highfive
added
the
S-awaiting-merge
|
Test results for linux-wpt from try job (#19894787408): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (27)
|
|
✨ Try run (#19894787408) succeeded. |
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsAll stream tee tests are passing now.