Upgrade Stylo to 2025-03-15 by nicoburns · Pull Request #35990 · servo/servo

nicoburns · 2025-03-16T05:36:34Z

Upgrade Stylo to version 2025-03-15.
Currently uses a git version of cssparser as the new version of Stylo requires unreleased cssparser changes.

./mach build -d does not report any errors
./mach test-tidy does not report any errors

Cargo.toml

github-actions · 2025-03-17T00:05:51Z

🔨 Triggering try run (#13888724450) for Linux (WPT)

github-actions · 2025-03-17T00:30:03Z

Test results for linux-wpt-layout-2020 from try job (#13888724450):

Flaky unexpected result (30)

OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '400' should prefer '501 550' over '502 560'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '501' should prefer '500' over '450 460'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```

OK /css/css-grid/alignment/grid-content-alignment-with-abspos-001.html (#34339)

FAIL [expected PASS] subtest: .grid 1

assert_equals: 
&lt;div class="grid" data-expected-width="800" data-expected-height="600"&gt;
    &lt;div class="a" id="item" data-offset-x="329" data-offset-y="269" data-expected-width="142" data-expected-height="62" style="place-self: center;"&gt;&lt;/div&gt;
  &lt;/div&gt;
offsetLeft expected 329 but got 0

FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#31559)

OK /css/css-values/cap-invalidation.html (#32757)

FAIL [expected PASS] subtest: CSS Values and Units Test: cap invalidation

uncaught exception: Error: assert_not_equals: expect the capital height of Ahem and sans-serif to be different got disallowed value 371.3333333333333

OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - Non-empty name exists
- PASS [expected FAIL] subtest: Newline normalization - \r\n in filename (urlencoded)
OK /encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-errors-misc.html?1-1000
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+80 � %26%23128%3B
```
assert_equals: expected "%26%23128%3B" but got ""
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+81 � %26%23129%3B
```
assert_equals: expected (string) "%26%23129%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+82 � %26%23130%3B
```
assert_equals: expected (string) "%26%23130%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+83 � %26%23131%3B
```
assert_equals: expected (string) "%26%23131%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+84 � %26%23132%3B
```
assert_equals: expected (string) "%26%23132%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+85 � %26%23133%3B
```
assert_equals: expected (string) "%26%23133%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+86 � %26%23134%3B
```
assert_equals: expected (string) "%26%23134%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+87 � %26%23135%3B
```
assert_equals: expected (string) "%26%23135%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+88 � %26%23136%3B
```
assert_equals: expected (string) "%26%23136%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+89 � %26%23137%3B
```
assert_equals: expected (string) "%26%23137%3B" but got (undefined) undefined
```
- And 590 more unexpected results...
OK /encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-misc.html?1-1000
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+80 � %26%23128%3B
```
assert_equals: expected "%26%23128%3B" but got ""
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+81 � %26%23129%3B
```
assert_equals: expected (string) "%26%23129%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+82 � %26%23130%3B
```
assert_equals: expected (string) "%26%23130%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+83 � %26%23131%3B
```
assert_equals: expected (string) "%26%23131%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+84 � %26%23132%3B
```
assert_equals: expected (string) "%26%23132%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+85 � %26%23133%3B
```
assert_equals: expected (string) "%26%23133%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+86 � %26%23134%3B
```
assert_equals: expected (string) "%26%23134%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+87 � %26%23135%3B
```
assert_equals: expected (string) "%26%23135%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+88 � %26%23136%3B
```
assert_equals: expected (string) "%26%23136%3B" but got (undefined) undefined
```
- FAIL [expected PASS] subtest: latin, greek, cyrillic, etc U+89 � %26%23137%3B
```
assert_equals: expected (string) "%26%23137%3B" but got (undefined) undefined
```
- And 390 more unexpected results...
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/oversized-payload.tentative.https.window.html (#35210)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- PASS [expected FAIL] subtest: sec-fetch-user
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html (#28765)
- TIMEOUT [expected FAIL] subtest: Replace before load, triggered by submitButton.click()
```
Test timed out
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
OK /html/browsers/windows/browsing-context-names/duplicate-name-order.html (#34623)
- PASS [expected FAIL] subtest: Duplicate name lookup order
TIMEOUT [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-premultiplyAlpha.html (#35881)
TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-serializable.html (#34120)
- TIMEOUT [expected FAIL] subtest: Serialize ImageBitmap created from an HTMLVideoElement from a data URL
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Serialize ImageBitmap created from a bitmap HTMLImageElement
- NOTRUN [expected FAIL] subtest: Serialize ImageBitmap created from a vector HTMLImageElement
- NOTRUN [expected TIMEOUT] subtest: Serialize ImageBitmap created from a bitmap SVGImageElement
FAIL [expected PASS] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.html (#34117)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Non-HTMLElement should not support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
OK /html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm (#34434)
- FAIL [expected PASS] subtest: default object size after src is removed
```
assert_equals: expected "300px" but got "320px"
```
OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: \r\n in value (formdata event)
- PASS [expected FAIL] subtest: text/plain: single quote in value (normal form)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
OK /resize-observer/change-layout-in-error.html (#32629)
- PASS [expected FAIL] subtest: Changing layout in window error handler should not result in lifecyle loop when resize observer loop limit is reached.
OK /resize-observer/eventloop.html (#33599)
- FAIL [expected PASS] subtest: test0: multiple notifications inside same event loop
```
assert_equals: new loop expected 1 but got 0
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)
ERROR [expected OK] /workers/semantics/run-a-worker/003.html (#22765)
OK /xhr/open-url-multi-window-5.htm (#23360)
- FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)
```
assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw
```

Stable unexpected results that are known to be intermittent (11)

OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```

OK

/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html

(#29048)

FAIL [expected PASS] subtest: Navigating to a different document with link click

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"

FAIL [expected PASS] subtest: Navigating to a different document with form submission

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1=" but got "about:blank"

OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-transfer.html (#34119)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
OK [expected TIMEOUT] /mixed-content/gen/top.http-rp/opt-in/audio-tag.https.html (#35744)

github-actions · 2025-03-17T00:30:13Z

✨ Try run (#13888724450) succeeded.

Loirooriol · 2025-03-17T09:55:49Z

Do you need help force-pushing the main branch in Stylo?

nicoburns · 2025-03-17T10:01:25Z

Do you need help force-pushing the main branch in Stylo?

@Loirooriol I do indeed. I don't have permissions to access the settings screen that allows you to change the branch protection settings.

Signed-off-by: Nico Burns <[email protected]>

simonwuelker · 2025-03-17T17:51:27Z

I currently can't build servo due to the following error:

No build type specified so assuming `--dev`.
    Updating git repository `https://github.com/servo/stylo`
    Updating git repository `https://github.com/servo/rust-cssparser`
error: no matching package named `style` found
location searched: Git repository https://github.com/servo/stylo?branch=2025-03-15
required by package `libservo v0.0.1 (/home/alaska/servo/components/servo)`
Failed in 0:00:00

Could this be related to this PR?

Loirooriol · 2025-03-17T17:55:46Z

It's because of servo/stylo#150, we need to update Servo.

This continues #35990 Changelog: - Upstream: servo/stylo@4558df3...ca369cb - Servo fixups: servo/stylo@2bc1e51...7edd19e Stylo tracking issue: servo/stylo#178 --------- Signed-off-by: Oriol Brufau <[email protected]>

This continues servo#35990 Changelog: - Upstream: servo/stylo@4558df3...ca369cb - Servo fixups: servo/stylo@2bc1e51...7edd19e Stylo tracking issue: servo/stylo#178 --------- Signed-off-by: Oriol Brufau <[email protected]>

nicoburns mentioned this pull request Mar 16, 2025

Upgrade to 2025-03-15 servo/stylo#148

Closed

nicoburns force-pushed the stylo-sync-2025-03-15 branch from 39d1cda to aad52b7 Compare March 16, 2025 23:40

Loirooriol reviewed Mar 17, 2025

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

Loirooriol added the T-linux-wpt Do a try run of the WPT label Mar 17, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Mar 17, 2025

nicoburns force-pushed the stylo-sync-2025-03-15 branch from aad52b7 to d2f27c3 Compare March 17, 2025 09:44

Loirooriol approved these changes Mar 17, 2025

View reviewed changes

nicoburns force-pushed the stylo-sync-2025-03-15 branch from d2f27c3 to c39904d Compare March 17, 2025 10:37

Upgrade Stylo to 2025-03-15

3965447

Signed-off-by: Nico Burns <[email protected]>

nicoburns force-pushed the stylo-sync-2025-03-15 branch from c39904d to 3965447 Compare March 17, 2025 10:40

nicoburns enabled auto-merge March 17, 2025 10:40

nicoburns mentioned this pull request Mar 17, 2025

Rework ElementAnimationSet::start_transition_if_applicable to be more like the specification servo/stylo#145

Merged

nicoburns added this pull request to the merge queue Mar 17, 2025

Merged via the queue into servo:main with commit 16f1ec4 Mar 17, 2025
21 checks passed

nicoburns deleted the stylo-sync-2025-03-15 branch March 17, 2025 11:38

Loirooriol mentioned this pull request May 4, 2025

Upgrade Stylo to 2025-05-01 #36835

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade Stylo to 2025-03-15#35990

Upgrade Stylo to 2025-03-15#35990
nicoburns merged 1 commit intoservo:mainfrom
nicoburns:stylo-sync-2025-03-15

nicoburns commented Mar 16, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

Loirooriol commented Mar 17, 2025

Uh oh!

nicoburns commented Mar 17, 2025

Uh oh!

Uh oh!

simonwuelker commented Mar 17, 2025

Uh oh!

Loirooriol commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nicoburns commented Mar 16, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

Loirooriol commented Mar 17, 2025

Uh oh!

nicoburns commented Mar 17, 2025

Uh oh!

Uh oh!

simonwuelker commented Mar 17, 2025

Uh oh!

Loirooriol commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants