Streams: Implement stream pipe-to#35650
Merged
Taym95 merged 33 commits intoservo:mainfrom Mar 18, 2025
Merged
Conversation
gterzian
force-pushed
the
implement_stream_pipeto
branch
2 times, most recently
from
c749273 to
66ffb89
Compare
gterzian
changed the title
gterzian
force-pushed
the
implement_stream_pipeto
branch
6 times, most recently
from
e9a6e46 to
4656a4a
Compare
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#51142) with upstreamable changes. |
gterzian
force-pushed
the
implement_stream_pipeto
branch
from
4b0cf7c to
5e3c26a
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#51142). |
gterzian
force-pushed
the
implement_stream_pipeto
branch
2 times, most recently
from
54640fc to
19c4e8d
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#51142). |
Collaborator
|
🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#51142). |
gterzian
commented
Mar 6, 2025
| expected: CRASH | ||
|
|
||
| [then-interception.any.html] | ||
| expected: CRASH |
gterzian
commented
Mar 6, 2025
| expected: ERROR | ||
|
|
||
| [pipe-through.any.worker.html] | ||
| expected: ERROR |
Member
Author
There was a problem hiding this comment.
Note: this PR implements PipeTo, not PipeThrough(although PipeThrough seems like an easy follow-up, since it uses the same underlying mechanism, but it requires TransformStream, or at least part of that IDL).
gterzian
commented
Mar 6, 2025
| [pipeThrough should stop after getting preventClose throws] | ||
| expected: FAIL | ||
|
|
||
| [pipeTo should stop after getting signal throws] |
gterzian
force-pushed
the
implement_stream_pipeto
branch
2 times, most recently
from
7ecf334 to
4a0f25f
Compare
gterzian
force-pushed
the
implement_stream_pipeto
branch
4 times, most recently
from
1ef5ce8 to
3600935
Compare
Member
Author
|
@Taym95 review ping on this one. I've just finished some clean-ups. |
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
improve comment on result add comment on backpressure Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
update test expectations Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
remove redundant logic in pending writes Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
…states Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
…ecking close and error states Signed-off-by: gterzian <[email protected]>
Signed-off-by: gterzian <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Signed-off-by: Taym Haddadi <[email protected]>
Taym95
force-pushed
the
implement_stream_pipeto
branch
from
bebc486 to
d611717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement https://streams.spec.whatwg.org/#rs-pipe-to
Part of #34676
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors