Install fonts-noto-cjk for linux-wpt workflow#35567
Conversation
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#50853) with upstreamable changes. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#50853) title and body. |
|
Rebasing should fix the test-tidy failure. |
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
|
@delan @Loirooriol PTAL, thanks! |
|
Looks like the DCO workflow has not started, for some reason. @xiaochengh can you try rebasing and doing a force push? |
Signed-off-by: Xiaocheng Hu <[email protected]>
Head branch was pushed to by a user without write access
32bec3f to
860cf04
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#50853). |
jschwe
left a comment
There was a problem hiding this comment.
Is it really okay to just remove size-adjust from the upstream wpt test?
This is modifying the reference file, so it doesn't use Also with this change, the test is still passing in Chromium, Firefox and failing in Safari as before this change, see: https://github.com/web-platform-tests/wpt/pull/50853/checks?check_run_id=37595996561 |
|
No big deal, but I don't see the need to change the ref, it seems to make the test slightly more fragile in case that |
|
@Loirooriol |
Right now CJK-related tests are not running properly as the characters are rendered as tofu.
This PR installs fonts-noto-cjk to fix it. Also:
css/css-fonts/size-adjust-unicode-range-system-fallback.htmlis a false pass, as the ref file depends on unsupportedsize-adjust. This PR removes the dependency to make it fail correctly./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsquotes#34770