Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servoshell: Port input dialog code to use egui intead of tinyfiledialogs #35464

Merged
merged 1 commit into from
Feb 14, 2025
Merged

servoshell: Port input dialog code to use egui intead of tinyfiledialogs #35464

merged 1 commit into from
Feb 14, 2025

Conversation

chickenleaf
Copy link
Contributor

  • Part of migration from tinyfiledialogs to egui
  • Input dialog uses egui now
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

@chickenleaf
Copy link
Contributor Author

@mukilan @mrobinson please review this

@chickenleaf chickenleaf marked this pull request as ready for review February 14, 2025 13:10
@chickenleaf chickenleaf changed the title servoshell: Port input dialog code to use egui intead of tinyfiledialogs servoshell: Port input dialog code to use egui intead of tinyfiledialogs Feb 14, 2025
@chickenleaf chickenleaf changed the title servoshell: Port input dialog code to use egui intead of tinyfiledialogs servoshell: Port input dialog code to use egui intead of tinyfiledialogs Feb 14, 2025
mrobinson
mrobinson requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think the changes to Cargo.lock are unintentional. Please revert those and amend your commit. Thank you!

@chickenleaf chickenleaf force-pushed the input-dialog branch 2 times, most recently from 75c8c47 to 31c930b Compare February 14, 2025 14:24
@mukilan mukilan enabled auto-merge February 14, 2025 14:34
@mukilan mukilan added this pull request to the merge queue Feb 14, 2025
Merged via the queue into servo:main with commit 32c13bc Feb 14, 2025
22 checks passed
@chickenleaf chickenleaf deleted the input-dialog branch February 17, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

@mukilan mukilan mukilan approved these changes

@atbrakhi atbrakhi Awaiting requested review from atbrakhi atbrakhi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chickenleaf @mrobinson @mukilan