Skip to content

Use surfman with glow bindings (take II)#35422

Merged
sagudev merged 2 commits intoservo:mainfrom
sagudev:reglowing-surfman
Feb 13, 2025
Merged

Use surfman with glow bindings (take II)#35422
sagudev merged 2 commits intoservo:mainfrom
sagudev:reglowing-surfman

Conversation

@sagudev
Copy link
Copy Markdown
Member

@sagudev sagudev commented Feb 11, 2025 •
edited
Loading

Reapply #34328 (so this is revert of revert) that depends on servo/surfman#332. There is nothing new apart from updated surfman version.

@sagudev
Copy link
Copy Markdown
Member Author

sagudev commented Feb 11, 2025

Can you test this @mukilan. I have only tested x11 on NVIDIA.

@mukilan
Copy link
Copy Markdown
Member

mukilan commented Feb 11, 2025

Sure! I'll need to switch my configuration, so I'll test it tomorrow.

@sagudev sagudev added the T-full Do a full try run label Feb 11, 2025
@github-actions github-actions bot removed the T-full Do a full try run label Feb 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 11, 2025

🔨 Triggering try run (#13265742349) for Linux (Unit Tests, WPT, Bencher), MacOS (Unit Tests), Windows (Unit Tests), Android, OpenHarmony, Lint

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 11, 2025

🐰 Bencher Report

Branch35422/PR
Testbedubuntu-22.04

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkFile Sizemegabytes (MB)Latencymicroseconds (µs)Throughputoperations / second (ops/s)scoreMeasure (units)
Dromaeo/dom📈 view plot
⚠️ NO THRESHOLD		594.24
Dromaeo/dom-attr📈 view plot
⚠️ NO THRESHOLD		4,371.08
Dromaeo/dom-attr/element_expando📈 view plot
⚠️ NO THRESHOLD		47,784.20
Dromaeo/dom-attr/element_expando = value📈 view plot
⚠️ NO THRESHOLD		21,135.40
Dromaeo/dom-attr/element_property📈 view plot
⚠️ NO THRESHOLD		22,240.40
Dromaeo/dom-attr/element_property = value📈 view plot
⚠️ NO THRESHOLD		89.79
Dromaeo/dom-attr/getAttribute📈 view plot
⚠️ NO THRESHOLD		43,157.40
Dromaeo/dom-attr/setAttribute📈 view plot
⚠️ NO THRESHOLD		80.14
Dromaeo/dom-modify📈 view plot
⚠️ NO THRESHOLD		63.76
Dromaeo/dom-modify/appendChild📈 view plot
⚠️ NO THRESHOLD		40.18
Dromaeo/dom-modify/cloneNode📈 view plot
⚠️ NO THRESHOLD		29.54
Dromaeo/dom-modify/createElement📈 view plot
⚠️ NO THRESHOLD		412.82
Dromaeo/dom-modify/createTextNode📈 view plot
⚠️ NO THRESHOLD		126.31
Dromaeo/dom-modify/innerHTML📈 view plot
⚠️ NO THRESHOLD		10.84
Dromaeo/dom-modify/insertBefore📈 view plot
⚠️ NO THRESHOLD		100.08
Dromaeo/dom-query📈 view plot
⚠️ NO THRESHOLD		1,124.81
Dromaeo/dom-query/getElementById📈 view plot
⚠️ NO THRESHOLD		434.65
Dromaeo/dom-query/getElementById (not in document)📈 view plot
⚠️ NO THRESHOLD		632.87
Dromaeo/dom-query/getElementsByName📈 view plot
⚠️ NO THRESHOLD		0.13
Dromaeo/dom-query/getElementsByName (not in document)📈 view plot
⚠️ NO THRESHOLD		0.21
Dromaeo/dom-query/getElementsByTagName (not in document)📈 view plot
⚠️ NO THRESHOLD		63,812.40
Dromaeo/dom-query/getElementsByTagName(*)📈 view plot
⚠️ NO THRESHOLD		50,421.80
Dromaeo/dom-query/getElementsByTagName(a)📈 view plot
⚠️ NO THRESHOLD		49,334.20
Dromaeo/dom-query/getElementsByTagName(div)📈 view plot
⚠️ NO THRESHOLD		48,968.40
Dromaeo/dom-query/getElementsByTagName(p)📈 view plot
⚠️ NO THRESHOLD		49,299.20
Dromaeo/dom-traverse📈 view plot
⚠️ NO THRESHOLD		250.33
Dromaeo/dom-traverse/childNodes📈 view plot
⚠️ NO THRESHOLD		187.95
Dromaeo/dom-traverse/firstChild📈 view plot
⚠️ NO THRESHOLD		261.50
Dromaeo/dom-traverse/lastChild📈 view plot
⚠️ NO THRESHOLD		118.65
Dromaeo/dom-traverse/nextSibling📈 view plot
⚠️ NO THRESHOLD		411.03
Dromaeo/dom-traverse/previousSibling📈 view plot
⚠️ NO THRESHOLD		410.15
Speedometer/Charts-observable-plot📈 view plot
⚠️ NO THRESHOLD		131.88
Speedometer/Charts-observable-plot/Dotted📈 view plot
⚠️ NO THRESHOLD		27.00
Speedometer/Charts-observable-plot/Dotted/Async📈 view plot
⚠️ NO THRESHOLD		1.42
Speedometer/Charts-observable-plot/Dotted/Sync📈 view plot
⚠️ NO THRESHOLD		25.57
Speedometer/Charts-observable-plot/Stacked by 20📈 view plot
⚠️ NO THRESHOLD		52.51
Speedometer/Charts-observable-plot/Stacked by 20/Async📈 view plot
⚠️ NO THRESHOLD		2.03
Speedometer/Charts-observable-plot/Stacked by 20/Sync📈 view plot
⚠️ NO THRESHOLD		50.48
Speedometer/Charts-observable-plot/Stacked by 6📈 view plot
⚠️ NO THRESHOLD		52.37
Speedometer/Charts-observable-plot/Stacked by 6/Async📈 view plot
⚠️ NO THRESHOLD		1.45
Speedometer/Charts-observable-plot/Stacked by 6/Sync📈 view plot
⚠️ NO THRESHOLD		50.92
Speedometer/Geomean📈 view plot
⚠️ NO THRESHOLD		174.14
Speedometer/Iteration-0-Total📈 view plot
⚠️ NO THRESHOLD		299.93
Speedometer/Iteration-1-Total📈 view plot
⚠️ NO THRESHOLD		273.91
Speedometer/Iteration-2-Total📈 view plot
⚠️ NO THRESHOLD		285.41
Speedometer/Iteration-3-Total📈 view plot
⚠️ NO THRESHOLD		302.98
Speedometer/Iteration-4-Total📈 view plot
⚠️ NO THRESHOLD		275.82
Speedometer/Iteration-5-Total📈 view plot
⚠️ NO THRESHOLD		279.09
Speedometer/Iteration-6-Total📈 view plot
⚠️ NO THRESHOLD		273.03
Speedometer/Iteration-7-Total📈 view plot
⚠️ NO THRESHOLD		272.44
Speedometer/Iteration-8-Total📈 view plot
⚠️ NO THRESHOLD		280.69
Speedometer/Iteration-9-Total📈 view plot
⚠️ NO THRESHOLD		282.17
Speedometer/Score📈 view plot
⚠️ NO THRESHOLD		5.76
Speedometer/TodoMVC-Angular📈 view plot
⚠️ NO THRESHOLD		156.77
Speedometer/TodoMVC-Angular/Adding100Items📈 view plot
⚠️ NO THRESHOLD		87.69
Speedometer/TodoMVC-Angular/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		9.30
Speedometer/TodoMVC-Angular/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		78.38
Speedometer/TodoMVC-Angular/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		38.45
Speedometer/TodoMVC-Angular/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		8.58
Speedometer/TodoMVC-Angular/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		29.87
Speedometer/TodoMVC-Angular/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		30.63
Speedometer/TodoMVC-Angular/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		1.72
Speedometer/TodoMVC-Angular/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		28.91
Speedometer/TodoMVC-JavaScript-ES5📈 view plot
⚠️ NO THRESHOLD		614.83
Speedometer/TodoMVC-JavaScript-ES5/Adding100Items📈 view plot
⚠️ NO THRESHOLD		470.11
Speedometer/TodoMVC-JavaScript-ES5/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		16.79
Speedometer/TodoMVC-JavaScript-ES5/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		453.32
Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		90.29
Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		17.53
Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		72.76
Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		54.44
Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		2.03
Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		52.41
Speedometer/TodoMVC-JavaScript-ES6-Webpack📈 view plot
⚠️ NO THRESHOLD		934.73
Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items📈 view plot
⚠️ NO THRESHOLD		736.43
Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		9.50
Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		726.93
Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		122.56
Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		8.84
Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		113.72
Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		75.73
Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		2.01
Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		73.73
Speedometer/TodoMVC-Preact📈 view plot
⚠️ NO THRESHOLD		54.99
Speedometer/TodoMVC-Preact/Adding100Items📈 view plot
⚠️ NO THRESHOLD		28.58
Speedometer/TodoMVC-Preact/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		24.55
Speedometer/TodoMVC-Preact/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		4.03
Speedometer/TodoMVC-Preact/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		19.45
Speedometer/TodoMVC-Preact/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		13.07
Speedometer/TodoMVC-Preact/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		6.38
Speedometer/TodoMVC-Preact/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		6.96
Speedometer/TodoMVC-Preact/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		4.07
Speedometer/TodoMVC-Preact/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		2.89
Speedometer/TodoMVC-React📈 view plot
⚠️ NO THRESHOLD		147.91
Speedometer/TodoMVC-React-Redux📈 view plot
⚠️ NO THRESHOLD		165.87
Speedometer/TodoMVC-React-Redux/Adding100Items📈 view plot
⚠️ NO THRESHOLD		69.99
Speedometer/TodoMVC-React-Redux/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		8.47
Speedometer/TodoMVC-React-Redux/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		61.51
Speedometer/TodoMVC-React-Redux/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		59.52
Speedometer/TodoMVC-React-Redux/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		8.08
Speedometer/TodoMVC-React-Redux/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		51.44
Speedometer/TodoMVC-React-Redux/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		36.36
Speedometer/TodoMVC-React-Redux/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		1.82
Speedometer/TodoMVC-React-Redux/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		34.54
Speedometer/TodoMVC-React/Adding100Items📈 view plot
⚠️ NO THRESHOLD		70.12
Speedometer/TodoMVC-React/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		11.13
Speedometer/TodoMVC-React/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		58.99
Speedometer/TodoMVC-React/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		47.22
Speedometer/TodoMVC-React/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		8.28
Speedometer/TodoMVC-React/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		38.94
Speedometer/TodoMVC-React/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		30.57
Speedometer/TodoMVC-React/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		2.12
Speedometer/TodoMVC-React/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		28.45
Speedometer/TodoMVC-Svelte📈 view plot
⚠️ NO THRESHOLD		53.40
Speedometer/TodoMVC-Svelte/Adding100Items📈 view plot
⚠️ NO THRESHOLD		24.92
Speedometer/TodoMVC-Svelte/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		19.49
Speedometer/TodoMVC-Svelte/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		5.42
Speedometer/TodoMVC-Svelte/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		18.97
Speedometer/TodoMVC-Svelte/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		13.21
Speedometer/TodoMVC-Svelte/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		5.75
Speedometer/TodoMVC-Svelte/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		9.52
Speedometer/TodoMVC-Svelte/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		6.07
Speedometer/TodoMVC-Svelte/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		3.45
linux-release📈 view plot
⚠️ NO THRESHOLD		171.34
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 11, 2025

Test results for linux-wpt-layout-2020 from try job (#13265742349):

Flaky unexpected result (22)
  • TIMEOUT [expected OK] /_mozilla/mozilla/window_requestAnimationFrame2.html
    • TIMEOUT [expected PASS] subtest: Test throwing an error inside requestAnimationFrame callback

      Test timed out

  • PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
  • OK /css/css-display/empty-text-baseline-001.html
    • FAIL [expected PASS] subtest: Empty second line in #inner does not generate baseline for #span

      assert_equals: expected 2 but got 0

    • FAIL [expected PASS] subtest: Empty second line in #inner does not generate baseline for #span with white-space: pre-line

      assert_equals: expected 2 but got 0

    • FAIL [expected PASS] subtest: Empty second line in #inner does not generate baseline for #span with white-space: pre

      assert_equals: expected 2 but got 0

  • FAIL [expected PASS] /css/css-fonts/font-colorization.html
  • FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
  • OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
    • PASS [expected FAIL] subtest: Newline normalization - \r\n in value (urlencoded)
  • OK /encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-hangul.html?1-1000
    • FAIL [expected PASS] subtest: hangul U+AD90 궐 %26%2344432%3B

      assert_equals: expected "%26%2344432%3B" but got ""

    • FAIL [expected PASS] subtest: hangul U+AD91 궑 %26%2344433%3B

      assert_equals: expected (string) "%26%2344433%3B" but got (undefined) undefined

    • FAIL [expected PASS] subtest: hangul U+AD92 궒 %26%2344434%3B

      assert_equals: expected (string) "%26%2344434%3B" but got (undefined) undefined

    • FAIL [expected PASS] subtest: hangul U+AD93 궓 %26%2344435%3B

      assert_equals: expected (string) "%26%2344435%3B" but got (undefined) undefined

    • FAIL [expected PASS] subtest: hangul U+AD94 궔 %26%2344436%3B

      assert_equals: expected (string) "%26%2344436%3B" but got (undefined) undefined

    • FAIL [expected PASS] subtest: hangul U+AD95 궕 %26%2344437%3B

      assert_equals: expected (string) "%26%2344437%3B" but got (undefined) undefined

    • FAIL [expected PASS] subtest: hangul U+AD96 궖 %26%2344438%3B

      assert_equals: expected (string) "%26%2344438%3B" but got (undefined) undefined

    • FAIL [expected PASS] subtest: hangul U+AD97 궗 %26%2344439%3B

      assert_equals: expected (string) "%26%2344439%3B" but got (undefined) undefined

    • FAIL [expected PASS] subtest: hangul U+AD98 궘 %26%2344440%3B

      assert_equals: expected (string) "%26%2344440%3B" but got (undefined) undefined

    • FAIL [expected PASS] subtest: hangul U+AD99 궙 %26%2344441%3B

      assert_equals: expected (string) "%26%2344441%3B" but got (undefined) undefined

    • And 390 more unexpected results...
  • OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
  • OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
    • PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation
  • TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/anchor-fragment-form-submit.html
  • OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
    • FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked

      assert_equals: expected "A" but got ""

    • FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked

      assert_equals: expected "�ÿ" but got ""

    • FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked

      assert_equals: expected "�ÿĀ" but got ""

    • FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked

      assert_equals: expected "😍" but got ""

    • FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked

      assert_equals: expected "\ufffdA" but got ""

  • OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
    • FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

      assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

  • OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • TIMEOUT [expected OK] /html/browsers/history/the-location-interface/assign-with-nested-iframe.html
  • PASS [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
  • CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.html (#34117)
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
    • PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
  • OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
    • PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
  • OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
    • PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in filename (normal form)
    • PASS [expected FAIL] subtest: application/x-www-form-urlencoded: single quote in name (formdata event)
  • TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
    • TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent

      Test timed out

    • NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
Stable unexpected results that are known to be intermittent (21)
  • TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
    • TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.

      Test timed out

  • FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
  • OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
    • PASS [expected FAIL] subtest: sec-fetch-user
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site
  • OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
    • FAIL [expected PASS] subtest: Link with onclick form submit to javascript url with document.write and href navigation 

      assert_array_equals: expected property 1 to be "href" but got "click" (expected array ["write", "href"] got ["write", "click"])

  • OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
    • FAIL [expected PASS] subtest: Check execution order from nested timeout

      assert_equals: Expected nested setTimeout to run second expected true but got false

    • FAIL [expected PASS] subtest: Check execution order on load handler

      assert_equals: Expected onload to run first expected false but got true

  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
    • PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
  • OK /html/browsers/browsing-the-web/overlapping-navigations-and-traversals/cross-document-nav-cross-document-nav.html (#29181)
    • PASS [expected FAIL] subtest: cross-document navigation then cross-document navigation
  • OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])

  • OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])

  • OK /html/browsers/windows/browsing-context-names/duplicate-name-order.html (#34623)
    • FAIL [expected PASS] subtest: Duplicate name lookup order

      assert_equals: subtree first expected "ChildA" but got "PopupA"

  • ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-serializable.html (#34120)
  • ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-transfer.html (#34119)
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

      Test timed out

    • NOTRUN [expected FAIL] subtest: Area element should support autofocus
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
  • OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
    • PASS [expected FAIL] subtest: multipart/form-data: single quote in name (formdata event)
  • OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
    • PASS [expected FAIL] subtest: text/plain: Basic File test (formdata event)
    • PASS [expected FAIL] subtest: text/plain: double quote in name (normal form)
    • PASS [expected FAIL] subtest: text/plain: backslash in value (formdata event)
  • OK /navigation-timing/test-navigation-type-reload.html (#33334)
    • FAIL [expected PASS] subtest: Reload domComplete > Original domComplete

      assert_true: Reload domComplete > Original domComplete expected true got false

    • FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart

      assert_true: Reload domContentLoadedEventStart > Original domContentLoadedEventStart expected true got false

    • FAIL [expected PASS] subtest: Reload fetchStart > Original fetchStart

      assert_true: Reload fetchStart > Original fetchStart expected true got false

    • FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd

      assert_true: Reload loadEventEnd > Original loadEventEnd expected true got false

    • FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart

      assert_true: Reload loadEventStart > Original loadEventStart expected true got false

  • TIMEOUT [expected OK] /performance-timeline/navigation-id-detached-frame.tentative.html (#34773)
    • TIMEOUT [expected PASS] subtest: The navigation_id getter does not crash a window of detached frame

      Test timed out

  • OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 11, 2025

⚠️ Try run (#13265742349) failed.

@sagudev sagudev mentioned this pull request Feb 11, 2025
Closed
@mukilan
Copy link
Copy Markdown
Member

mukilan commented Feb 12, 2025

I tested this on Plasma+Wayland+Nvidia and it does fix #29463 !

I noticed two additional issues, but they are not due to this PR as they are also present in main, but noting them down here in case you think the glow version should not have these issues.

I see this when closing the Servo window, both in main & this branch.

Caught signal 11 in thread "smithay-clipboard"
Servo was terminated by signal 11

Also, forcing Servo to use GLES export SURFMAN_FORCE_GLES=1 makes webrender crash, both in main & this branch.

❯ SURFMAN_FORCE_GLES=1 ./mach run -r
NOTE: Entering nix-shell ./shell.nix
renderer::deinit not called (thread main, at /home/mukilan/.cargo/git/checkouts/webrender-c3596abe1cf4f320/8846253/webrender/src/device/gl.rs:566)
   0: servoshell::backtrace::print
   1: servoshell::panic_hook::panic_hook
   2: std::panicking::rust_panic_with_hook
   3: std::panicking::begin_panic::{{closure}}
   4: std::sys::backtrace::__rust_end_short_backtrace
   5: std::panicking::begin_panic
   6: core::ptr::drop_in_place<core::option::Option<webrender::device::gl::Program>>
   7: webrender::renderer::shade::LazilyCompiledShader::new
   8: webrender::renderer::shade::BrushShader::new
   9: webrender::renderer::shade::Shaders::new
  10: webrender::renderer::init::create_webrender_instance
  11: servo::Servo::new
  12: servoshell::desktop::app::App::init
  13: winit::platform_impl::linux::wayland::event_loop::EventLoop<T>::pump_events
  14: winit::platform_impl::linux::wayland::event_loop::EventLoop<T>::run_on_demand
  15: servoshell::desktop::events_loop::EventsLoop::run_app
  16: servoshell::main
  17: std::sys::backtrace::__rust_begin_short_backtrace
  18: std::rt::lang_start::{{closure}}
  19: std::rt::lang_start_internal
  20: main
  21: __libc_start_call_main
  22: __libc_start_main_alias_2
  23: _start
Caught signal 11 in thread "smithay-clipboard"
   0: servoshell::backtrace::print
   1: servoshell::crash_handler::install::handler
   2: <unknown>
   3: wl_map_insert_at
   4: proxy_destroy
   5: wl_proxy_destroy
   6: wayland_backend::sys::client_impl::InnerBackend::send_request
   7: wayland_backend::sys::client::Backend::send_request
   8: wayland_protocols::wp::primary_selection::zv1::generated::client::zwp_primary_selection_device_manager_v1::ZwpPrimarySelectionDeviceManagerV1::destroy
   9: core::ptr::drop_in_place<smithay_clipboard::state::State>
  10: smithay_clipboard::worker::worker_impl
  11: std::sys::backtrace::__rust_begin_short_backtrace
  12: core::ops::function::FnOnce::call_once{{vtable.shim}}
  13: std::sys::pal::unix::thread::Thread::new::thread_start
  14: start_thread
  15: __GI___clone3
Servo was terminated by signal 11

@sagudev
Copy link
Copy Markdown
Member Author

sagudev commented Feb 12, 2025

Yeah first one is totally unrelated that I was getting it to. The second one might be from WR upgrade or various changes in servo rendering/embededing, so both are unrelated to this PR. Can you try to bisect second issue?

@mukilan
Copy link
Copy Markdown
Member

mukilan commented Feb 12, 2025

git bisect says it is 2d09552 and

SURFMAN_FORCE_GLES=1 ./mach run -r --pref gfx_precache_shaders=false

does make servo run without crashing, so I guess we need to disable it by default until we can figure out why the precache shader compilation is failing.

@mrobinson
Copy link
Copy Markdown
Member

mrobinson commented Feb 12, 2025

git bisect says it is 2d09552 and

Thanks for finding this. I've opened #35431 to correct it.

@kkoyung
Copy link
Copy Markdown
Member

kkoyung commented Feb 13, 2025

I tested on my Sway+Nvidia, and it successfully shows the window. However, I got another problem, which I'm not sure whether it is related.

When the servo starts, the content in the window is squeezed.
screenshot_2025-02-13_12:44:36

After resizing the window, it goes back to normal.
screenshot_2025-02-13_12:44:45

OS: Arch Linux
Nvidia driver version: 570.86.16
Sway version: sway version 1.10-dev-4852087e (Feb 13 2025, branch 'master')

@sagudev
Copy link
Copy Markdown
Member Author

sagudev commented Feb 13, 2025

I tested on my Sway+Nvidia, and it successfully shows the window. However, I got another problem, which I'm not sure whether it is related.

When the servo starts, the content in the window is squeezed. screenshot_2025-02-13_12:44:36

After resizing the window, it goes back to normal. screenshot_2025-02-13_12:44:45

OS: Arch Linux Nvidia driver version: 570.86.16 Sway version: sway version 1.10-dev-4852087e (Feb 13 2025, branch 'master')

Is this also happening on main?

@kkoyung
Copy link
Copy Markdown
Member

kkoyung commented Feb 13, 2025 •
edited
Loading

Is this also happening on main?

Yes. It also happens on main, with SURFMAN_FORCE_GLES=1. (On main, launching without SURFMAN_FORCE_GLES=1 gives empty window.)

@sagudev
Copy link
Copy Markdown
Member Author

sagudev commented Feb 13, 2025

Is this also happening on main?

Yes. It also happens on main

Can you open new issue about it? Also write if you use any scaling (hidpi).

@sagudev
update surfman
f12df18 
Signed-off-by: sagudev <[email protected]>
@sagudev sagudev marked this pull request as ready for review February 13, 2025 05:11
@kkoyung
Copy link
Copy Markdown
Member

kkoyung commented Feb 13, 2025

Is this also happening on main?

Yes. It also happens on main

Can you open new issue about it? Also write if you use any scaling (hidpi).

Sure, I'll open a new issue.

@sagudev sagudev requested a review from jdm February 13, 2025 07:00
@sagudev sagudev added this pull request to the merge queue Feb 13, 2025
Merged via the queue into servo:main with commit 610a1c2 Feb 13, 2025
23 checks passed
@sagudev sagudev deleted the reglowing-surfman branch February 13, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

First launch servo but with black screen Empty window on Wayland with Nvidia GPU

5 participants

@sagudev @mukilan @mrobinson @kkoyung @jdm