Revert "Use surfman with glow bindings (#34328)"#35402
Merged
sagudev merged 1 commit intoservo:mainfrom Feb 10, 2025
Merged
Conversation
This reverts commit 503bb10. Signed-off-by: sagudev <[email protected]>
sagudev
force-pushed
the
revert-glowing-surfman
branch
from
c619f1f to
1f29fe9
Compare
mrobinson
approved these changes
Feb 10, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Sorry to see this happened, but thanks for following up.
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Feb 11, 2025
This reverts commit 0fed995.
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Feb 11, 2025
This reverts commit 0fed995. Signed-off-by: sagudev <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
* Reapply "Use surfman with glow bindings (#34328)" (#35402) This reverts commit 0fed995. Signed-off-by: sagudev <[email protected]> * update surfman Signed-off-by: sagudev <[email protected]> --------- Signed-off-by: sagudev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 503bb10.
Fixing #35326 will be hard, so let's revert "glowing surfman" change for now.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors