Move code generation and webidl files to new script_bindings crate#35157
Merged
jdm merged 1 commit intoservo:mainfrom Jan 24, 2025
Merged
Move code generation and webidl files to new script_bindings crate#35157jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
jdm
force-pushed
the
bindings-crate
branch
2 times, most recently
from
f25a232 to
9a01901
Compare
Member
|
We will need to change tidy to start looking at new dir for webidl files... |
sagudev
reviewed
Jan 24, 2025
Member
There was a problem hiding this comment.
In later steps we will be able to remove this altogether.
…crate. Signed-off-by: Josh Matthews <[email protected]>
Member
Author
Fixed. |
sagudev
approved these changes
Jan 24, 2025
15 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2026
…_bindings` `build.rs` (#41649) Just fixed a discrepancy in comments I noticed, the files were moved around in #35157 Signed-off-by: Leo Ring <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is focused on moving files into their eventual destinations while making as few changes to them as possible. While the bindings code is now generated while building a new
script_bindingscrate, all of the generated bindings are still included in the build of thescriptcrate. This enables us to incrementally push some parts of the build from script to script_bindings in the future while minimizing the overall diff when that happens../mach build -ddoes not report any errors./mach test-tidydoes not report any errors