layout: Remove the obsolete layout tracing functionality#35001
Merged
mrobinson merged 1 commit intoservo:mainfrom Jan 15, 2025
Merged
layout: Remove the obsolete layout tracing functionality#35001mrobinson merged 1 commit intoservo:mainfrom
mrobinson merged 1 commit intoservo:mainfrom
Conversation
There were two kinds of layout tracing controlled by the same debugging option: - modern layout: Functionality that dumped a JSON serialization of the layout tree before and after layout. - legacy layout: A scope based tracing that reported the process of layout in a structured way. I don't think anyone working on layout is using either of these two features. For modern layout requiring data structure to implement `serde` serialization is incredibly inconvenient and also generates a lot of extra code. We also have a more modern tracing functionality based on perfetto that we have started to use for layout and IMO it's actually being used and more robust. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
remove-trace-layout
branch
from
1aa1ce4 to
ae36a7f
Compare
Loirooriol
approved these changes
Jan 15, 2025
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Dec 10, 2025
These structs used to be different when they were added in servo#29699: `BaseFragment` had a `debug_id` field, while `BaseFragmentInfo` didn't. But this field was later removed in servo#35001, so the structs became identical. Therefore, this just unified them. I'm picking `BaseFragmentInfo` as the name, since it was the most frequently used of the two. Signed-off-by: Oriol Brufau <[email protected]>
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Dec 10, 2025
These structs used to be different when they were added in servo#29699: `BaseFragment` had a `debug_id` field, while `BaseFragmentInfo` didn't. But this field was later removed in servo#35001, so the structs became identical. Therefore, this just unified them. I'm picking `BaseFragmentInfo` as the name, since it was the most frequently used of the two. Signed-off-by: Oriol Brufau <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
These structs used to be different when they were added in #29699: `BaseFragment` had a `debug_id` field, while `BaseFragmentInfo` didn't. But this field was later removed in #35001, so the structs became identical. Therefore, this patch just unifies them. I'm picking `BaseFragmentInfo` as the name, since it was the most frequently used of the two. Testing: Not needed, no change in behavior Signed-off-by: Oriol Brufau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two kinds of layout tracing controlled by the same debugging
option:
layout tree before and after layout.
layout in a structured way.
I don't think anyone working on layout is using either of these two
features. For modern layout requiring data structure to implement
serdeserialization is incredibly inconvenient and also generates alot of extra code.
We also have a more modern tracing functionality based on perfetto that
we have started to use for layout and IMO it's actually being used and
more robust.
Signed-off-by: Martin Robinson [email protected]
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors