Skip to content

prefs: Move some DebugOptions to Preferences and clean up#34998

Merged
mrobinson merged 1 commit intoservo:mainfrom
mrobinson:pref-cleanup-1
Jan 17, 2025
Merged

prefs: Move some DebugOptions to Preferences and clean up#34998
mrobinson merged 1 commit intoservo:mainfrom
mrobinson:pref-cleanup-1

Conversation

@mrobinson
Copy link
Copy Markdown
Member

@mrobinson mrobinson commented Jan 15, 2025 •
edited
Loading

  • Move options configuring antialiasing and WebRender shader precache to
    the Preferences to group them with other related WebRender and DOM
    settings.
  • Remove the option to disable antialiasing for canvases. This was
    unused.

Signed-off-by: Martin Robinson [email protected]

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are covered by existing tests. They just adjust how some settings are set.

@mrobinson mrobinson requested a review from gterzian as a code owner January 15, 2025 09:32
@mrobinson mrobinson added the T-linux-wpt Do a try run of the WPT label Jan 15, 2025
@github-actions github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2025

🔨 Triggering try run (#12785452397) for Linux WPT

@servo-wpt-sync servo-wpt-sync mentioned this pull request Jan 15, 2025
Merged
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Jan 15, 2025

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#50093) with upstreamable changes.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2025

Test results for linux-wpt-layout-2020 from try job (#12785452397):

Flaky unexpected result (16)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
  • TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
    • TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up

      Test timed out

  • OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
    • PASS [expected FAIL] subtest: sec-fetch-user
  • OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
    • FAIL [expected PASS] subtest: Check execution order from nested timeout

      assert_equals: Expected nested setTimeout to run second expected true but got false

    • FAIL [expected PASS] subtest: Check execution order on load handler

      assert_equals: Expected onload to run first expected false but got true

  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored

      assert_equals: expected "?pass" but got "?fail"

  • FAIL [expected PASS] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus

      Test timed out

    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
    • NOTRUN [expected FAIL] subtest: Area element should support autofocus
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
  • TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
  • OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
    • PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (normal form)
    • PASS [expected FAIL] subtest: multipart/form-data: backslash in value (normal form)
  • OK /navigation-timing/test-navigation-type-reload.html (#33334)
    • PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
    • PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
    • PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
    • PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
    • PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
    • PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
    • PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
  • OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
  • OK /xhr/open-url-multi-window-5.htm (#23360)
    • FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)

      assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw

Stable unexpected results that are known to be intermittent (9)
  • FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
    • PASS [expected FAIL] subtest: form submission
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
    • PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
  • OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK /html/semantics/forms/historical.html (#28568)
    • FAIL [expected PASS] subtest: <input name=isindex> should not be supported

      assert_regexp_match: expected object "/\?isindex=x$/" but got "about:blank"

  • OK /resize-observer/eventloop.html (#33599)
    • FAIL [expected PASS] subtest: test0: multiple notifications inside same event loop

      assert_equals: new loop expected 1 but got 0

  • OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
    • PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
Stable unexpected results (8)
  • CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/context-creation-worker.html
  • CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/context-creation.html
  • CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/methods-2-worker.html
  • CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/methods-2.html
  • CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/offscreencanvas-query.html
  • CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/offscreencanvas-sync.html
  • CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/offscreencanvas-timer-query.html
  • CRASH [expected ERROR] /_webgl/conformance2/offscreencanvas/offscreencanvas-transfer-image-bitmap.html

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2025

⚠️ Try run (#12785452397) failed.

@mrobinson mrobinson force-pushed the pref-cleanup-1 branch 2 times, most recently from 1b04157 to 83256a1 Compare January 15, 2025 10:27
@mrobinson mrobinson added the T-linux-wpt Do a try run of the WPT label Jan 15, 2025
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Jan 15, 2025

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#50093).

@github-actions github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2025

🔨 Triggering try run (#12786357539) for Linux WPT

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Jan 15, 2025

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#50093).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2025

Test results for linux-wpt-layout-2020 from try job (#12786357539):

Flaky unexpected result (16)
  • OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
    • FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed

      promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"

  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /fetch/content-length/api-and-duplicate-headers.any.worker.html
    • FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers

      promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"

  • OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
    • PASS [expected FAIL] subtest: sec-fetch-user
  • OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
    • FAIL [expected PASS] subtest: Check execution order from nested timeout

      assert_equals: Expected nested setTimeout to run second expected true but got false

    • FAIL [expected PASS] subtest: Check execution order on load handler

      assert_equals: Expected onload to run first expected false but got true

  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • PASS [expected FAIL] subtest: Navigating to a different document with link click
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
    • FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

      assert_equals: expected "" but got "#fragment"

  • PASS [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
  • TIMEOUT [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-serializable.html (#34120)
  • OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/playing-the-media-resource/loop-from-ended.tentative.html (#33778)
    • FAIL [expected TIMEOUT] subtest: play() with loop set to true after playback ended

      this argument is not a finite floating-point value

  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
  • OK /html/semantics/embedded-content/the-img-element/relevant-mutations.html (#34216)
    • FAIL [expected PASS] subtest: class on img set

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: alt on img set

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: src on previous sibling source set

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: class on previous sibling source set

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: inserted/removed children of img

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: picture is removed; img has src

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: picture is removed; img has srcset

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: picture is removed; img has previous sibling source

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: picture is removed; img has following sibling source

      assert_unreached: update the image data was run Reached unreachable code

    • FAIL [expected PASS] subtest: parent is picture, following img inserted

      assert_unreached: update the image data was run Reached unreachable code

    • And 4 more unexpected results...
  • OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
    • PASS [expected FAIL] subtest: multipart/form-data: Basic test (formdata event)
    • PASS [expected FAIL] subtest: multipart/form-data: 0x00 in name (formdata event)
    • PASS [expected FAIL] subtest: multipart/form-data: \n in value (normal form)
  • OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
    • PASS [expected FAIL] subtest: text/plain: Basic test (normal form)
    • PASS [expected FAIL] subtest: text/plain: 0x00 in name (formdata event)
  • OK /navigation-timing/test-navigation-type-reload.html (#33334)
    • PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
    • PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
    • PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
  • TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
    • TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent

      Test timed out

    • NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
Stable unexpected results that are known to be intermittent (12)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
    • PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored

      assert_equals: expected "?pass" but got "?fail"

  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • FAIL [expected PASS] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
  • OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
  • OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
    • PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
  • OK /html/semantics/forms/historical.html (#28568)
    • FAIL [expected PASS] subtest: <input name=isindex> should not be supported

      assert_regexp_match: expected object "/\?isindex=x$/" but got "about:blank"

  • OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
    • PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2025

✨ Try run (#12786357539) succeeded.

jdm
jdm reviewed Jan 15, 2025
View reviewed changes
Comment thread components/script/dom/webidls/OffscreenCanvas.webidl Outdated
//enum OffscreenRenderingContextId { "2d", "webgl", "webgl2" };

[Exposed=(Window,Worker)/*, Transferable*/, Pref="dom_offscreen_canvas_enabled"]
[Exposed=(Window,Worker)/*, Transferable*/, Pref="dom_canvas_offscreen_enabled"]
Copy link
Copy Markdown
Member

@jdm jdm Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not thrilled by this rename, since the current pref contain the actual interface name that is enabled, which follows the model of our other dom preferences.

Copy link
Copy Markdown
Member Author

@mrobinson mrobinson Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to undo this particular rename.

@mrobinson
prefs: Move some DebugOptions to Preferences and clean up
122f83a 
- Move options configuring antialiasing and WebRender shader precache to
  the `Preferences` to group them with other related WebRender and DOM
  settings.
- Remove the option to disable antialiasing for canvases. This was
  unused.

Signed-off-by: Martin Robinson <[email protected]>
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Jan 15, 2025

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#50093) title and body.

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Jan 15, 2025

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#50093).

@mrobinson
Copy link
Copy Markdown
Member Author

mrobinson commented Jan 15, 2025 •
edited
Loading

I've gone ahead and restored the name of dom_offscreen_canvas_enabled, but have also completely removed the canvas antialiasing option. On further inspection, it was completely unused.

@mrobinson mrobinson requested a review from mukilan January 16, 2025 10:52
@mrobinson mrobinson added this pull request to the merge queue Jan 17, 2025
Merged via the queue into servo:main with commit 2d09552 Jan 17, 2025
@mrobinson mrobinson deleted the pref-cleanup-1 branch January 17, 2025 12:17
chickenleaf pushed a commit to chickenleaf/servo that referenced this pull request Jan 24, 2025
@mrobinson @chickenleaf
prefs: Move some DebugOptions to Preferences and clean up (servo#…
33dc186 
…34998)

- Move options configuring antialiasing and WebRender shader precache to
  the `Preferences` to group them with other related WebRender and DOM
  settings.
- Remove the option to disable antialiasing for canvases. This was
  unused.

Signed-off-by: Martin Robinson <[email protected]>
Signed-off-by: L Ashwin B <[email protected]>
mrobinson added a commit to mrobinson/servo that referenced this pull request Feb 12, 2025
@mrobinson
prefs: Stop precaching WebRender shaders by default
4d69d21 
In servo#34998, I inadvertantly enabled shader precaching by default during a
cleanup. This change reverts that particular mistake.

Signed-off-by: Martin Robinson <[email protected]>
@mrobinson mrobinson mentioned this pull request Feb 12, 2025
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this pull request Feb 12, 2025
@mrobinson
prefs: Stop precaching WebRender shaders by default (#35431)
ed597d8 
In #34998, I inadvertantly enabled shader precaching by default during a
cleanup. This change reverts that particular mistake.

Signed-off-by: Martin Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm left review comments

@mukilan mukilan mukilan approved these changes

@gterzian gterzian Awaiting requested review from gterzian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrobinson @servo-wpt-sync @jdm @mukilan