Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdriver: Serialize JS int values as i32. #34997

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

jdm
Copy link
Member

@jdm jdm commented Jan 15, 2025

This fixes errors like error: Action action_sequence failed: invalid argument (400): data did not match any variant of untagged enum NullActionItem at line 1 column 90 in testdriver.js tests that use action sequences.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they are only testable in a testharness that does not yet run in CI.

@jdm jdm requested a review from gterzian as a code owner January 15, 2025 07:27
@jdm jdm added this pull request to the merge queue Jan 15, 2025
Merged via the queue into servo:main with commit 5140ce8 Jan 15, 2025
22 checks passed
@jdm jdm deleted the webdriver-i32 branch January 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants