Enable more test directories and preferences by jdm · Pull Request #34952 · servo/servo

jdm · 2025-01-11T15:09:46Z

This sets us up for work that's happening in #34794 and working on interfaces that currently have stub implementations.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

Signed-off-by: Josh Matthews <[email protected]>

jdm · 2025-01-11T22:59:43Z

The existence of the AbortController stub introduces new timeouts into our test results; previously a bunch of tests that use the RemoteContext helper would fail quickly because the interface didn't exist. Now they time out because they are able to initialize correctly but (presumably) no abort signal occurs.

Signed-off-by: Josh Matthews <[email protected]>

github-actions · 2025-01-17T01:51:45Z

🔨 Triggering try run (#12821108303) for Linux WPT

github-actions · 2025-01-17T02:16:18Z

Test results for linux-wpt-layout-2020 from try job (#12821108303):

Flaky unexpected result (13)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
TIMEOUT [expected OK] /_mozilla/mozilla/cache_crossorigin_response.sub.html
- TIMEOUT [expected PASS] subtest: Cached cross-origin response doesn't hang
```
Test timed out
```
FAIL [expected PASS] /css/css-tables/table-cell-overflow-auto-scrolled.html (#35011)
ERROR [expected OK] /domparsing/DOMParser-parseFromString-url-base-pushstate.html (#27202)
OK /encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-csshiftjis.html?1-1000
- FAIL [expected PASS] subtest: U+30AD キ %83%4C
```
assert_equals: expected "%83%4C" but got ""
```
- FAIL [expected PASS] subtest: U+30AE ギ %83%4D
```
str is undefined
```
- FAIL [expected PASS] subtest: U+30AF ク %83%4E
```
str is undefined
```
- FAIL [expected PASS] subtest: U+30B0 グ %83%4F
```
str is undefined
```
- FAIL [expected PASS] subtest: U+30B1 ケ %83%50
```
str is undefined
```
- FAIL [expected PASS] subtest: U+30B2 ゲ %83%51
```
str is undefined
```
- FAIL [expected PASS] subtest: U+30B3 コ %83%52
```
str is undefined
```
- FAIL [expected PASS] subtest: U+30B4 ゴ %83%53
```
str is undefined
```
- FAIL [expected PASS] subtest: U+30B5 サ %83%54
```
str is undefined
```
- FAIL [expected PASS] subtest: U+30B6 ザ %83%55
```
str is undefined
```
- And 390 more unexpected results...
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- PASS [expected FAIL] subtest: form submission
TIMEOUT [expected OK] /html/browsers/browsing-the-web/overlapping-navigations-and-traversals/cross-document-nav-cross-document-nav.html (#29181)
- TIMEOUT [expected FAIL] subtest: cross-document navigation then cross-document navigation
```
Test timed out
```
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
PASS [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.worker.html (#30164)
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
OK /xhr/open-url-multi-window-5.htm (#23360)
- FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)
```
assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw
```

Stable unexpected results that are known to be intermittent (20)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- FAIL [expected PASS] subtest: Navigating to a different document with link click
```
assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"
```
- PASS [expected FAIL] subtest: Navigating to a different document with form submission
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)
- PASS [expected FAIL] subtest: Same-Document Referrer from Refresh
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
FAIL [expected PASS] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.html (#34117)
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)

OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)

FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)

FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: non-ASCII in filename (formdata event)
```
assert_equals: expected "a=É�.txt\r\n" but got ""
```

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
TIMEOUT [expected OK] /performance-timeline/navigation-id-detached-frame.tentative.html (#34773)
- TIMEOUT [expected PASS] subtest: The navigation_id getter does not crash a window of detached frame
```
Test timed out
```

github-actions · 2025-01-17T02:16:31Z

✨ Try run (#12821108303) succeeded.

* Enable WPT tests for several supported/in progress features. Signed-off-by: Josh Matthews <[email protected]> * Enable more preferences for all WPT tests. Signed-off-by: Josh Matthews <[email protected]> * Update test expectations. Signed-off-by: Josh Matthews <[email protected]> * Disable AbortController preference for tests. Signed-off-by: Josh Matthews <[email protected]> * Update WPT expectations. Signed-off-by: Josh Matthews <[email protected]> --------- Signed-off-by: Josh Matthews <[email protected]> Signed-off-by: L Ashwin B <[email protected]>

simonwuelker approved these changes Jan 11, 2025

View reviewed changes

jdm added 3 commits January 11, 2025 16:24

Enable WPT tests for several supported/in progress features.

79f1155

Signed-off-by: Josh Matthews <[email protected]>

Enable more preferences for all WPT tests.

03d04af

Signed-off-by: Josh Matthews <[email protected]>

Update test expectations.

b67c8a3

Signed-off-by: Josh Matthews <[email protected]>

jdm force-pushed the more-tests branch from 7744af7 to b67c8a3 Compare January 11, 2025 21:24

jdm enabled auto-merge January 11, 2025 21:24

jdm added this pull request to the merge queue Jan 11, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 11, 2025

Merge branch 'main' into more-tests

aad582e

Signed-off-by: Josh Matthews <[email protected]>

jdm enabled auto-merge January 16, 2025 23:43

jdm added this pull request to the merge queue Jan 17, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025

jdm added 2 commits January 16, 2025 20:08

Disable AbortController preference for tests.

b9dc34d

Signed-off-by: Josh Matthews <[email protected]>

Update WPT expectations.

2be1f7b

Signed-off-by: Josh Matthews <[email protected]>

jdm added the T-linux-wpt Do a try run of the WPT label Jan 17, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 17, 2025

jdm added this pull request to the merge queue Jan 17, 2025

Merged via the queue into servo:main with commit 5295a45 Jan 17, 2025

jdm deleted the more-tests branch January 17, 2025 03:08

jdm mentioned this pull request Jan 17, 2025

Add support for Upgrade request to a potentially trustworthy URL. #34986

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable more test directories and preferences#34952

Enable more test directories and preferences#34952
jdm merged 6 commits intoservo:mainfrom
jdm:more-tests

jdm commented Jan 11, 2025

Uh oh!

Uh oh!

jdm commented Jan 11, 2025

Uh oh!

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jdm commented Jan 11, 2025

Uh oh!

Uh oh!

jdm commented Jan 11, 2025

Uh oh!

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants