Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wgpu and impl WGSLLanguageFeatures #34928

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Update wgpu and impl WGSLLanguageFeatures #34928

merged 2 commits into from
Jan 10, 2025

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Jan 10, 2025 •
edited
Loading

Update wgpu to gfx-rs/wgpu@dc9b2eb and implement WGSLLanguageFeatures, now that gfx-rs/wgpu#6814 landed.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes in WebGPU CTS

@sagudev sagudev added the A-content/webgpu The WebGPU implementation. label Jan 10, 2025
@sagudev sagudev requested a review from gterzian as a code owner January 10, 2025 11:03
@sagudev sagudev mentioned this pull request Jan 10, 2025
Merged
7 tasks
@sagudev sagudev force-pushed the WGSLLanguageFeatures branch from c49c9a0 to fde4116 Compare January 10, 2025 11:11
@sagudev sagudev force-pushed the WGSLLanguageFeatures branch from fde4116 to d3f9080 Compare January 10, 2025 11:52
@sagudev sagudev requested review from jdm and removed request for gterzian January 10, 2025 14:10
sagudev
sagudev commented Jan 10, 2025
View reviewed changes
components/script/dom/webgpu/wgsllanguagefeatures.rs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is based on https://github.com/servo/servo/blob/main/components/script/dom/webgpu/gpusupportedfeatures.rs

@jdm jdm added this pull request to the merge queue Jan 10, 2025
Merged via the queue into servo:main with commit 4e51c7b Jan 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

Assignees
No one assigned
Labels
A-content/webgpu The WebGPU implementation.
Projects
WebGPU
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagudev @jdm