layout: grid-template getComputedStyle cleanup by stevennovaryo · Pull Request #34926 · servo/servo

stevennovaryo · 2025-01-10T07:15:41Z

Changes

Update Taffy version to 0.7.4, which will fix the my bug of exposing the info of grid without any items.
Enhancing code qualities.
- layout: grid template getComputedStyle resolved value #34885 (comment)

WPT Result — Try Run

Most the pass tests is WPT tests that uses grid without any items. Leftover subtests from the same tests are mostly related to the upcoming features and more passes are expected soon.

WPT tests with track list that contains only auto(s) computed the sizes of the track incorrectly. #34925

This also includes tests that uses keyword none in grid with grid items (and undefined auto-placement) and the one with incorrect value, because all of them should resolved to auto.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes are the follow-up of layout: grid template getComputedStyle resolved value #34885
There are tests for these changes

Signed-off-by: stevennovaryo <[email protected]>

github-actions · 2025-01-10T07:48:28Z

🔨 Triggering try run (#12705404079) for Linux WPT

nicoburns

Looks good :) And thanks for creating the issue for the auto-tracks issue!

github-actions · 2025-01-10T08:30:06Z

Test results for linux-wpt-layout-2020 from try job (#12705404079):

Flaky unexpected result (19)

OK /_webgl/conformance/textures/misc/texture-video-transparent.html (#34127)
- FAIL [expected PASS] subtest: WebGL test #0: neither left is green nor right is blue at (4, 4) expected: 0,255,0 was 0,0,0 at (20, 4) expected: 0,0,255 was 0,0,0 0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255 0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255
```
assert_true: neither left is green nor right is blue 
at (4, 4) expected: 0,255,0 was 0,0,0
at (20, 4) expected: 0,0,255 was 0,0,0
0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255
0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255,0,0,0,255 expected true got false
```
OK /_webgl/conformance2/rendering/texture-switch-performance.html (#23384)
- FAIL [expected PASS] subtest: WebGL test #0: Texture switching significantly hurt performance - achieved 650 frames in 2.003 seconds (0.64 times baseline performance)
```
assert_true: Texture switching significantly hurt performance - achieved 650 frames in 2.003 seconds (0.64 times baseline performance) expected true got false
```
PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)

OK /css/css-grid/alignment/grid-content-alignment-with-abspos-001.html (#34339)

FAIL [expected PASS] subtest: .grid 1

assert_equals: 
&lt;div class="grid" data-expected-width="800" data-expected-height="600"&gt;
    &lt;div class="a" id="item" data-offset-x="329" data-offset-y="269" data-expected-width="142" data-expected-height="62" style="place-self: center;"&gt;&lt;/div&gt;
  &lt;/div&gt;
offsetLeft expected 329 but got 0

OK /fetch/content-length/api-and-duplicate-headers.any.html
- FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- PASS [expected FAIL] subtest: link click
- PASS [expected FAIL] subtest: form submission
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- TIMEOUT [expected FAIL] subtest: Navigating to a different document with form submission
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
promise_test: Unhandled rejection with value: object "TypeError: w.document.activeElement is null"
```
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-replace-set-src.html (#32697)
- PASS [expected FAIL] subtest: Navigating iframe loading='lazy' and then setting src: location.replace
OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- FAIL [expected PASS] subtest: Verifies that location navigations take precedence when following form submissions.
```
assert_equals: expected "/html/semantics/forms/form-submission-0/resources/location.html" but got "/html/semantics/forms/form-submission-0/resources/form.html"
```
CRASH [expected OK] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
CRASH [expected TIMEOUT] /resource-timing/response-status-code.html (#29309)
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (13)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - name is missing
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-serializable.html (#34120)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: Basic test (formdata event)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: lone surrogate in name and value (normal form)
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
ERROR [expected OK] /workers/semantics/run-a-worker/003.html (#22765)

github-actions · 2025-01-10T08:30:19Z

✨ Try run (#12705404079) succeeded.

Loirooriol · 2025-01-10T14:29:45Z

components/layout_2020/fragment_tree/box_fragment.rs

    /// Additional information of from layout that could be used by Javascripts and devtools.
    #[serde(skip_serializing)]
-    pub detailed_layout_info: Option<DetailedLayoutInfo>,
+    pub detailed_layout_info: Option<SpecificLayoutInfo>,


For consistency, I would rename this to specific_layout_info

This is a followup to servo#34926. Fixes servo#35078.

This is a followup to servo#34926. Fixes servo#35078. Signed-off-by: Martin Robinson <[email protected]>

This is a followup to #34926. Fixes #35078. Signed-off-by: Martin Robinson <[email protected]>

…35104) This is a followup to servo#34926. Fixes servo#35078. Signed-off-by: Martin Robinson <[email protected]> Signed-off-by: L Ashwin B <[email protected]>

Depends on: - servo/stylo#104 - #34926 - #34927 - #34948 In addition to that a `resolve_calc_value` function has been added which resolves calc values during the layout process once a percentage resolution basis is available. ~~There is 1 newly failing test and 1 newly failing subtest here.~~ These issues have now been fixed. There are 8 new subtest failures in `css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html`. These are genuine failures, but are unrelated to the calc implementation. The calc implementation is just exposing a pre-existing bug around percentage resolution that also now correctly also applies to `calc()` values containing percentages. The fix for would best be done in a followup as it requires teaching Taffy about "compressible replaced elements". (update: I have this [implemented](#34948) but in the interest of keeping it to one feature per PR I have not included it here) ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors. It doesn't like the git dependency on Taffy. - [x] There are tests for these changes OR --------- Signed-off-by: Nico Burns <[email protected]>

stevennovaryo added 2 commits January 10, 2025 15:30

Update Taffy and WPT expectations

1d4e63e

Signed-off-by: stevennovaryo <[email protected]>

Rename DetailedInfo to SpecificInfo

d0f2048

Signed-off-by: stevennovaryo <[email protected]>

stevennovaryo force-pushed the bump-taffy-0.7.4 branch from fd910ea to d0f2048 Compare January 10, 2025 07:30

Run fmt

04cfb87

Signed-off-by: stevennovaryo <[email protected]>

stevennovaryo marked this pull request as ready for review January 10, 2025 07:37

stevennovaryo requested review from Loirooriol, mrobinson and nicoburns as code owners January 10, 2025 07:37

nicoburns added the T-linux-wpt Do a try run of the WPT label Jan 10, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 10, 2025

nicoburns approved these changes Jan 10, 2025

View reviewed changes

nicoburns enabled auto-merge January 10, 2025 08:03

nicoburns added this pull request to the merge queue Jan 10, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025

nicoburns added this pull request to the merge queue Jan 10, 2025

nicoburns added the A-layout/grid label Jan 10, 2025

nicoburns mentioned this pull request Jan 10, 2025

Support calc() values in CSS Grid #34846

Merged

3 tasks

Merged via the queue into servo:main with commit bbb255d Jan 10, 2025

Loirooriol reviewed Jan 10, 2025

View reviewed changes

Loirooriol mentioned this pull request Jan 19, 2025

Rename detailed_layout_info to specific_layout_info #35078

Closed

mrobinson added a commit to mrobinson/servo that referenced this pull request Jan 21, 2025

Make naming of variables consistent with SpecificLayoutInfo

f9ef49f

This is a followup to servo#34926. Fixes servo#35078.

mrobinson mentioned this pull request Jan 21, 2025

Make naming of variables consistent with SpecificLayoutInfo #35104

Merged

3 tasks

mrobinson added a commit to mrobinson/servo that referenced this pull request Jan 21, 2025

Make naming of variables consistent with SpecificLayoutInfo

fab2424

This is a followup to servo#34926. Fixes servo#35078. Signed-off-by: Martin Robinson <[email protected]>

mrobinson added a commit to mrobinson/servo that referenced this pull request Jan 21, 2025

Make naming of variables consistent with SpecificLayoutInfo

ab8d15d

This is a followup to servo#34926. Fixes servo#35078. Signed-off-by: Martin Robinson <[email protected]>

mrobinson added a commit to mrobinson/servo that referenced this pull request Jan 21, 2025

Make naming of variables consistent with SpecificLayoutInfo

db3576b

This is a followup to servo#34926. Fixes servo#35078. Signed-off-by: Martin Robinson <[email protected]>

github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025

Make naming of variables consistent with SpecificLayoutInfo (#35104)

102b77a

This is a followup to #34926. Fixes #35078. Signed-off-by: Martin Robinson <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

layout: grid-template getComputedStyle cleanup#34926

layout: grid-template getComputedStyle cleanup#34926
nicoburns merged 3 commits intoservo:mainfrom
stevennovaryo:bump-taffy-0.7.4

stevennovaryo commented Jan 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

nicoburns left a comment

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

Uh oh!

Loirooriol Jan 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

stevennovaryo commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

WPT Result — Try Run

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

nicoburns left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

Uh oh!

Loirooriol Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stevennovaryo commented Jan 10, 2025 •

edited

Loading