layout: grid template getComputedStyle resolved value by stevennovaryo · Pull Request #34885 · servo/servo

stevennovaryo · 2025-01-08T06:49:15Z

Description

Fix getComputedValue() for grid-template-* which should return used value for a resolved-track-list. This will also allow several grid WPT test which used getComputedValue() to be tested accordingly.

In the future, one can include the grid line names and subgrid in the resolved track-list once it is implemented.

Changes

A new field is added in BoxFragment to store the information from layout algorithm. Which will be used to pass the computation details from Grid algorithm (Taffy).
Resolve grid-template-row and grid-template-column using the information.

Feedback are appreciated for the approach of passing the information from layout algorithm.

WPT Result

There are some tests that is previously failed because getComputedStyle() returned computed value. On the other hand some test became failed for the very same reason.

Some css/css-grid/grid-definition/grid-template-columns-rows-resolved-values-001.tentative.html.ini tests seems to fail because the tests wasn't accomodating for implicit grids. Currently, it resemble the results of others browsers better.

Some tests expectation will also be updated once the newest Taffy iteration that fixes my bug is included. Which can be easily done after grid calc changes.

Try

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix getComputedStyle() should return resolved value for ‘grid-template-columns’ and ‘grid-template-rows’ #34537
There are tests for these changes

Signed-off-by: stevennovaryo <[email protected]>

nicoburns · 2025-01-09T10:21:30Z

@stevennovaryo I've published Taffy 0.7.4 with your "empty grid" fix. That should get us a few more test passes.

github-actions · 2025-01-09T10:22:30Z

🔨 Triggering try run (#12687978091) for Linux WPT

nicoburns

This looks excellent. I'd recommend bumping the Taffy version (and updating assertions again) before we merge this, but we can also do this as a follow-up if you prefer.

Looking at the remaining failures in the affected files, they almost looks like they might actually be cases where Taffy is computing the wrong size are tests which include line names (which we don't yet support) which is very good sign. A potential exception being the [Property grid-template-columns value 'none'] subtest which we probably ought to pass?

github-actions · 2025-01-09T10:44:38Z

Test results for linux-wpt-layout-2020 from try job (#12687978091):

Flaky unexpected result (14)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Newline normalization - \r\n in value (urlencoded)
- PASS [expected FAIL] subtest: Newline normalization - \r\n in value (formdata)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- PASS [expected FAIL] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
OK /xhr/open-url-multi-window-5.htm (#23360)
- FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)
```
assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw
```

Stable unexpected results that are known to be intermittent (11)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- PASS [expected FAIL] subtest: form submission
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)

OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)

FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
TIMEOUT [expected OK] /performance-timeline/navigation-id-detached-frame.tentative.html (#34773)
- TIMEOUT [expected PASS] subtest: The navigation_id getter does not crash a window of detached frame
```
Test timed out
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

github-actions · 2025-01-09T10:44:47Z

✨ Try run (#12687978091) succeeded.

nicoburns · 2025-01-09T10:50:01Z

Seeing as this is passing tests and ready to go I'm going to go ahead and merge it before it gets out of date. Taffy version bump can be done in a follow-up :)

mrobinson · 2025-01-09T10:52:32Z

components/layout_2020/fragment_tree/box_fragment.rs

+    /// Additional information of from layout that could be used by Javascripts and devtools.
+    #[serde(skip_serializing)]
+    pub detailed_layout_info: Option<DetailedLayoutInfo>,


Naming nit: SpecificLayoutInfo might be a better description. I like the way you've designed this as we can start putting information for other layout modes here as well.

stevennovaryo · 2025-01-09T11:38:08Z

Thanks for publishing Taffy 7.4.0. I would be happy to bump it later with analyzing the WPT expectations changes once I get back into my proper device. It should fix some none and emptyGrid tests.

It could be bundled with renaming the objects and other minor quality changes too.

stevennovaryo force-pushed the get-computed-style-grid-template branch 3 times, most recently from 1c85eb1 to 45510ce Compare January 9, 2025 04:28

stevennovaryo added 8 commits January 9, 2025 17:41

Store taffy detailed info into fragment

eab5593

Signed-off-by: stevennovaryo <[email protected]>

Fix info propagation and resolved grid track query

e409b66

Signed-off-by: stevennovaryo <[email protected]>

Fix import

a2a7b51

Signed-off-by: stevennovaryo <[email protected]>

Fix tracklist matching logic and type optimization

886913e

Signed-off-by: stevennovaryo <[email protected]>

Run fmt

386bfbb

Signed-off-by: stevennovaryo <[email protected]>

Update wpt expectations

1ddf900

Signed-off-by: stevennovaryo <[email protected]>

Optimizing info propagation and minor qol

8ca4a34

Signed-off-by: stevennovaryo <[email protected]>

Run fmt

eaef90b

Signed-off-by: stevennovaryo <[email protected]>

stevennovaryo force-pushed the get-computed-style-grid-template branch from 99d608d to eaef90b Compare January 9, 2025 09:41

stevennovaryo marked this pull request as ready for review January 9, 2025 09:42

stevennovaryo requested review from Loirooriol, mrobinson and nicoburns as code owners January 9, 2025 09:42

nicoburns added the T-linux-wpt Do a try run of the WPT label Jan 9, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 9, 2025

nicoburns approved these changes Jan 9, 2025

View reviewed changes

nicoburns mentioned this pull request Jan 9, 2025

Support calc() values in CSS Grid #34846

Merged

3 tasks

nicoburns added this pull request to the merge queue Jan 9, 2025

mrobinson approved these changes Jan 9, 2025

View reviewed changes

Merged via the queue into servo:main with commit 76fa456 Jan 9, 2025

stevennovaryo mentioned this pull request Jan 10, 2025

layout: grid-template getComputedStyle cleanup #34926

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

layout: grid template getComputedStyle resolved value#34885

layout: grid template getComputedStyle resolved value#34885
nicoburns merged 8 commits intoservo:mainfrom
stevennovaryo:get-computed-style-grid-template

stevennovaryo commented Jan 8, 2025 •

edited

Loading

Uh oh!

nicoburns commented Jan 9, 2025

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

nicoburns left a comment

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

nicoburns commented Jan 9, 2025 •

edited

Loading

Uh oh!

mrobinson Jan 9, 2025

Uh oh!

stevennovaryo commented Jan 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

stevennovaryo commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

WPT Result

Uh oh!

nicoburns commented Jan 9, 2025

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

nicoburns left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

nicoburns commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrobinson Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

stevennovaryo commented Jan 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stevennovaryo commented Jan 8, 2025 •

edited

Loading

nicoburns commented Jan 9, 2025 •

edited

Loading