Remove custom ReadableStream patch from WebIDL code generation#34835
Merged
Taym95 merged 1 commit intoservo:mainfrom Jan 4, 2025
Merged
Remove custom ReadableStream patch from WebIDL code generation#34835Taym95 merged 1 commit intoservo:mainfrom
Taym95 merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Taym Haddadi <[email protected]>
Taym95
force-pushed
the
Remove-readable-streams-from-webidl
branch
from
1e9f0a2 to
c8e0eb8
Compare
Taym95
changed the title
sagudev
approved these changes
Jan 4, 2025
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
TBH I completely forgot about this so thank you!
mrobinson
changed the title
mrobinson
changed the title
mrobinson
approved these changes
Jan 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #34676
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors