Skip to content

servoshell: Remove duplicate egl bindings on android/ohos#34716

Merged
jschwe merged 1 commit intoservo:mainfrom
jschwe:jschwender/remove_duplicate_gl_bindings
Dec 20, 2024
Merged

servoshell: Remove duplicate egl bindings on android/ohos#34716
jschwe merged 1 commit intoservo:mainfrom
jschwe:jschwender/remove_duplicate_gl_bindings

Conversation

@jschwe
Copy link
Copy Markdown
Member

@jschwe jschwe commented Dec 20, 2024 •
edited by sagudev
Loading

The generated bindings were mainly used for

    egl.SwapInterval(display, 1);
   // .......
    gl.clear_color(1.0, 1.0, 1.0, 1.0);
    gl.clear(gl::COLOR_BUFFER_BIT);
    gl.finish();

The default value for SwapInterval is 1, so setting it to 1 changes nothing.

  • We now don't clear the screen immediately anymore, but that doesn't seem enough justification to keep the additional bindings here.
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes partially fix Unify GL bindings behind glow #33539
  • There are tests for these changes

@jschwe
servoshell: Remove duplicate egl bindings on android/ohos
8641514 
- The default value for SwapInterval is 1,
  so setting it to 1 changes nothing
- We don't clear the screen immediately anymore, which was the only
  useage of the egl bindings

this saves us from duplicated EGL bindings.

Signed-off-by: Jonathan Schwender <[email protected]>
@jschwe jschwe force-pushed the jschwender/remove_duplicate_gl_bindings branch from ac7081b to 8641514 Compare December 20, 2024 11:04
@jschwe jschwe added this pull request to the merge queue Dec 20, 2024
@sagudev sagudev mentioned this pull request Dec 20, 2024
Open
3 tasks
Merged via the queue into servo:main with commit 0dd8798 Dec 20, 2024
@jschwe jschwe deleted the jschwender/remove_duplicate_gl_bindings branch December 20, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unify GL bindings behind glow

2 participants

@jschwe @mrobinson