ci: Set CCACHE only for github hosted runner#34670
Merged
Conversation
I believe this should fix #34603 (comment) Signed-off-by: Samson <[email protected]>
Member
Do we need persistent storage if ccache-action uses the Github Action cache?
|
mukilan
approved these changes
Dec 17, 2024
Member
mukilan
left a comment
mukilan
left a comment
There was a problem hiding this comment.
Approving this as it looks good to me as a workaround.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should fix #34603 (comment), same tricks as in linux workflow:
servo/.github/workflows/linux.yml
Lines 109 to 111 in 9c59802
Alternative would be to actually install ccache in windows images, but that could/will take a long time and I am not sure if we have persistent storage on self hosted anyway cc @delan?
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors