mach: adopt uv and avoid system python#34632
Merged
mukilan merged 1 commit intoservo:mainfrom Dec 16, 2024
Merged
Conversation
Member
Author
This allows us to use `uv` for: 1. Installing a pinned Python version 2. Installing the dependency packages using `uv`'s pip compatible interface. 4. Bootstrapping `mach` without a Python installion on the host, using `uv run` This change also introduces a new 'composite' GitHub action to setup python in the different CI workflows. There is no support for externally managed python installations and virtual environments. These could be added in the future. Fixes servo#34095, servo#34547 Signed-off-by: Mukilan Thiyagarajan <[email protected]>
8f57f75 to
198b128
Compare
This was referenced Dec 16, 2024
jschwe
reviewed
Dec 16, 2024
jschwe
reviewed
Dec 16, 2024
jschwe
approved these changes
Dec 16, 2024
mukilan
added a commit
to mukilan/book
that referenced
this pull request
Dec 18, 2024
`mach` now [depends on `uv`][1] being already installed on the host to bootstrap the Python environment. This change updates the `Setting up your environment` to include the steps for installing `uv` on the host system. [1]: servo/servo#34632 Signed-off-by: Mukilan Thiyagarajan <[email protected]>
delan
pushed a commit
to servo/book
that referenced
this pull request
Dec 18, 2024
`mach` now [depends on `uv`][1] being already installed on the host to bootstrap the Python environment. This change updates the `Setting up your environment` to include the steps for installing `uv` on the host system. [1]: servo/servo#34632 Signed-off-by: Mukilan Thiyagarajan <[email protected]>
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 19, 2024
{"fail_fast": false, "matrix": [{"name": "WebGPU CTS", "workflow": "linux", "wpt_layout": "2020", "profile": "production", "unit_tests": false, "bencher": false, "wpt_args": "_webgpu"}]}
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 19, 2024
{"fail_fast": false, "matrix": [{"name": "WebGPU CTS", "workflow": "linux", "wpt_layout": "2020", "profile": "production", "unit_tests": false, "bencher": false, "wpt_args": "_webgpu"}]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to use
uvfor:uv's pip compatible interface.machwithout a Python installion on the host, usinguv runThis change also introduces a new 'composite' GitHub action to setup python in the different CI workflows. There is no support for externally managed python installations and virtual environments. These could be added in the future.
Fixes #34095, #34547
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors.\mach bootstrapproperly #34095, mach build (still) busted with system python3.13 #34547