XPath: implement lang() and id() core functions by vlindhol · Pull Request #34594 · servo/servo

vlindhol · 2024-12-12T09:44:47Z

XPath's lang() and id() functions were still unimplemented.

Also:

Add WPT tests for id().
Fix uniqueness check in NodesetHelpers::document_order_unique.
Tweak the AST a bit to make it clearer to express "no predicates".
Fix a parsing bug where "/" was attempted before "//", leaving the "//" branch as always unused.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix XPath: implement lang() and id() core functions #34593
There are tests for these changes

components/script/dom/element.rs

components/script/dom/node.rs

simonwuelker · 2024-12-12T20:11:16Z

Are there no web platform tests for the id function?

vlindhol · 2024-12-12T20:46:41Z

Are there no web platform tests for the id function?

You are correct! I should probably add at least one smoke test. If I understood correctly, tests/wpt/mozilla is for our own tests, right? Ooooh or should I be making a PR to the actual WPT test suite?

simonwuelker · 2024-12-12T21:27:46Z

If I understood correctly, tests/wpt/mozilla is for our own tests, right?

Yes, but tests for id can easily be upstreamed, so we should add them to WPT. That way other browsers can benefit from them too.

Ooooh or should I be making a PR to the actual WPT test suite?

You don't need to make a separate PR for web platform tests (though you can, of course), an upstream PR will be opened automatically if you add the tests here.

The book has some info on adding new tests: https://book.servo.org/hacking/testing.html#writing-new-web-tests.

Signed-off-by: Ville Lindholm <[email protected]>

simonwuelker · 2025-03-05T19:33:54Z

Are you still working on this?

vlindhol · 2025-03-06T09:01:09Z

Are you still working on this?

@simonwuelker yes, I've dropped off from OSS work for a few months due to personal reasons, but still very much am planning to continue this. Should be back in action in a week or two by the looks of it!

Signed-off-by: Ville Lindholm <[email protected]>

* main: (510 commits) DevTools: Fix empty `debugger > source` panel (servo#37197) dom: implement signal abort on controller and signal (servo#37192) build(deps): bump parking_lot from 0.12.3 to 0.12.4 (servo#37199) layout: Split overflow calculation after fragment tree construction (servo#37203) build(deps): bump parking_lot_core from 0.9.10 to 0.9.11 (servo#37202) build(deps): bump lock_api from 0.4.12 to 0.4.13 (servo#37201) build(deps): bump cc from 1.2.24 to 1.2.25 (servo#37198) Constellation can now optionally report memory usage when the page is loaded. (servo#37151) Implement Input `type=text` UA Shadow DOM (servo#37065) constellation: Wait for canvas thread to shut down before shutting down system font service (servo#37182) Add slot default display style test (servo#37189) Send synthetic keydown/keyup at ime_insert_text (servo#37175) script: Let canvas serialization to image fail gracefully (servo#37184) Implement basics of link preloading (servo#37036) compositor: Add an initial RefreshDriver (servo#37169) pixels: Add limitation to max image total bytes length (servo#37172) Chore: Remove unused variable in `transition-zero-duration-with-delay.html` (servo#37179) build(deps): bump ohos-ime from 0.2.0 to 0.3.0 (servo#37180) Add a user agent style for the `<slot>` element (servo#37174) build(deps): bump hitrace from 0.1.4 to 0.1.5 (servo#37170) ...

servo-wpt-sync · 2025-06-01T11:04:20Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#52891) with upstreamable changes.

Signed-off-by: Ville Lindholm <[email protected]>

servo-wpt-sync · 2025-06-01T11:13:51Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#52891).

Signed-off-by: Ville Lindholm <[email protected]>

servo-wpt-sync · 2025-06-01T11:28:42Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#52891).

servo-wpt-sync · 2025-06-01T11:29:56Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#52891) title and body.

Signed-off-by: Ville Lindholm <[email protected]>

servo-wpt-sync · 2025-06-01T11:39:09Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#52891).

vlindhol · 2025-06-01T12:11:27Z

@mrobinson @simonwuelker sorry for the longer-than-anticipated break, the PR is now up-to-date with tests for id() and AFAICT all other PR review things fixed!

simonwuelker

Thanks, LGTM with two nits (:

components/script/xpath/eval.rs

tests/wpt/tests/domxpath/fn-id.html

Signed-off-by: Ville Lindholm <[email protected]>

servo-wpt-sync · 2025-06-02T07:09:20Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#52891).

simonwuelker · 2025-06-02T08:30:04Z

Just one more ./mach update-manifest and we can merge this ^^

Signed-off-by: Ville Lindholm <[email protected]>

servo-wpt-sync · 2025-06-02T08:46:21Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#52891).

simonwuelker · 2025-06-02T15:04:11Z

this needs a re-review from @mrobinson to be able to merge

jdm · 2025-06-02T18:59:46Z

Given mrobinson's previous review comments, I'm going to mark it as addressed.

Addressed.

vlindhol requested a review from gterzian as a code owner December 12, 2024 09:44

vlindhol force-pushed the xpath-lang branch from 6df415b to 6a1bbef Compare December 12, 2024 09:49

vlindhol commented Dec 12, 2024

View reviewed changes

components/script/dom/element.rs Show resolved Hide resolved

mrobinson previously requested changes Dec 12, 2024

View reviewed changes

components/script/dom/node.rs Outdated Show resolved Hide resolved

components/script/dom/node.rs Outdated Show resolved Hide resolved

vlindhol requested a review from mrobinson December 12, 2024 19:06

vlindhol added 3 commits December 13, 2024 10:54

XPath: add lang() and id() support

fb2e2cd

Signed-off-by: Ville Lindholm <[email protected]>

fix lint error, this did not occur locally

cc4233a

Signed-off-by: Ville Lindholm <[email protected]>

PR review

5e586b7

Signed-off-by: Ville Lindholm <[email protected]>

Merge branch 'main' into xpath-lang

58293ac

vlindhol force-pushed the xpath-lang branch from 3f47df2 to 58293ac Compare April 5, 2025 08:03

vlindhol added 3 commits April 5, 2025 12:16

lint

e31e448

Signed-off-by: Ville Lindholm <[email protected]>

fix build error after merge from main

fb971b2

Signed-off-by: Ville Lindholm <[email protected]>

mach fmt

9098bf4

Signed-off-by: Ville Lindholm <[email protected]>

vlindhol force-pushed the xpath-lang branch from 387c9d2 to 9098bf4 Compare April 5, 2025 09:17

servo-wpt-sync mentioned this pull request Jun 1, 2025

XPath: implement lang() and id() core functions web-platform-tests/wpt#52891

Merged

add xpath id() function tests

3d9ceff

Signed-off-by: Ville Lindholm <[email protected]>

vlindhol force-pushed the xpath-lang branch from 8d905f2 to 3d9ceff Compare June 1, 2025 11:10

Lint WPT test

de6b290

Signed-off-by: Ville Lindholm <[email protected]>

test-tidy

bc72d7e

Signed-off-by: Ville Lindholm <[email protected]>

simonwuelker approved these changes Jun 1, 2025

View reviewed changes

components/script/xpath/eval.rs Outdated Show resolved Hide resolved

tests/wpt/tests/domxpath/fn-id.html Outdated Show resolved Hide resolved

PR review 2

74557e3

Signed-off-by: Ville Lindholm <[email protected]>

Update manifest (always forget that!)

04ed7c7

Signed-off-by: Ville Lindholm <[email protected]>

simonwuelker enabled auto-merge June 2, 2025 09:13

simonwuelker disabled auto-merge June 2, 2025 15:04

jdm added this pull request to the merge queue Jun 2, 2025

Merged via the queue into servo:main with commit 8cfb6e3 Jun 2, 2025
21 checks passed

vlindhol deleted the xpath-lang branch June 3, 2025 07:44

Uh oh!

Conversation

vlindhol commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

simonwuelker commented Dec 12, 2024

Uh oh!

vlindhol commented Dec 12, 2024

Uh oh!

simonwuelker commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonwuelker commented Mar 5, 2025

Uh oh!

vlindhol commented Mar 6, 2025

Uh oh!

servo-wpt-sync commented Jun 1, 2025

Uh oh!

servo-wpt-sync commented Jun 1, 2025

Uh oh!

servo-wpt-sync commented Jun 1, 2025

Uh oh!

servo-wpt-sync commented Jun 1, 2025

Uh oh!

servo-wpt-sync commented Jun 1, 2025

Uh oh!

vlindhol commented Jun 1, 2025

Uh oh!

simonwuelker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

servo-wpt-sync commented Jun 2, 2025

Uh oh!

simonwuelker commented Jun 2, 2025

Uh oh!

servo-wpt-sync commented Jun 2, 2025

Uh oh!

simonwuelker commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdm commented Jun 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vlindhol commented Dec 12, 2024 •

edited

Loading

simonwuelker commented Dec 12, 2024 •

edited

Loading

simonwuelker commented Jun 2, 2025 •

edited

Loading