Merged
Conversation
jdm
approved these changes
Oct 21, 2024
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
Very nice! Who knew we fired so many error events?
mukilan
reviewed
Oct 22, 2024
| line_number: u32, | ||
| fetch_options: ScriptFetchOptions, | ||
| script_base_url: ServoUrl, | ||
| can_gc: CanGc, |
Member
There was a problem hiding this comment.
We need to allow this method to avoid the lint error:
error: this function has too many arguments (8/7)
--> components/script/dom/globalscope.rs:2633:5
|
2633 | / pub fn evaluate_script_on_global_with_result(
2634 | | &self,
2635 | | code: &SourceCode,
2636 | | filename: &str,
... |
2641 | | can_gc: CanGc,
2642 | | ) -> bool {
Contributor
Author
There was a problem hiding this comment.
I'll open a new PR for that?
Member
There was a problem hiding this comment.
No, it can be addressed in this PR.
Contributor
Author
There was a problem hiding this comment.
Alright, on it!
Signed-off-by: taniishkaaa <[email protected]>
Signed-off-by: taniishkaaa <[email protected]>
auto-merge was automatically disabled
October 22, 2024 09:35
Head branch was pushed to by a user without write access
mukilan
approved these changes
Oct 22, 2024
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces CanGc::note() calls with arguments passed by callers in
components/script/dom/errorevent.rs./mach build -ddoes not report any errors./mach test-tidydoes not report any errors