Update to surfman&webxr without sparkle and use glow 0.15#33538
Update to surfman&webxr without sparkle and use glow 0.15#33538sagudev merged 1 commit intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#11027483929) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#11027483929): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (12)
|
|
✨ Try run (#11027483929) succeeded. |
cc3ed96 to
f93cfa6
Compare
|
🔨 Triggering try run (#11268294572) for Linux WPT, MacOS, Windows, Android, OpenHarmony, Lint |
|
Test results for linux-wpt-layout-2013 from try job (#11268294572): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (22)
|
|
Test results for linux-wpt-layout-2020 from try job (#11268294572): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (17)
|
|
|
|
@msub2 could you try the webxr changes. I will test windows and linux. |
Will try this out today and let you know |
|
when running twgl on win I get:
|
|
Hmmm, trying to run a WebXR sample throws an error in the WebXR crate's OpenXR input code Not sure why/how that's happening, I'm pretty sure this doesn't happen on main. Will need to do some more digging |
GLES only have glClearDepthf https://github.com/servo/sparkle/blob/a61f94fff95d29e93721cdbfc4b5dde8671a6970/src/lib.rs#L736-L740, but we can solve this by grovesNL/glow#310. |
|
It works now on linux and win, but we need to get grovesNL/glow#310 landed. |
3ce7e61 to
17f5884
Compare
|
🔨 Triggering try run (#11372576320) for Linux WPT, MacOS, Windows, Android, OpenHarmony, Lint |
|
Test results for linux-wpt-layout-2013 from try job (#11372576320): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (43)
|
|
Test results for linux-wpt-layout-2020 from try job (#11372576320): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (18)
|
|
|
|
@msub2 could you test webxr again. |
Sure thing, will kick off a build in a few minutes |
|
@sagudev Had to apply a fix from main onto your branch for webxr but it's working for me 👍 |
|
This is blocked on servo/webxr#248 and then on #33866. When blockers are resolved my plan is to NOT release new surfman version, but use git version, because after cleaning up all sparkle I will remove gl_generator from surfman and that would be another breaking change (WIP already at servo/surfman#321). |
Signed-off-by: sagudev <[email protected]>
17f5884 to
1098db1
Compare
jdm
left a comment
There was a problem hiding this comment.
From a code standpoint this looks fine. Have we verified that webxr still works?
@msub2 verified it. Last change was rebase and switching to landed webxr (instead of using my fork). |
This PR updates surfman and webxr to versions that use glow instead of sparkle for gl bindings (see #33539 for motivation). For now we store both glow::Context and Gl (sparkle's gl context) in
GLContextData, but with eventual removal of sparkle only glow will remain.companion PR to servo/surfman#318, servo/webxr#248
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors