Conversation
Signed-off-by: Andriy Sultanov <[email protected]>
Signed-off-by: Andriy Sultanov <[email protected]>
|
There are a few autogenerated things that I couldn't figure how to modify: Another issue I wanted to ask about is whether I should make |
|
Good question about the moved value! Yes, we should derive copy and clone to make passing it around as easy as possible. |
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
This is really helpful! Let's add the copy derive and remove a bunch of the CanGc::note calls, and then let's merge this!
| fn drop(&mut self) { | ||
| if let Some(load) = self.load.take() { | ||
| self.doc.finish_load(load); | ||
| self.doc.finish_load(load, CanGc::note()); |
There was a problem hiding this comment.
This is a really interesting result from this work! I would not have assumed that dropping a LoadBlocker value could cause a JS GC, and it's neat that this PR makes that more clear.
|
Actually, to reduce the risk of merge conflicts let's merge this as-is and do the derive and replacements in a followup. |
2 participants
Following #33140 and #33144, more work on marking functions that can transitively trigger a GC to easier recognize hazards.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors