Mark some ResizeObserver tests as flaky#32546
Merged
mrobinson merged 1 commit intoservo:mainfrom Jun 18, 2024
Merged
Conversation
ResizeObserver isn't completed.
13 tasks
gterzian
approved these changes
Jun 18, 2024
Member
gterzian
left a comment
gterzian
left a comment
There was a problem hiding this comment.
thanks for noticing, I've added notes about these in #31182.
The relevant notes are:
- iframe-same-origin.html appears intermittent for an unknown reason(I haven't seen it fail locally yet, making it hard to debug so far). See #32546
- observe.html At least one test(test7?) appears intermittently to timeout, and when it passes it makes other test fails(as opposed to not run). See #32549 for how to make at least three tests pass. Others remain to un-investigated.
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResizeObserver isn't completed.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors