script: implement autofocus IDL reflection#32170
Merged
mrobinson merged 2 commits intoservo:mainfrom Apr 29, 2024
Merged
Conversation
6 tasks
mrobinson
approved these changes
Apr 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Contributor
Author
|
Sorry, somehow I messed up running the WPT tests locally. That should fix it ^ |
Loirooriol
reviewed
Apr 29, 2024
Contributor
Loirooriol
left a comment
Loirooriol
left a comment
There was a problem hiding this comment.
But the autofocus functionality is still not supported, right? So what's the point of implementing the IDL reflection?
Contributor
Author
|
Right, it's just about getting the WPT tests passing and refactoring to use the right WebIDL mixin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially addresses #32169 by implementing the
autofocusIDL attribute reflection and adding theHTMLOrSVGElementmixin../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsHTMLOrSVGElementWebIDL #32169