Turn white-space into a shorthand#32146
Conversation
|
🔨 Triggering try run (#8837962271) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2013 from try job (#8837962271): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (247)
|
|
Test results for linux-wpt-layout-2020 from try job (#8837962271): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (257)
|
|
|
d06f05a to
5542a7f
Compare
|
🔨 Triggering try run (#8840401221) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#8840401221): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (6)
Stable unexpected results (12)
|
|
Test results for linux-wpt-layout-2020 from try job (#8840401221): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (6)
|
|
|
This ports servo#31277 (with the changes from servo#32066) into legacy layout. Otherwise, turning white-space into a shorthand (servo#32146) would fail some tests that expect the property to be serializable.
5542a7f to
8320071
Compare
|
🔨 Triggering try run (#8846913625) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#8846913625): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (11)
Stable unexpected results (67)
|
|
|
8320071 to
6027fc9
Compare
|
🔨 Triggering try run (#8854647944) for Linux WPT |
6027fc9 to
ffd8a16
Compare
|
Test results for linux-wpt-layout-2013 from try job (#8854647944): Flaky unexpected result (10)
Stable unexpected results that are known to be intermittent (12)
Stable unexpected results (2)
|
|
Test results for linux-wpt-layout-2020 from try job (#8854647944): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (19)
|
|
|
|
Adding
|
|
🔨 Triggering try run (#8876788835) for Linux WPT |
|
|
Bumps Stylo to servo/stylo#37 `white-space` is split into `white-space-collapse` and `text-wrap-mode`: | white-space | white-space-collapse | text-wrap-mode | | ----------- | -------------------- | -------------- | | normal | collapse | wrap | | nowrap | collapse | nowrap | | pre-wrap | preserve | wrap | | pre | preserve | nowrap | | pre-line | preserve-breaks | wrap | | - | preserve-breaks | nowrap | Note this introduces a combination that wasn't previously possible, but I think the existing logic can handle it well enough. The old `allow_wrap()` is replaced by checking whether `text-wrap-mode` is set to `wrap`. The old `preserve_newlines()` is replaced by checking whether `white-space-collapse` is *not* set to `collapse`. The old `preserve_spaces()` is replaced by checking whether `white-space-collapse` is set to `preserve`.
26c1e94 to
f2b6cb5
Compare
Bumps Stylo to servo/stylo#37
white-spaceis split intowhite-space-collapseandtext-wrap-mode:Note this introduces a combination that wasn't previously possible, but I think the existing logic can handle it well enough.
The old
allow_wrap()is replaced by checking whethertext-wrap-modeis set towrap.The old
preserve_newlines()is replaced by checking whetherwhite-space-collapseis not set tocollapse.The old
preserve_spaces()is replaced by checking whetherwhite-space-collapseis set topreserve../mach build -ddoes not report any errors./mach test-tidydoes not report any errors