Merged
Conversation
Loirooriol
added
T-full
|
🔨 Triggering try run (#8669373035) for Linux WPT, MacOS, Windows, Android |
Loirooriol
force-pushed
the
stylo-2024-01-16
branch
from
8b64d8a to
6770a8f
Compare
|
Test results for linux-wpt-layout-2013 from try job (#8669373035): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (43)
|
|
Test results for linux-wpt-layout-2020 from try job (#8669373035): Flaky unexpected result (22)
Stable unexpected results that are known to be intermittent (12)
Stable unexpected results (37)
|
|
|
Loirooriol
force-pushed
the
stylo-2024-01-16
branch
from
6770a8f to
e84ad18
Compare
|
🔨 Triggering try run (#8673976682) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#8673976682): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (10)
|
|
Test results for linux-wpt-layout-2020 from try job (#8673976682): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (10)
|
|
✨ Try run (#8673976682) succeeded. |
mrobinson
requested changes
Apr 13, 2024
Comment on lines
+770
to
+775
| match id.unaliased().as_longhand() { | ||
| Some(id) => id, | ||
| // Firefox returns blank strings for the computed value of shorthands, | ||
| // so this should be web-compatible. | ||
| None => return String::new(), | ||
| } |
Member
There was a problem hiding this comment.
Could this be simply: id.unaliased().as_longhand().unwrap_or_default()?
Contributor
Author
There was a problem hiding this comment.
But there is no default LonghandId, the early return is needed.
Comment on lines
+819
to
+823
| match id.unaliased().as_longhand() { | ||
| Some(id) => id, | ||
| // Firefox returns blank strings for the computed value of shorthands, | ||
| // so this should be web-compatible. | ||
| None => return String::new(), |
mrobinson
approved these changes
Apr 13, 2024
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Looks good modulo a couple nits above.
Loirooriol
force-pushed
the
stylo-2024-01-16
branch
from
e84ad18 to
4b7327a
Compare
Loirooriol
force-pushed
the
stylo-2024-01-16
branch
from
4b7327a to
c8d006c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 tasks
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Apr 26, 2024
This ports servo#31277 (with the changes from servo#32066) into legacy layout. Otherwise, turning white-space into a shorthand (servo#32146) would fail some tests that expect the property to be serializable.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #32032
Changelog:
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors