Skip to content

clippy: Fix mem_replace_with_default warnings in components#31921

Merged
mrobinson merged 1 commit intoservo:mainfrom
oluwatobiss:fix/mem-replace-with-default-warnings
Mar 28, 2024
Merged

clippy: Fix mem_replace_with_default warnings in components#31921
mrobinson merged 1 commit intoservo:mainfrom
oluwatobiss:fix/mem-replace-with-default-warnings

Conversation

@oluwatobiss
Copy link
Copy Markdown
Contributor

@oluwatobiss oluwatobiss commented Mar 28, 2024

Change std::mem::replace() code with std::mem::take() to fix the mem_replace_with_default warnings.

ref: https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they only resolve clippy warnings. They do not change functionalities.

@mrobinson mrobinson enabled auto-merge March 28, 2024 12:27
@mrobinson mrobinson added this pull request to the merge queue Mar 28, 2024
Merged via the queue into servo:main with commit 66ad795 Mar 28, 2024
ektuu pushed a commit to ektuu/servo that referenced this pull request Mar 28, 2024
MunishMummadi pushed a commit to MunishMummadi/servo that referenced this pull request Mar 29, 2024
@oluwatobiss oluwatobiss deleted the fix/mem-replace-with-default-warnings branch April 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants