Merged
Conversation
|
🔨 Triggering try run (#8074505483) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2013 from try job (#8074505483): Flaky unexpected result (46)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (46)
|
|
Test results for linux-wpt-layout-2020 from try job (#8074505483): Flaky unexpected result (34)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (40)
|
|
|
1003c7d to
bc6fe4b
Compare
|
🔨 Triggering try run (#8077834246) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2013 from try job (#8077834246): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (17)
|
|
Test results for linux-wpt-layout-2020 from try job (#8077834246): Flaky unexpected result (21)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#8077834246) succeeded. |
bc6fe4b to
ba076ce
Compare
ba076ce to
cf18ac9
Compare
Contributor
Author
|
We still need to figure out what to do with the branches in Stylo, but this PR is basically done. |
mrobinson
approved these changes
Feb 29, 2024
Member
mrobinson
left a comment
There was a problem hiding this comment.
I've reviewed these changes as well as the new commits on top of the upstream branch 2023-07-23 and this all looks good to me. Thanks!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #30770.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsopacity-valid.htmlfails because of https://bugzilla.mozilla.org/show_bug.cgi?id=1851464, should pass when a future update imports the fix.