Fix CSSStyleDeclaration's item() to provide properties instead of values by Loirooriol · Pull Request #31299 · servo/servo

Loirooriol · 2024-02-09T13:17:27Z

For example,

style.cssText = "margin: 1px 2px 3px 4px";
[...style];

will now be

["margin-top", "margin-right", "margin-bottom", "margin-left"]

instead of

["1px", "2px", "3px", "4px"]

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Investigate why css-style-declaration-modifications.html and inline-style-001.html times out #21579

There are tests for these changes

github-actions · 2024-02-09T13:17:46Z

🔨 Triggering try run (#7844561846) for Linux WPT, MacOS, Windows, Android

github-actions · 2024-02-09T14:06:51Z

Test results for linux-wpt-layout-2013 from try job (#7844561846):

Flaky unexpected result (15)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
FAIL [expected PASS] /css/compositing/root-element-opacity-change.html (#26366)
TIMEOUT [expected OK] /css/css-flexbox/abspos/position-absolute-013.html (#28405)
OK /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
- FAIL [expected PASS] subtest: listener added with addListener and addEventListener is called once assert_equals: triggerMQLEvent expected 1 but got 0
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent) Test timed out
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation assert_equals: expected "" but got "#fragment"
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work. assert_not_equals: got disallowed value Element node <body></body>
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 29443840 but got 29444096
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe Test timed out

Stable unexpected results that are known to be intermittent (10)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='' assert_unreached: load should not be fired Reached unreachable code
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
CRASH [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus Test timed out
- NOTRUN [expected PASS] subtest: Non-HTMLElement should not support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
ERROR [expected OK] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- FAIL [expected PASS] subtest: The end: DOMContentLoaded and defer scripts assert_false: DOMContentLoaded should not have fired before executing a task queued from a defer script expected false got true
OK /html/webappapis/dynamic-markup-insertion/document-write/module-delayed.html (#27659)
- PASS [expected FAIL] subtest: async document.write in a module
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

Stable unexpected results (1)

OK /css/css-variables/variable-invalidation.html
- PASS [expected FAIL] subtest: css rule test
- PASS [expected FAIL] subtest: css rule test important
- PASS [expected FAIL] subtest: inline style test
- PASS [expected FAIL] subtest: inline style test important

github-actions · 2024-02-09T14:07:08Z

Test results for linux-wpt-layout-2020 from try job (#7844561846):

Flaky unexpected result (14)

CRASH [expected PASS] /_webgl/conformance/glsl/bugs/temp-expressions-should-not-crash.html (#22050)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /dom/events/webkit-transition-end-event.html (#26497)
- TIMEOUT [expected FAIL] subtest: webkitTransitionEnd event listener should trigger for an animation Test timed out
- NOTRUN [expected PASS] subtest: webkitTransitionEnd event listener should not trigger if an unprefixed listener also exists
- NOTRUN [expected PASS] subtest: webkitTransitionEnd event listener should not trigger if an unprefixed event handler also exists
- NOTRUN [expected FAIL] subtest: event types for prefixed and unprefixed transitionend event listeners should be named appropriately
- NOTRUN [expected PASS] subtest: webkitTransitionEnd event listener is case sensitive
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
TIMEOUT [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task Test timed out
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- TIMEOUT [expected FAIL] subtest: Sanity check: this all works as expected with no promises involved Test timed out
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on rejected promise Test timed out
ERROR /resource-timing/content-type-parsing.html (#29131)
- TIMEOUT [expected FAIL] subtest: mime-type 16 : text/html;charset=�gbk Test timed out
- NOTRUN [expected TIMEOUT] subtest: mime-type 17 : text/html;charset=gbk
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 5005312 but got 5005056
TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (16)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '400' should prefer '350 399' over '351 398'
- FAIL [expected PASS] subtest: Matching font-weight: '400' should prefer '351 398' over '501 550' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '501 550' over '502 560' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '450 460' over '400' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '400' over '350 399' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '500' should prefer '501 550' over '502 560'
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '200 300' over '400'
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '450 460' over '500 501'
- FAIL [expected PASS] subtest: Matching font-stretch: '100%' should prefer '100%' over '110% 120%' assert_equals: Unexpected font on test element expected 487 but got 532
- And 9 more unexpected results...
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- PASS [expected FAIL] subtest: looks up handleEvent method on every event dispatch
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
- TIMEOUT [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes Test timed out
- NOTRUN [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes
- NOTRUN [expected TIMEOUT] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Host element with delegatesFocus should support autofocus promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Area element should support autofocus promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: DOMParser
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- TIMEOUT [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document Test timed out
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out
OK [expected ERROR] /workers/baseurl/alpha/import-in-moduleworker.html (#21315)
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results (1)

OK /css/css-variables/variable-invalidation.html
- PASS [expected FAIL] subtest: css rule test
- PASS [expected FAIL] subtest: css rule test important
- PASS [expected FAIL] subtest: inline style test
- PASS [expected FAIL] subtest: inline style test important

For example, style.cssText = "margin: 1px 2px 3px 4px"; [...style]; will now be ["margin-top", "margin-right", "margin-bottom", "margin-left"] instead of ["1px", "2px", "3px", "4px"]

github-actions · 2024-02-09T14:10:07Z

🔨 Triggering try run (#7845146670) for Linux WPT, MacOS, Windows, Android

github-actions · 2024-02-09T14:20:37Z

⚠️ Try run (#7844561846) failed.

github-actions · 2024-02-09T14:57:51Z

Test results for linux-wpt-layout-2013 from try job (#7845146670):

Flaky unexpected result (12)

CRASH [expected PASS] /_mozilla/mozilla/worklets/test_paint_worklet_timeout.html
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /css/css-flexbox/abspos/position-absolute-013.html (#28405)
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout assert_equals: Expected nested setTimeout to run second expected true but got false
- FAIL [expected PASS] subtest: Check execution order on load handler assert_equals: Expected onload to run first expected false but got true
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
- TIMEOUT [expected FAIL] subtest: location.href setter throws a SyntaxError DOMException for unparseable URLs Test timed out
- NOTRUN [expected FAIL] subtest: <a> tag navigate fails for unparseable URLs
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: 0x00 in name (normal form)
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results that are known to be intermittent (11)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
- FAIL [expected PASS] subtest: listeners for "change" type are called assert_equals: expected 1 but got 0
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- PASS [expected FAIL] subtest: 0041 set in href="" targeting a frame and clicked
- PASS [expected FAIL] subtest: 0080 00FF set in href="" targeting a frame and clicked
- PASS [expected FAIL] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
- PASS [expected FAIL] subtest: D83D DE0D set in href="" targeting a frame and clicked
- PASS [expected FAIL] subtest: DE0D 0041 set in href="" targeting a frame and clicked
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work. assert_not_equals: got disallowed value Element node <body></body>
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus Test timed out
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- FAIL [expected PASS] subtest: The end: DOMContentLoaded and defer scripts assert_false: DOMContentLoaded should not have fired before executing a task queued from a defer script expected false got true
OK /html/webappapis/dynamic-markup-insertion/document-write/module-delayed.html (#27659)
- PASS [expected FAIL] subtest: async document.write in a module
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 6446592 but got 6446336
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank

github-actions · 2024-02-09T14:59:45Z

Test results for linux-wpt-layout-2020 from try job (#7845146670):

Flaky unexpected result (17)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- PASS [expected FAIL] subtest: looks up handleEvent method on every event dispatch
- FAIL [expected PASS] subtest: doesn't look up handleEvent method on callable event listeners assert_equals: expected 1 but got 0
OK /css/cssom-view/MediaQueryListEvent.html (#25275)
- FAIL [expected PASS] subtest: argument of onchange assert_true: expected true got false
OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
- FAIL [expected PASS] subtest: Smooth scrolling while doing history navigation. assert_not_equals: Shouldn't be scrolled to top anymore. got disallowed value 0
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent) Test timed out
TIMEOUT /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Cross-site, no attributes promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
- FAIL [expected NOTRUN] subtest: sec-fetch-site - Same site, no attributes promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-site - Same-Origin -> Cross-Site -> Same-Origin redirect, no attributes Test timed out
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
- PASS [expected FAIL] subtest: <a> tag navigate fails for unparseable URLs
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: Basic test (formdata event)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in name (normal form)
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 6515456 but got 6515712
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe Test timed out
OK /workers/dedicated-worker-from-blob-url.window.html (#22286)
- PASS [expected FAIL] subtest: Creating a dedicated worker from a blob URL works immediately before revoking.

Stable unexpected results that are known to be intermittent (13)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '400' should prefer '351 398' over '501 550' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '500' over '400 425'
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '501 550' over '502 560' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '450 460' over '400' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '400' over '350 399' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '450 460' over '500 501'
- FAIL [expected PASS] subtest: Matching font-stretch: '100%' should prefer '100%' over '110% 120%' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 10deg 40deg' over 'oblique 20deg 30deg' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 20deg 30deg' over 'oblique -50deg -20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- And 10 more unexpected results...
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- TIMEOUT [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes Test timed out
- NOTRUN [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes
- NOTRUN [expected TIMEOUT] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Host element with delegatesFocus should support autofocus promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Area element should support autofocus promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: DOMParser
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- FAIL [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document assert_equals: expected "/html/webappapis/scripting/events/resources/open-window.html" but got "blank"
ERROR /resource-timing/content-type-parsing.html (#29131)
- TIMEOUT [expected FAIL] subtest: mime-type 16 : text/html;charset=�gbk Test timed out
- NOTRUN [expected TIMEOUT] subtest: mime-type 17 : text/html;charset=gbk
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out
OK [expected ERROR] /workers/baseurl/alpha/import-in-moduleworker.html (#21315)
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

github-actions · 2024-02-09T15:14:13Z

✨ Try run (#7845146670) succeeded.

…ues (servo#31299) For example, style.cssText = "margin: 1px 2px 3px 4px"; [...style]; will now be ["margin-top", "margin-right", "margin-bottom", "margin-left"] instead of ["1px", "2px", "3px", "4px"]

Loirooriol added the T-full Do a full try run label Feb 9, 2024

github-actions bot removed the T-full Do a full try run label Feb 9, 2024

Loirooriol mentioned this pull request Feb 9, 2024

layout: Respond to shorthand property requests with real values #31277

Merged

4 tasks

Fix CSSStyleDeclaration's item() to provide properties instead of values

2c7e098

For example, style.cssText = "margin: 1px 2px 3px 4px"; [...style]; will now be ["margin-top", "margin-right", "margin-bottom", "margin-left"] instead of ["1px", "2px", "3px", "4px"]

Loirooriol force-pushed the cssstyledeclaration-item branch from 323a83d to 2c7e098 Compare February 9, 2024 14:09

mrobinson approved these changes Feb 9, 2024

View reviewed changes

Loirooriol added the T-full Do a full try run label Feb 9, 2024

github-actions bot removed the T-full Do a full try run label Feb 9, 2024

Loirooriol added this pull request to the merge queue Feb 9, 2024

Merged via the queue into servo:main with commit f2adcc3 Feb 9, 2024

Loirooriol deleted the cssstyledeclaration-item branch February 9, 2024 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix CSSStyleDeclaration's item() to provide properties instead of values#31299

Fix CSSStyleDeclaration's item() to provide properties instead of values#31299
Loirooriol merged 1 commit intoservo:mainfrom
Loirooriol:cssstyledeclaration-item

Loirooriol commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Loirooriol commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

github-actions bot commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants