<hr> elements are expected to have a default overflow:hidden#31297
Merged
Loirooriol merged 3 commits intoservo:mainfrom Feb 10, 2024
Merged
<hr> elements are expected to have a default overflow:hidden#31297Loirooriol merged 3 commits intoservo:mainfrom
Loirooriol merged 3 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#7840633245) for Linux WPT layout-2020 |
|
Test results for linux-wpt-layout-2020 from try job (#7840633245): Flaky unexpected result (10)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (1)
|
|
|
mrobinson
requested changes
Feb 9, 2024
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
This is a nice change, but while fixing this would it be possible to update <hr> to use the full set of style defined at https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2:
hr {
color: gray;
border-style: inset;
border-width: 1px;
margin-block-start: 0.5em;
margin-inline-end: auto;
margin-block-end: 0.5em;
margin-inline-start: auto;
overflow: hidden;
}
See whatwg/html#2724 Signed-off-by: Sebastian C <[email protected]>
Signed-off-by: Sebastian C <[email protected]>
sebsebmc
force-pushed
the
hr-elem-ua-style-overflow
branch
from
fa17cf2 to
b124d8e
Compare
|
🔨 Triggering try run (#7848928684) for Linux WPT layout-2020 |
|
Test results for linux-wpt-layout-2020 from try job (#7848928684): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (18)
|
|
✨ Try run (#7848928684) succeeded. |
mrobinson
approved these changes
Feb 9, 2024
4 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
The test is also passing on legacy layout, you need to remove |
Signed-off-by: Sebastian C <[email protected]>
Taym95
pushed a commit
to Taym95/servo
that referenced
this pull request
Feb 11, 2024
…1297) * <hr> elements are expected to have a default overflow:hidden See whatwg/html#2724 Signed-off-by: Sebastian C <[email protected]> * Use full defined hr style Signed-off-by: Sebastian C <[email protected]> * update legacy test expectation Signed-off-by: Sebastian C <[email protected]> --------- Signed-off-by: Sebastian C <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See whatwg/html#2724
This adds the required styling to the UA stylesheet.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsI'm not sure why the WPT test /html/rendering/non-replaced-elements/the-hr-element-0/hr.html currently passes, but while fixing #22838 the test started failing. Once both these land the test should be passing again.