Implement HTMLImageElement decode#31269
Merged
gterzian merged 23 commits intoservo:mainfrom Jun 13, 2024
Merged
Conversation
|
🔨 Triggering try run (#8093180833) for Linux WPT layout-2020 |
|
Test results for linux-wpt-layout-2020 from try job (#8093180833): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (7)
|
|
|
Collaborator
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
Member
|
@Taym95 Do you mind taking a look at the failing tests? It seems that this change introduces some failure and timeouts. |
Member
Author
I pushed another commit after last |
|
🔨 Triggering try run (#8111488522) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#8111488522): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (4)
|
|
|
gterzian
requested changes
Mar 4, 2024
Member
gterzian
left a comment
gterzian
left a comment
There was a problem hiding this comment.
Great start! Some pointers for the next step. Note that this is actually simpler than what I wrote in the initial issue...
Member
|
@Taym95 Any updates on this one? Is there some way that I can help you get this ready for review again? |
Member
Author
Sorry, @mrobinson, I was busy in previous weeks. I will continue working on this this week. |
Taym95
force-pushed
the
Implement-HTMLImageElement-decode
branch
2 times, most recently
from
c1df1b6 to
d3f2d8b
Compare
Member
Author
@mrobinson Can you run |
|
🔨 Triggering try run (#9348660545) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#9348660545): Flaky unexpected result (7)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (4)
|
|
Test results for linux-wpt-layout-2020 from try job (#9348660545): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (4)
|
|
🔨 Triggering try run (#9464494120) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#9464494120): Flaky unexpected result (10)
Stable unexpected results that are known to be intermittent (15)
|
|
✨ Try run (#9464494120) succeeded. |
Signed-off-by: Bentaimia Haddadi <[email protected]>
Signed-off-by: Bentaimia Haddadi <[email protected]>
|
🔨 Triggering try run (#9470224661) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#9470224661): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (9)
Stable unexpected results (3)
|
|
|
gterzian
requested changes
Jun 11, 2024
| // Step 2 for <https://html.spec.whatwg.org/multipage/#dom-img-decode> | ||
| fn react_to_decode_image_sync_steps(&self) { | ||
| fn react_to_decode_image_sync_steps(&self, promise: Rc<Promise>) { | ||
| self.image_decode_promises |
Member
There was a problem hiding this comment.
What I meant is that we should only resolve or reject this particular promise here, and if neither happens, at the end of the function store it into this.
Member
|
Note also there is a discussion ongoing about the potential race condition I mentioned, at whatwg/html#4217. |
This reverts commit eee6096.
Signed-off-by: Bentaimia Haddadi <[email protected]>
Collaborator
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
gterzian
approved these changes
Jun 12, 2024
| &document.global(), | ||
| DOMErrorName::EncodingError, | ||
| )); | ||
| } else if matches!( |
Member
There was a problem hiding this comment.
Here I would add a comment that this does not follow the spec, but it is discussed at whatwg/html#4217
…ailable Signed-off-by: Bentaimia Haddadi <[email protected]>
Collaborator
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
Member
|
Thank you, great work! @Taym95 |
tharkum
added a commit
to tharkum/servo
that referenced
this pull request
Oct 2, 2025
The legacy <image> constructor (new Image()) doesn't have any step in specification which require to run `update the image data` algorithm. See https://html.spec.whatwg.org/multipage/#dom-image This non-conformant behavior was added in the PR servo#31269 to follow https://html.spec.whatwg.org/multipage/#when-to-obtain-images (.. whenever that element is created or has experienced relevant mutations) to handle the edge case of 'decode()' with <image> without "src" and "srcset" attributes. See html/semantics/embedded-content/the-img-element/decode/image-decode.html#L87 Testing: No changes in test expectations Signed-off-by: Andrei Volykhin <[email protected]>
tharkum
added a commit
to tharkum/servo
that referenced
this pull request
Oct 2, 2025
The legacy 'image' constructor (new Image()) doesn't have any step in specification which require to run `update the image data` algorithm. See https://html.spec.whatwg.org/multipage/#dom-image This non-conformant behavior was added in the PR servo#31269 to follow https://html.spec.whatwg.org/multipage/#when-to-obtain-images (.. whenever that element is created or has experienced relevant mutations) to handle the edge case of `decode()` with 'image' without "src" and "srcset" attributes. See html/semantics/embedded-content/the-img-element/decode/image-decode.html#L87 Testing: No changes in test expectations Signed-off-by: Andrei Volykhin <[email protected]>
tharkum
added a commit
to tharkum/servo
that referenced
this pull request
Oct 8, 2025
The legacy 'image' constructor (new Image()) doesn't have any step in specification which require to run `update the image data` algorithm. See https://html.spec.whatwg.org/multipage/#dom-image This non-conformant behavior was added in the PR servo#31269 to follow https://html.spec.whatwg.org/multipage/#when-to-obtain-images (.. whenever that element is created or has experienced relevant mutations) to handle the edge case of `decode()` with 'image' without "src" and "srcset" attributes. See html/semantics/embedded-content/the-img-element/decode/image-decode.html#L87 Testing: No changes in test expectations Signed-off-by: Andrei Volykhin <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
…39635) The legacy 'image' constructor (new Image()) doesn't have any step in specification which require to run `update the image data` algorithm. See https://html.spec.whatwg.org/multipage/#dom-image This non-conformant behavior was added in the PR #31269 to follow https://html.spec.whatwg.org/multipage/#when-to-obtain-images (.. whenever that element is created or has experienced relevant mutations) to handle the edge case of `decode()` with 'image' without "src" and "srcset" attributes. See html/semantics/embedded-content/the-img-element/decode/image-decode.html#L87 Testing: No changes in test expectations Signed-off-by: Andrei Volykhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors