Skip to content

Backport several style changes from Gecko (11)#30770

Merged
mrobinson merged 90 commits intoservo:masterfrom
Loirooriol:sync-11
Nov 24, 2023
Merged

Backport several style changes from Gecko (11)#30770
mrobinson merged 90 commits intoservo:masterfrom
Loirooriol:sync-11

Conversation

@Loirooriol
Copy link
Copy Markdown
Contributor

@Loirooriol Loirooriol commented Nov 22, 2023

This continues #30748.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

/_mozilla/gfx-rs-gecko/356774-1.html is now failing in legacy, but previously it was already wrong because both the test and the reference were supposed to show a border but they didn't. Now they do show a border, but the contents are shifted by 1px depending on border-collapse.

@Loirooriol Loirooriol added the T-full Do a full try run label Nov 22, 2023
@github-actions
Copy link
Copy Markdown

🔨 Triggering try run (#6963615222) with platforms=linux,macos,windows and layout=all

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#43316) with upstreamable changes.

@github-actions
Copy link
Copy Markdown

Test results for linux-wpt-layout-2013 from try job (#6963615222):

Flaky unexpected result (15)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
    • FAIL [expected PASS] subtest: [data-expected-height] 1 assert_equals:
      <inline-block data-expected-height="10">123 <span style="margin-left: -8ch">1234 </span></inline-block>
      height expected 10 but got 20
    • FAIL [expected PASS] subtest: [data-expected-height] 2 assert_equals:
      <inline-block data-expected-height="10">123 <span style="margin-left: -8ch">123 </span></inline-block>
      height expected 10 but got 20
    • PASS [expected FAIL] subtest: [data-expected-height] 4
  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • PASS [expected FAIL] subtest: listeners are called correct number of times
    • FAIL [expected PASS] subtest: listener that was added twice is called only once assert_equals: expected 1 but got 0
  • OK /css/cssom/HTMLLinkElement-load-event-002.html
    • PASS [expected FAIL] subtest: Load event doesn't fire on removed link
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
    • PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
  • PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
  • CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
    • FAIL [expected PASS] subtest: createHTMLDocument assert_unreached: got unexpected error event Reached unreachable code
    • FAIL [expected PASS] subtest: <template> assert_unreached: got unexpected error event Reached unreachable code
  • OK /html/semantics/forms/historical.html (#28568)
    • PASS [expected FAIL] subtest: <input name=isindex> should not be supported
  • TIMEOUT [expected OK] /wasm/jsapi/functions/entry.html (#27087)
    • TIMEOUT [expected FAIL] subtest: Start function Test timed out
  • OK [expected TIMEOUT] /webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active.html (#27664)
  • OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
  • OK /xhr/xhr-timeout-longtask.any.worker.html (#27663)
    • FAIL [expected PASS] subtest: Long tasks should not trigger load timeout assert_unreached: [object ProgressEvent] Reached unreachable code
Stable unexpected results that are known to be intermittent (13)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
    • PASS [expected FAIL] subtest: listeners for "change" type are called
  • OK /css/cssom-view/offsetTopLeft-border-box.html (#24237)
    • PASS [expected FAIL] subtest: container: 0
    • PASS [expected FAIL] subtest: container: 1
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation. assert_equals: Shouldn't be scrolled back to top yet. expected 0 but got 18631
    • FAIL [expected PASS] subtest: Smooth scrolling while doing history navigation. assert_not_equals: Shouldn't be scrolled to top anymore. got disallowed value 0
  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • PASS [expected TIMEOUT] subtest: background-image sec-fetch-user - Not sent to non-trustworthy same-site destination
  • OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
    • FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked assert_equals: expected "A" but got ""
    • FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked assert_equals: expected "�ÿ" but got ""
    • FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked assert_equals: expected "�ÿĀ" but got ""
    • FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked assert_equals: expected "😍" but got ""
    • FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked assert_equals: expected "\ufffdA" but got ""
  • OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
  • OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
    • FAIL [expected PASS] subtest: text/plain: Basic File test (formdata event) assert_equals: expected "basic=file-test.txt\r\n" but got ""
    • FAIL [expected PASS] subtest: text/plain: 0x00 in filename (formdata event) assert_equals: expected "a=b\0c\r\n" but got ""
  • OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
    • FAIL [expected PASS] subtest: application/x-www-form-urlencoded: double quote in filename (formdata event) assert_equals: expected "a=b%22c" but got ""
  • ERROR [expected OK] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
  • OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
    • PASS [expected FAIL] subtest: document.write in an imported module
  • TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
    • PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
  • ERROR /resource-timing/content-type-parsing.html (#29131)
    • TIMEOUT [expected FAIL] subtest: mime-type 16 : text/html;charset=�gbk Test timed out
    • NOTRUN [expected TIMEOUT] subtest: mime-type 17 : text/html;charset= gbk
Stable unexpected results (26)
  • FAIL [expected PASS] /_mozilla/gfx-rs-gecko/356774-1.html
  • PASS [expected FAIL] /css/CSS2/cascade/inherit-computed-001.html
  • CRASH [expected PASS] /css/CSS2/generated-content/content-096.xht
  • FAIL [expected PASS] /css/CSS2/selectors/attribute-token-selector-002.xht
  • PASS [expected FAIL] /css/css-backgrounds/border-width-pixel-snapping-001-a.html
  • PASS [expected FAIL] /css/css-backgrounds/border-width-small-values-001-a.html
  • PASS [expected FAIL] /css/css-backgrounds/border-width-small-values-001-b.html
  • PASS [expected FAIL] /css/css-borders/subpixel-border-width.tentative.html
  • PASS [expected FAIL] /css/css-borders/subpixel-borders-with-child-border-box-sizing.html
  • PASS [expected FAIL] /css/css-borders/subpixel-borders-with-child.html
  • OK /css/css-flexbox/parsing/flex-flow-valid.html
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "column nowrap" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "nowrap column" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "nowrap" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "row nowrap" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "wrap" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "row wrap" should set the property value
  • PASS [expected FAIL] /css/css-outline/subpixel-outline-width.tentative.html
  • PASS [expected FAIL] /css/css-text/letter-spacing/letter-spacing-205.html
  • FAIL [expected PASS] /css/css-text/line-breaking/line-breaking-015.html
  • OK /css/css-ui/parsing/outline-width-computed.html
    • PASS [expected FAIL] subtest: Property outline-width value '2.5px'
  • OK /css/cssom/shorthand-values.html
    • PASS [expected FAIL] subtest: The serialization of border: 1px; border-top: 1px; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: 1px red; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: red; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border-top: 1px; border-right: 1px; border-bottom: 1px; border-left: 1px; border-image: none; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border-top: 1px; border-right: 1px; border-bottom: 1px; border-left: 1px; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border-top: 1px; border-right: 2px; border-bottom: 3px; border-left: 4px; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: 1px; border-top: 2px; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: 1px; border-top: 1px !important; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: 1px; border-top-color: red; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: solid; border-style: dotted should be canonical.
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184a.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184b.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184c.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184d.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184e.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184f.xml
  • OK /dom/nodes/ParentNode-querySelector-All-xht.xht
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should not match anything. expected null but got Element node <div id="attr-whitespace-div2" class=""></div>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute begins with selector, not matching class attribute with empty value: #attr-begins [class^=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute begins with selector, not matching class attribute with empty value: #attr-begins [class^=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-begins-p1" class=" apple"></p>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute ends with selector, not matching class attribute with empty value: #attr-ends [class$=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute ends with selector, not matching class attribute with empty value: #attr-ends [class$=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-ends-p1" class="apple "></p>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute contains selector, not matching class attribute with empty value: #attr-contains [class*=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute contains selector, not matching class attribute with empty value: #attr-contains [class*=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-contains-p1" class=" apple banana orange "></p>
    • FAIL [expected PASS] subtest: Detached Element.querySelectorAll: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Detached Element.querySelector: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should not match anything. expected null but got Element node <div id="attr-whitespace-div2" class=""></div>
    • And 22 more unexpected results...
  • OK /dom/nodes/ParentNode-querySelector-All.html
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should not match anything. expected null but got Element node <div id="attr-whitespace-div2" class=""></div>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute begins with selector, not matching class attribute with empty value: #attr-begins [class^=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute begins with selector, not matching class attribute with empty value: #attr-begins [class^=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-begins-p1" class=" apple"></p>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute ends with selector, not matching class attribute with empty value: #attr-ends [class$=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute ends with selector, not matching class attribute with empty value: #attr-ends [class$=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-ends-p1" class="apple "></p>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute contains selector, not matching class attribute with empty value: #attr-contains [class*=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute contains selector, not matching class attribute with empty value: #attr-contains [class*=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-contains-p1" class=" apple banana orange "></p>
    • FAIL [expected PASS] subtest: Detached Element.querySelectorAll: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Detached Element.querySelector: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should not match anything. expected null but got Element node <div id="attr-whitespace-div2" class=""></div>
    • And 22 more unexpected results...
  • CRASH [expected OK] /html/semantics/selectors/pseudo-classes/enabled.html
  • CRASH [expected OK] /html/semantics/selectors/pseudo-classes/link.html

@github-actions
Copy link
Copy Markdown

Test results for linux-wpt-layout-2020 from try job (#6963615222):

Flaky unexpected result (21)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
    • FAIL [expected PASS] subtest: onchange adds listener promise_test: Unhandled rejection with value: object "TypeError: _event is undefined"
  • CRASH [expected OK] /encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBa.html?6001-7000
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • PASS [expected FAIL] subtest: Navigating to a different document with link click
  • OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
    • PASS [expected FAIL] subtest: 0041 set in href="" targeting a frame and clicked
    • PASS [expected FAIL] subtest: 0080 00FF set in href="" targeting a frame and clicked
    • PASS [expected FAIL] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
    • PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored assert_equals: expected "?pass" but got "?fail"
  • OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
  • OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
  • CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
  • OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
    • FAIL [expected PASS] subtest: createHTMLDocument assert_unreached: got unexpected error event Reached unreachable code
    • FAIL [expected PASS] subtest: <template> assert_unreached: got unexpected error event Reached unreachable code
  • OK /html/semantics/forms/historical.html (#28568)
    • PASS [expected FAIL] subtest: <input name=isindex> should not be supported
  • ERROR [expected OK] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
  • OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)
  • OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
    • PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
  • OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
    • FAIL [expected PASS] subtest: document.write in an imported module assert_true: onload must be called expected true got false
  • CRASH [expected PASS] /streams/readable-streams/crashtests/strategy-worker-terminate.html (#30124)
  • TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
  • TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
  • OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
    • PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
Stable unexpected results that are known to be intermittent (12)
Stable unexpected results (22)
  • CRASH [expected PASS] /css/CSS2/generated-content/content-096.xht
  • FAIL [expected PASS] /css/CSS2/selectors/attribute-token-selector-002.xht
  • PASS [expected FAIL] /css/css-backgrounds/border-width-pixel-snapping-001-a.html
  • PASS [expected FAIL] /css/css-backgrounds/border-width-small-values-001-a.html
  • PASS [expected FAIL] /css/css-backgrounds/border-width-small-values-001-b.html
  • PASS [expected FAIL] /css/css-borders/subpixel-border-width.tentative.html
  • PASS [expected FAIL] /css/css-borders/subpixel-borders-with-child-border-box-sizing.html
  • PASS [expected FAIL] /css/css-borders/subpixel-borders-with-child.html
  • OK /css/css-flexbox/parsing/flex-flow-valid.html
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "column nowrap" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "nowrap column" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "nowrap" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "row nowrap" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "wrap" should set the property value
    • PASS [expected FAIL] subtest: e.style['flex-flow'] = "row wrap" should set the property value
  • PASS [expected FAIL] /css/css-outline/subpixel-outline-width.tentative.html
  • OK /css/css-ui/parsing/outline-width-computed.html
    • PASS [expected FAIL] subtest: Property outline-width value '2.5px'
  • OK /css/cssom/shorthand-values.html
    • PASS [expected FAIL] subtest: The serialization of border: 1px; border-top: 1px; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: 1px red; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: red; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border-top: 1px; border-right: 1px; border-bottom: 1px; border-left: 1px; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border-top: 1px; border-right: 2px; border-bottom: 3px; border-left: 4px; should be canonical.
    • PASS [expected FAIL] subtest: The serialization of border: solid; border-style: dotted should be canonical.
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184a.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184b.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184c.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184d.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184e.xml
  • FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184f.xml
  • OK /dom/nodes/ParentNode-querySelector-All-xht.xht
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should not match anything. expected null but got Element node <div id="attr-whitespace-div2" class=""></div>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute begins with selector, not matching class attribute with empty value: #attr-begins [class^=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute begins with selector, not matching class attribute with empty value: #attr-begins [class^=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-begins-p1" class=" apple"></p>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute ends with selector, not matching class attribute with empty value: #attr-ends [class$=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute ends with selector, not matching class attribute with empty value: #attr-ends [class$=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-ends-p1" class="apple "></p>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute contains selector, not matching class attribute with empty value: #attr-contains [class*=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute contains selector, not matching class attribute with empty value: #attr-contains [class*=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-contains-p1" class=" apple banana orange "></p>
    • FAIL [expected PASS] subtest: Detached Element.querySelectorAll: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Detached Element.querySelector: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should not match anything. expected null but got Element node <div id="attr-whitespace-div2" class=""></div>
    • And 22 more unexpected results...
  • OK /dom/nodes/ParentNode-querySelector-All.html
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should not match anything. expected null but got Element node <div id="attr-whitespace-div2" class=""></div>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute begins with selector, not matching class attribute with empty value: #attr-begins [class^=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute begins with selector, not matching class attribute with empty value: #attr-begins [class^=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-begins-p1" class=" apple"></p>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute ends with selector, not matching class attribute with empty value: #attr-ends [class$=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute ends with selector, not matching class attribute with empty value: #attr-ends [class$=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-ends-p1" class="apple "></p>
    • FAIL [expected PASS] subtest: Document.querySelectorAll: Attribute contains selector, not matching class attribute with empty value: #attr-contains [class*=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Document.querySelector: Attribute contains selector, not matching class attribute with empty value: #attr-contains [class*=""] assert_equals: The method should not match anything. expected null but got Element node <p id="attr-contains-p1" class=" apple banana orange "></p>
    • FAIL [expected PASS] subtest: Detached Element.querySelectorAll: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should return the expected number of matches. expected 0 but got 1
    • FAIL [expected PASS] subtest: Detached Element.querySelector: Attribute whitespace-separated list selector, not matching class attribute with empty value: #attr-whitespace [class~=""] assert_equals: The method should not match anything. expected null but got Element node <div id="attr-whitespace-div2" class=""></div>
    • And 22 more unexpected results...
  • CRASH [expected OK] /html/semantics/selectors/pseudo-classes/enabled.html
  • CRASH [expected OK] /html/semantics/selectors/pseudo-classes/link.html

@github-actions
Copy link
Copy Markdown

⚠️ Try run (#6963615222) failed.

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

tiaanl and others added 20 commits November 23, 2023 18:36
Avoid trying to resolve a currentcolor when a foreground color is not
available.

Differential Revision: https://phabricator.services.mozilla.com/D177368
See blocked bug.

For non-Locked types we can just use the same underlying type at the FFI
boundary. Port StylesheetContents and CssUrlData to this set-up.
CssUrlData is already generated by cbindgen anyways.

Differential Revision: https://phabricator.services.mozilla.com/D177559
No behavior change, but using Self is shorter and while I'm touching
this code might as well clean it up a little bit.

Differential Revision: https://phabricator.services.mozilla.com/D177732
Much like with font-relative units, when they're used for a
non-inherited property we need to avoid using the rule cache.

This is because two elements matching the same rules won't get
guaranteed-equal non-inherited style structs.

Depends on D177732

Differential Revision: https://phabricator.services.mozilla.com/D177733
That's how we do it for all other platforms. Do this rather than via a
custom mostly-untested pref, which allows us to simplify text zoom
handling.

Differential Revision: https://phabricator.services.mozilla.com/D177062
Use the actual Locked<T> types around (via a typedef, just for
convenience).

Differential Revision: https://phabricator.services.mozilla.com/D177824
This simplifies a tiny bit our bindings in some places, and complicates
it in others, but over all I think it's better.

It requires a bit more manual code in the rust side to drop and cast the
relevant pointers (which was done implicitly before), but it's a lot
less magic than it used to be, and that's all autogenerated so consumers
don't need to care about it.

The set up is still not ideal. I don't like that we rely on destructors
running in both sides of the FFI boundary, but that's for another day.

This is the last usage of RawOffsetArc, so remove that. We now support
proper Arc<> in structs (GridTemplateAreas uses it), so I don't think
we'll need it any time soon.

Differential Revision: https://phabricator.services.mozilla.com/D177905
Unlike the `ParseRelative` flag, which turns on relative selector parsing for
that parsing level only, the newly added `DISALLOW_RELATIVE_SELECTOR` flag
propagates through nested parsing calls.

Differential Revision: https://phabricator.services.mozilla.com/D176807
So that they aren't imported via #[path]. This allows cargo to see them
even before building.

Differential Revision: https://phabricator.services.mozilla.com/D178105
This changes the cssparser setup to:

  * Avoid having to do copies of the ParsingContext all over the place,
    which is useful because I plan to stash more nesting state in there.

  * Use the new RuleBodyParser which allows parsing qualified rules,
    declarations, and so on. Though we still don't use this anywhere.

The next step is to join NestedRuleParser and PropertyDeclarationParser,
so that we can parse declarations in a lot of the nested rules as well.

Differential Revision: https://phabricator.services.mozilla.com/D178053
@Loirooriol Loirooriol requested a review from mrobinson November 23, 2023 18:48
Loirooriol and others added 21 commits November 23, 2023 20:06
Introduce LineWidth (which doesn't snap) and let BorderSideWidth
wrap it and actually do the snapping.

Differential Revision: https://phabricator.services.mozilla.com/D180688
…properties

The CSS properties in the list are all shipped. Since we still don't support use
counter for developing CSS properties since this bug opens, I assume this
feature is not critical. Hence the removal of the comment.

Differential Revision: https://phabricator.services.mozilla.com/D180771
At least when the containers are different.

For now check that by doing a somewhat simplified test (checking
sibling-ness).

The new flag can be useful to optimize container query restyles on
resizes too, in the future.

Differential Revision: https://phabricator.services.mozilla.com/D179268
Layer insertion may change the order of styles, so we may need to fully
invalidate.

Without this change, bug 1838045 makes
layer-statement-before-import.html fail.

Differential Revision: https://phabricator.services.mozilla.com/D180929
The only reason we pass the quirks mode around is to compute the case
sensitivity, but we can just pass the later.

Differential Revision: https://phabricator.services.mozilla.com/D180527
It's an extra branch which in practice we almost never take, plus extra
checks during parsing.

Differential Revision: https://phabricator.services.mozilla.com/D180529
Inline the attribute lookup code, and only branch on the attribute selector
type if we have found an attribute.

Differential Revision: https://phabricator.services.mozilla.com/D180531
@Loirooriol
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.