Backport several style changes from Gecko (10)#30748
Merged
mrobinson merged 85 commits intoservo:masterfrom Nov 21, 2023
Merged
Backport several style changes from Gecko (10)#30748mrobinson merged 85 commits intoservo:masterfrom
mrobinson merged 85 commits intoservo:masterfrom
Conversation
|
🔨 Triggering try run (#6908223156) with platforms=linux,macos,windows and layout=all |
|
Test results for linux-wpt-layout-2013 from try job (#6908223156): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (130)
|
|
Test results for linux-wpt-layout-2020 from try job (#6908223156): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (57)
|
|
|
|
🔨 Triggering try run (#6909690372) with platforms=linux,macos,windows and layout=all |
Contributor
Author
|
So I was treating the |
|
Test results for linux-wpt-layout-2013 from try job (#6909690372): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (11)
Stable unexpected results (228)
|
|
Test results for linux-wpt-layout-2020 from try job (#6909690372): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (20)
Stable unexpected results (155)
|
|
|
|
🔨 Triggering try run (#6910715158) with platforms=linux,macos,windows and layout=all |
|
Test results for linux-wpt-layout-2020 from try job (#6910715158): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (19)
Stable unexpected results (119)
|
|
|
|
🔨 Triggering try run (#6911063921) with platforms=linux,macos,windows and layout=all |
|
Test results for linux-wpt-layout-2020 from try job (#6911063921): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (114)
|
|
|
|
🔨 Triggering try run (#6916672474) with platforms=linux,macos,windows and layout=all |
|
Test results for linux-wpt-layout-2013 from try job (#6916672474): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (112)
|
More nesting plumbing. Still does nothing because we don't parse the
nested rules.
Should be trivial to prove this patch doesn't change any behavior so
far, but I want to land it on its own because it can have performance
implications.
This follows the pattern of what we do with other rules like layers and
container conditions, that is, keep the ancestor selectors in a stack,
and poke at the last one in order to replace the ancestor.
This changes the behavior of replace_parent_selector as with the newer
version of the spec, stuff like:
div {
.foo {
stuff
}
}
Should work as `div .foo`. A test is added for this case.
Differential Revision: https://phabricator.services.mozilla.com/D176560
…s along with declaration No implementation just yet (the default QualifiedRuleParser implementation just rejects stuff), but this is plumbing that I'd rather get reviewed separately. Differential Revision: https://phabricator.services.mozilla.com/D176686
NaN and infinity percentages are now serialized as expected. Also added some new WPT tests as percentages were previously untested and added some spec comments to previous NaN/inf serialization code. Differential Revision: https://phabricator.services.mozilla.com/D176726
Refactored ImportLayer into an enum instead of a struct and using Option everywhere. Differential Revision: https://phabricator.services.mozilla.com/D176793
Although we store animation and transition style values in StyleUIReset and define their properties in longhands/ui.mako.rs, but we may move them in the future if this style struct becomes too large. So let's move the definition of their values to an independent module, animation, so we don't have to worry about this again. This patch doesn't change any other things. Only move code. Differential Revision: https://phabricator.services.mozilla.com/D173903
Support view() notation for animation-timeline:
`<view()> = view( [ <axis> || <'view-timeline-inset'> ]? )`
We move AnimationTimeline and its related types into the generics folder,
and define two new structs for scroll() and view().
Note:
1. The syntax of scroll() doesn't match the current version of the spec.
I will update it in Bug 1814444.
2. We will handle the creation/usage of the Anonymous View Progress Timelines
in the next patch.
Differential Revision: https://phabricator.services.mozilla.com/D173904
Sum nodes would use mul_by to negate nodes to do subtraction, but some nodes are not distributive. This patch adds a negate node, so that the operations inside these negate nodes can be resolved first and then the "subtraction" can be applied. Differential Revision: https://phabricator.services.mozilla.com/D172941
…size separately And use it instead of explicit document checks. This centralizes where we check for it. IsChromeDoc is relatively cheap, but this bug wants to also check for PDF.js which is a bit more expensive. No behavior change. Differential Revision: https://phabricator.services.mozilla.com/D176940
…in any order The order of <scroller> and <axis> doesn't matter in the parser. However, we serialize <scroller> first, if it is not the initial value. Differential Revision: https://phabricator.services.mozilla.com/D173906
`self` keyword specifies to use the element’s own principal box as the scroll container. If the principal box is not a scroll container, then the scroll progress timeline is inactive. Differential Revision: https://phabricator.services.mozilla.com/D175707
…ghtmost This restores the pre-regression behavior by choosing the later class in cases where folks use stuff like `.foo.bar`. This matches other browsers too. Differential Revision: https://phabricator.services.mozilla.com/D177398
HasBoxFFI and HasArcFFI aren't great, see bug 1831242 as for examples of why. HasArcFFI requires a bit more care, but HasBoxFFI doesn't give us much benefit. Instead use the same type in the FFI boundary. Differential Revision: https://phabricator.services.mozilla.com/D177252
It's completely unsused and we don't want to use it any time soon, see bug 1831539 and related. Differential Revision: https://phabricator.services.mozilla.com/D177497
After the previous patches we only have one trait which we should also tweak / rework, so let's put it all on that single trait. Differential Revision: https://phabricator.services.mozilla.com/D177515
mrobinson
approved these changes
Nov 21, 2023
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Nice. These are really coming along.
Member
|
I will land this one the merge queue is empty. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #30692.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors