Create and use attribute getter macros#3073
Merged
Manishearth merged 3 commits intoservo:masterfrom Aug 20, 2014
Merged
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/2331 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Manishearth
force-pushed
the
macro-getters
branch
from
993f411 to
8dca3dd
Compare
Manishearth
force-pushed
the
macro-getters
branch
from
8dca3dd to
0c74348
Compare
Manishearth
added a commit
that referenced
this pull request
Aug 20, 2014
Create and use attribute getter macros; r=Ms2ger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1931
I'll open a separate PR to use these macros elsewhere once this merges.