Skip to content

Use spec compliant content-type extraction in more places and enable a <stylesheet> quirk#28321

Merged
mrobinson merged 1 commit intoservo:mainfrom
ghostd:fix-contenttype
May 19, 2025
Merged

Use spec compliant content-type extraction in more places and enable a <stylesheet> quirk#28321
mrobinson merged 1 commit intoservo:mainfrom
ghostd:fix-contenttype

Conversation

@ghostd
Copy link
Copy Markdown
Contributor

@ghostd ghostd commented Mar 31, 2021 •
edited by mrobinson
Loading

This changes includes two semi-related things:

  1. Fixes some specification compliance issues when parsing mime
    types and charsets for XMLHttpRequest.
  2. Implements a <stylesheet> parsing quirk involving mime types.

Testing: There are tests for these changes.

@highfive
Copy link
Copy Markdown

highfive commented Mar 31, 2021

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml, components/script/dom/xmlhttprequest.rs, components/script/dom/headers.rs
  • @KiChjang: components/net/fetch/methods.rs, components/net/lib.rs, components/net_traits/header.rs, components/script/Cargo.toml, components/script/dom/xmlhttprequest.rs and 5 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 31, 2021
@jdm
Copy link
Copy Markdown
Member

jdm commented Mar 31, 2021 

error: unused import: `extract_mime_type`
  --> components/script/dom/xmlhttprequest.rs:58:26
   |
58 | use net_traits::header::{extract_mime_type, extract_mime_type_as_mime};
   |                          ^^^^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`

@ghostd ghostd force-pushed the fix-contenttype branch from f09fd17 to bd05f87 Compare April 3, 2021 09:04
@ghostd
Copy link
Copy Markdown
Contributor Author

ghostd commented Apr 3, 2021

I fixed warning issues

@jdm
Copy link
Copy Markdown
Member

jdm commented Apr 3, 2021

@bors-servo r+

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 3, 2021

📌 Commit bd05f87 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 3, 2021
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 3, 2021

⌛ Testing commit bd05f87 with merge db579c3...

bors-servo added a commit that referenced this pull request Apr 3, 2021
@bors-servo
Auto merge of #28321 - ghostd:fix-contenttype, r=jdm
db579c3 
Fix some Content-Type tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 3, 2021

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 3, 2021
@jdm
Copy link
Copy Markdown
Member

jdm commented Apr 3, 2021

Looks like the results from https://community-tc.services.mozilla.com/tasks/V0zbGTN_THaRLbhb3i1onA/runs/0/logs/public/filtered-wpt-errorsummary.log need to be updated. The mac ones are duplicates or can be ignored.

@ghostd ghostd force-pushed the fix-contenttype branch from bd05f87 to d0c3cea Compare April 5, 2021 15:49
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 5, 2021
@ghostd
Copy link
Copy Markdown
Contributor Author

ghostd commented Apr 5, 2021

I rebased and updated the test logs.

@CYBAI
Copy link
Copy Markdown
Member

CYBAI commented Apr 6, 2021

@bors-servo try

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 6, 2021

⌛ Trying commit d0c3cea with merge a8361cf...

bors-servo added a commit that referenced this pull request Apr 6, 2021
@bors-servo
Auto merge of #28321 - ghostd:fix-contenttype, r=<try>
a8361cf 
Fix some Content-Type tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 6, 2021

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 6, 2021
@CYBAI
Copy link
Copy Markdown
Member

CYBAI commented Apr 6, 2021

Seems some test expectations need to be updated 👀

Details 
4 unexpected results that are NOT known-intermittents:
  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-load-error-events.html:
  â”” PASS [expected FAIL] b'Load of non-CSS stylesheet'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-load-error-events.html:
  â”” PASS [expected FAIL] b'Import of non-CSS stylesheet'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-load-error-events.html:
  â”” PASS [expected FAIL] b'Import of import of non-CSS stylesheet'


  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with no Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, same-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, same-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with broken Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with no Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with no Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, cross-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with broken Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with broken Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with no Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, same-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, same-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with broken Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with no Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with no Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, cross-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with broken Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with broken Content-Type, cross-origin, and nosniff'


  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with no Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, same-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, same-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with broken Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with no Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with no Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, cross-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with broken Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with broken Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with no Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, same-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, same-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with broken Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with no Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with no Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, cross-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with broken Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with broken Content-Type, cross-origin, and nosniff'


  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with no Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with wrong Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, same-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with broken Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with no Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with no Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, cross-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with wrong Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using <link> with broken Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using <link> with broken Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with no Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with wrong Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, same-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with broken Content-Type, same-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with no Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with no Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, cross-origin, and no nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with wrong Content-Type, cross-origin, and nosniff'

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  │ FAIL [expected PASS] b'Stylesheet loading using @import with broken Content-Type, cross-origin, and no nosniff'
  └   → assert_unreached: load event should have fired Reached unreachable code

  â–¶ Unexpected subtest result in /html/semantics/document-metadata/the-link-element/link-style-error-quirks.html:
  â”” PASS [expected FAIL] b'Stylesheet loading using @import with broken Content-Type, cross-origin, and nosniff'

1 unexpected results that are NOT known-intermittents:
  ▶ OK [expected TIMEOUT] b'/html/semantics/document-metadata/the-style-element/style-error-01.html'
  ▶ Unexpected subtest result in /html/semantics/document-metadata/the-style-element/style-error-01.html:
  └ PASS [expected TIMEOUT] b'Should get an error event for a text/plain response.'

@ghostd ghostd force-pushed the fix-contenttype branch from d0c3cea to 6edd78e Compare April 8, 2021 19:33
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 8, 2021
@CYBAI
Copy link
Copy Markdown
Member

CYBAI commented Apr 12, 2021

@bors-servo try

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 12, 2021

⌛ Trying commit 6edd78e with merge 4f9cef7...

@mrobinson mrobinson requested a review from gterzian as a code owner January 14, 2025 15:49
@mrobinson mrobinson added T-linux-wpt Do a try run of the WPT and removed S-needs-rebase There are merge conflict errors. labels Jan 14, 2025
@github-actions github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 14, 2025

🔨 Triggering try run (#12771341700) for Linux WPT

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 14, 2025

Test results for linux-wpt-layout-2020 from try job (#12771341700):

Flaky unexpected result (17)
  • TIMEOUT [expected OK] /_webgl/conformance/reading/read-pixels-test.html
  • PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
  • OK /fetch/private-network-access/worker-blob-fetch.tentative.window.html (#30064)
    • PASS [expected FAIL] subtest: local https to local https: success.
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
    • PASS [expected FAIL] subtest: link click
    • PASS [expected FAIL] subtest: form submission
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • PASS [expected FAIL] subtest: Navigating to a different document with link click
  • OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)
    • FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

      assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

  • OK [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-colorSpaceConversion.html (#34151)
  • TIMEOUT [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-serializable.html (#34120)
  • FAIL [expected PASS] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
  • CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.html (#34117)
  • CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.worker.html (#30164)
  • TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
  • OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
    • PASS [expected FAIL] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
  • TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
  • OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
    • PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
  • OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
  • OK /xhr/open-url-multi-window-5.htm (#23360)
    • FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)

      assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw

Stable unexpected results that are known to be intermittent (11)
  • OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
    • FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed

      promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"

  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
  • OK /fetch/content-type/script.window.html (#23149)
    • PASS [expected FAIL] subtest: separate text/javascript;";charset=windows-1252
    • PASS [expected FAIL] subtest: separate x/x text/javascript
    • PASS [expected FAIL] subtest: combined x/x text/javascript
    • PASS [expected FAIL] subtest: separate x/x;charset=windows-1252 text/javascript
    • PASS [expected FAIL] subtest: combined x/x;charset=windows-1252 text/javascript
    • PASS [expected FAIL] subtest: separate text/javascript x/x
    • PASS [expected FAIL] subtest: combined text/javascript; charset=windows-1252 text/javascript
    • PASS [expected FAIL] subtest: separate text/javascript;" x/x
    • PASS [expected FAIL] subtest: combined text/javascript;" x/x
    • PASS [expected FAIL] subtest: combined text/javascript
    • And 9 more unexpected results...
  • OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
  • OK [expected ERROR] /fetch/nosniff/importscripts.html (#27144)
    • PASS [expected TIMEOUT] subtest: Test importScripts()
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
  • OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
    • PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
  • OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
    • PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in name (normal form)
  • OK /navigation-timing/test-navigation-type-reload.html (#33334)
    • PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd
  • ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)
Stable unexpected results (9)
  • OK /encoding/single-byte-decoder.window.html?XMLHttpRequest
    • FAIL [expected PASS] subtest: ISO-8859-2: iso_8859-2:1987 (XMLHttpRequest)

      assert_equals: ISO-8859-2:128 expected 128 but got 65533

    • FAIL [expected PASS] subtest: ISO-8859-3: iso_8859-3:1988 (XMLHttpRequest)

      assert_equals: ISO-8859-3:128 expected 128 but got 65533

    • FAIL [expected PASS] subtest: ISO-8859-4: iso_8859-4:1988 (XMLHttpRequest)

      assert_equals: ISO-8859-4:128 expected 128 but got 65533

    • FAIL [expected PASS] subtest: ISO-8859-5: iso_8859-5:1988 (XMLHttpRequest)

      assert_equals: ISO-8859-5:128 expected 128 but got 65533

    • FAIL [expected PASS] subtest: ISO-8859-6: iso_8859-6:1987 (XMLHttpRequest)

      assert_equals: ISO-8859-6:128 expected 128 but got 65533

    • FAIL [expected PASS] subtest: ISO-8859-7: iso_8859-7:1987 (XMLHttpRequest)

      assert_equals: ISO-8859-7:128 expected 128 but got 65533

    • FAIL [expected PASS] subtest: ISO-8859-8: iso_8859-8:1988 (XMLHttpRequest)

      assert_equals: ISO-8859-8:128 expected 128 but got 65533

    • FAIL [expected PASS] subtest: windows-1252: iso_8859-1:1987 (XMLHttpRequest)

      assert_equals: windows-1252:128 expected 8364 but got 65533

    • FAIL [expected PASS] subtest: windows-1254: iso_8859-9:1989 (XMLHttpRequest)

      assert_equals: windows-1254:128 expected 8364 but got 65533

  • OK /fetch/content-type/response.window.html
    • PASS [expected FAIL] subtest: &lt;iframe&gt;: separate response Content-Type: text/plain
    • PASS [expected FAIL] subtest: &lt;iframe&gt;: combined response Content-Type: text/plain
    • PASS [expected FAIL] subtest: fetch(): combined response Content-Type: text/plain
    • PASS [expected FAIL] subtest: &lt;iframe&gt;: combined response Content-Type: text/plain
    • PASS [expected FAIL] subtest: fetch(): combined response Content-Type: text/plain
    • PASS [expected FAIL] subtest: &lt;iframe&gt;: separate response Content-Type: text/html text/plain
    • PASS [expected FAIL] subtest: &lt;iframe&gt;: combined response Content-Type: text/html text/plain
    • PASS [expected FAIL] subtest: fetch(): combined response Content-Type: text/html text/plain
    • PASS [expected FAIL] subtest: &lt;iframe&gt;: separate response Content-Type: text/plain;charset=gbk text/html
    • PASS [expected FAIL] subtest: fetch(): combined response Content-Type: text/plain;charset=gbk text/html
    • And 27 more unexpected results...
  • OK /fetch/nosniff/script.html
    • PASS [expected FAIL] subtest: URL query: text/ecmascript;blah
  • OK /fetch/nosniff/stylesheet.html
    • PASS [expected FAIL] subtest: URL query: text/css;blah
    • PASS [expected FAIL] subtest: Revalidated URL query: text/css;blah
  • OK /fetch/nosniff/worker.html
    • PASS [expected FAIL] subtest: URL query: ?type=text/ecmascript;yay
  • OK /mimesniff/mime-types/charset-parameter.window.html
    • PASS [expected FAIL] subtest: text/html ;charset=gbk
    • PASS [expected FAIL] subtest: text/html;test;charset=gbk
    • PASS [expected FAIL] subtest: text/html;test=;charset=gbk
    • PASS [expected FAIL] subtest: text/html;';charset=gbk
    • PASS [expected FAIL] subtest: text/html;";charset=gbk
    • PASS [expected FAIL] subtest: text/html ; ; charset=gbk
    • PASS [expected FAIL] subtest: text/html;;;;charset=gbk
    • PASS [expected FAIL] subtest: text/html;charset="gbk
    • FAIL [expected PASS] subtest: text/html;charset=" gbk"

      assert_equals: expected "GBK" but got "UTF-8"

    • FAIL [expected PASS] subtest: text/html;charset="gbk "

      assert_equals: expected "GBK" but got "UTF-8"

    • And 2 more unexpected results...
  • OK /mimesniff/mime-types/parsing.any.html
    • FAIL [expected PASS] subtest: x/x;,=x;bonus=x (Request/Response)

      assert_equals: expected "x/x;bonus=x" but got "x/x"

    • FAIL [expected PASS] subtest: x/x;x=,;bonus=x (Request/Response)

      assert_equals: expected "x/x;x=\",\";bonus=x" but got "x/x"

    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • And 120 more unexpected results...
  • OK /mimesniff/mime-types/parsing.any.worker.html
    • FAIL [expected PASS] subtest: x/x;,=x;bonus=x (Request/Response)

      assert_equals: expected "x/x;bonus=x" but got "x/x"

    • FAIL [expected PASS] subtest: x/x;x=,;bonus=x (Request/Response)

      assert_equals: expected "x/x;x=\",\";bonus=x" but got "x/x"

    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • PASS [expected FAIL] subtest: x/x;�=x;bonus=x (Request/Response)
    • And 120 more unexpected results...
  • OK /workers/importscripts_mime.any.worker.html
    • PASS [expected FAIL] subtest: importScripts() requires scripty MIME types: text/csv;bla;bla is blocked.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 14, 2025

⚠️ Try run (#12771341700) failed.

@jdm
Copy link
Copy Markdown
Member

jdm commented Jan 17, 2025

I took a look at the failures in /encoding/single-byte-decoder.window.html?XMLHttpRequest. They're triggered by content-type charsets that include a :, such as iso_8859-2:1987. I verified that the MIME parser in data-url returns an error when parsing a content-type value like "text/html;charset=iso_8859-2:1987". It's hard to figure out what's the correct behaviour—step 11.10 of https://mimesniff.spec.whatwg.org/#parse-a-mime-type is pretty clear that non-HTTP token code points like : mean the parameter should be dropped.

I looked through (one of) Gecko's MIME parsers, which is modeled off of the mimesniff implementation, and they have a funky addition where the presence of invalid tokens in the value will cause the value to be retained and treated as a quoted value instead when re-serializing.

Overall, my instinct is to accept the current set of expected failures because the set of new passes is significantly larger.

@mrobinson
Copy link
Copy Markdown
Member

mrobinson commented Jan 17, 2025

Okay. Sounds good. I'll update the results and land this then.

@mrobinson mrobinson enabled auto-merge January 18, 2025 14:13
@mrobinson mrobinson added the T-linux-wpt Do a try run of the WPT label May 19, 2025
@github-actions github-actions bot removed the T-linux-wpt Do a try run of the WPT label May 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 19, 2025

🔨 Triggering try run (#15108744906) for Linux (WPT)

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 19, 2025

Test results for linux-wpt from try job (#15108744906):

Flaky unexpected result (20)
  • OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
    • PASS [expected FAIL] subtest: Revoke blob URL after calling fetch, fetch should succeed
  • FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
  • OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
    • FAIL [expected PASS] subtest: WebGL test #52

      assert_true: could not create image (SVG) expected true got false

  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
    • PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
  • CRASH [expected OK] /css/compositing/canvas-composite-modes.html
  • OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
    • FAIL [expected PASS] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 10deg' over 'oblique 0deg'

      assert_equals: Unexpected font on test element expected 487 but got 532

    • FAIL [expected PASS] subtest: Matching font-style: 'oblique -10deg' should prefer 'oblique 0deg 10deg' over 'oblique 40deg 50deg'

      assert_equals: Unexpected font on test element expected 487 but got 532

    • FAIL [expected PASS] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique -60deg -40deg' over 'oblique -10deg'

      assert_equals: Unexpected font on test element expected 487 but got 532

  • OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
    • PASS [expected FAIL] subtest: Single value - name is missing
  • OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
  • OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
    • PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
    • FAIL [expected PASS] subtest: form submission

      assert_equals: expected "http://web-platform.test:8000/common/blank.html?1=" but got "about:blank"

  • OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 3] length 2, got [6, 2, 2] length 3

  • OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 5] length 2, got [6, 3, 3] length 3

  • PASS [expected FAIL] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
  • CRASH [expected OK] /html/semantics/embedded-content/media-elements/offsets-into-the-media-resource/currentTime.html (#36809)
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
    • PASS [expected FAIL] subtest: multipart/form-data: Basic test (normal form)
  • OK /resize-observer/eventloop.html (#33599)
    • FAIL [expected PASS] subtest: test0: multiple notifications inside same event loop

      assert_equals: new loop expected 1 but got 0

  • ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)
Stable unexpected results that are known to be intermittent (15)
  • TIMEOUT [expected OK] /_mozilla/mozilla/window_resizeTo.html (#36741)
    • TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo

      Test timed out

  • PASS [expected FAIL] /css/css-overflow/overflow-video.html (#34720)
  • OK /fetch/content-type/script.window.html (#23149)
    • PASS [expected FAIL] subtest: separate text/javascript;";charset=windows-1252
    • PASS [expected FAIL] subtest: separate x/x text/javascript
    • PASS [expected FAIL] subtest: combined x/x text/javascript
    • PASS [expected FAIL] subtest: separate x/x;charset=windows-1252 text/javascript
    • PASS [expected FAIL] subtest: combined x/x;charset=windows-1252 text/javascript
    • PASS [expected FAIL] subtest: separate text/javascript x/x
    • PASS [expected FAIL] subtest: combined text/javascript; charset=windows-1252 text/javascript
    • PASS [expected FAIL] subtest: separate text/javascript;" x/x
    • PASS [expected FAIL] subtest: combined text/javascript;" x/x
    • PASS [expected FAIL] subtest: combined text/javascript
    • And 9 more unexpected results...
  • OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
    • PASS [expected FAIL] subtest: sec-fetch-dest
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site
  • OK [expected ERROR] /fetch/nosniff/importscripts.html (#27144)
    • PASS [expected TIMEOUT] subtest: Test importScripts()
  • OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
    • FAIL [expected PASS] subtest: Link with onclick form submit to javascript url with document.write and href navigation 

      assert_array_equals: expected property 1 to be "href" but got "click" (expected array ["write", "href"] got ["write", "click"])

  • OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
    • FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

      assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-origin.sub.html (#31931)
    • TIMEOUT [expected FAIL] subtest: cross-origin HTMLVideoElement: origin unclear 2dContext.drawImage

      Test timed out

    • NOTRUN [expected FAIL] subtest: cross-origin HTMLVideoElement: origin unclear bitmaprenderer.transferFromImageBitmap
    • NOTRUN [expected FAIL] subtest: redirected to cross-origin HTMLVideoElement: origin unclear getImageData
    • NOTRUN [expected FAIL] subtest: redirected to cross-origin HTMLVideoElement: origin unclear 2dContext.drawImage
    • NOTRUN [expected FAIL] subtest: redirected to cross-origin HTMLVideoElement: origin unclear bitmaprenderer.transferFromImageBitmap
    • NOTRUN [expected FAIL] subtest: redirected to same-origin HTMLVideoElement: origin unclear getImageData
    • NOTRUN [expected FAIL] subtest: redirected to same-origin HTMLVideoElement: origin unclear 2dContext.drawImage
    • NOTRUN [expected FAIL] subtest: redirected to same-origin HTMLVideoElement: origin unclear bitmaprenderer.transferFromImageBitmap
    • NOTRUN [expected FAIL] subtest: unclean HTMLCanvasElement: origin unclear getImageData
    • NOTRUN [expected FAIL] subtest: unclean HTMLCanvasElement: origin unclear 2dContext.drawImage
    • And 4 more unexpected results...
  • OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

      assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;/body&gt;

    • FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

      assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;

    • FAIL [expected NOTRUN] subtest: Area element should support autofocus

      promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"

  • OK [expected CRASH] /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
  • TIMEOUT /html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub.html (#36989)
    • FAIL [expected TIMEOUT] subtest: redirected to same-origin HTMLVideoElement: Setting fillStyle to an origin-unclean pattern makes the canvas origin-unclean

      promise_test: Unhandled rejection with value: object "TypeError: argument could not be converted to any of: HTMLImageElement, HTMLCanvasElement, OffscreenCanvas, CSSStyleValue"

    • PASS [expected NOTRUN] subtest: unclean HTMLCanvasElement: Setting fillStyle to an origin-unclean pattern makes the canvas origin-unclean
    • FAIL [expected NOTRUN] subtest: unclean ImageBitmap: Setting fillStyle to an origin-unclean pattern makes the canvas origin-unclean

      promise_test: Unhandled rejection with value: object "NotSupportedError: The operation is not supported."

    • PASS [expected NOTRUN] subtest: cross-origin HTMLImageElement: Setting fillStyle to an origin-unclean offscreen canvas pattern makes the canvas origin-unclean
    • FAIL [expected NOTRUN] subtest: cross-origin SVGImageElement: Setting fillStyle to an origin-unclean offscreen canvas pattern makes the canvas origin-unclean

      promise_test: Unhandled rejection with value: object "[object Event]"

    • FAIL [expected NOTRUN] subtest: cross-origin HTMLVideoElement: Setting fillStyle to an origin-unclean offscreen canvas pattern makes the canvas origin-unclean

      promise_test: Unhandled rejection with value: object "TypeError: argument could not be converted to any of: HTMLImageElement, HTMLCanvasElement, OffscreenCanvas, CSSStyleValue"

    • FAIL [expected NOTRUN] subtest: redirected to cross-origin HTMLVideoElement: Setting fillStyle to an origin-unclean offscreen canvas pattern makes the canvas origin-unclean

      promise_test: Unhandled rejection with value: object "TypeError: argument could not be converted to any of: HTMLImageElement, HTMLCanvasElement, OffscreenCanvas, CSSStyleValue"

    • TIMEOUT [expected NOTRUN] subtest: redirected to same-origin HTMLVideoElement: Setting fillStyle to an origin-unclean offscreen canvas pattern makes the canvas origin-unclean

      Test timed out

  • OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
    • FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload

      uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"

  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK /resize-observer/change-layout-in-error.html (#32629)
    • FAIL [expected PASS] subtest: Changing layout in window error handler should not result in lifecyle loop when resize observer loop limit is reached.

      assert_equals: expected 1 but got 2

  • OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)
    • FAIL [expected PASS] subtest: X Stitched sine-wave buffers at sample rate 43800 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732959747314453,0.4248766601085663,0.480754554271698,0.5347436666488647,0.5866320133209229,0.6362156271934509,0.6832997798919678,0.7276994585990906,0.7692402601242065,0.8077589869499207...] with an element-wise tolerance of {"absoluteThreshold":0.0038986,"relativeThreshold":0}. Index Actual Expected AbsError RelError Test threshold [14650] -9.1009210778829748e+33 8.6956524848937988e-1 9.1009210778829748e+33 1.0466058865269989e+34 3.8985999999999999e-3 [14651] 3.0547976493835449e-1 8.9879405498504639e-1 5.9331429004669189e-1 6.6012262403823208e-1 3.8985999999999999e-3 Max AbsError of 9.1009210778829748e+33 at index of 14650. Max RelError of 1.0466058865269989e+34 at index of 14650. 

      assert_true: expected true got false

    • FAIL [expected PASS] subtest: X SNR (-635.7476210206173 dB) is not greater than or equal to 65.737. Got -635.7476210206173.

      assert_true: expected true got false

Stable unexpected results (2)
  • OK /encoding/single-byte-decoder.window.html?XMLHttpRequest
    • PASS [expected FAIL] subtest: ISO-8859-2: iso_8859-2:1987 (XMLHttpRequest)
    • PASS [expected FAIL] subtest: ISO-8859-3: iso_8859-3:1988 (XMLHttpRequest)
    • PASS [expected FAIL] subtest: ISO-8859-4: iso_8859-4:1988 (XMLHttpRequest)
    • PASS [expected FAIL] subtest: ISO-8859-5: iso_8859-5:1988 (XMLHttpRequest)
    • PASS [expected FAIL] subtest: ISO-8859-6: iso_8859-6:1987 (XMLHttpRequest)
    • PASS [expected FAIL] subtest: ISO-8859-7: iso_8859-7:1987 (XMLHttpRequest)
    • PASS [expected FAIL] subtest: ISO-8859-8: iso_8859-8:1988 (XMLHttpRequest)
    • PASS [expected FAIL] subtest: windows-1252: iso_8859-1:1987 (XMLHttpRequest)
    • PASS [expected FAIL] subtest: windows-1254: iso_8859-9:1989 (XMLHttpRequest)
  • OK /mimesniff/mime-types/charset-parameter.window.html
    • PASS [expected FAIL] subtest: text/html;charset="gbk
    • FAIL [expected PASS] subtest: text/html;charset="\ gbk"

      assert_equals: expected "GBK" but got "UTF-8"

    • PASS [expected FAIL] subtest: text/html;charset="gbk"x

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 19, 2025

⚠️ Try run (#15108744906) failed.

@mrobinson mrobinson added this pull request to the merge queue May 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 19, 2025
@mrobinson mrobinson enabled auto-merge May 19, 2025 10:45
@mrobinson mrobinson added this pull request to the merge queue May 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 19, 2025
@mrobinson mrobinson added this pull request to the merge queue May 19, 2025
Merged via the queue into servo:main with commit 6e97fc0 May 19, 2025
21 checks passed
@ghostd ghostd deleted the fix-contenttype branch May 19, 2025 12:14
@mrobinson mrobinson mentioned this pull request Nov 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

@jdm jdm

Labels

S-awaiting-review There is new code that needs to be reviewed. S-tests-failed The changes caused existing tests to fail.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ghostd @highfive @jdm @bors-servo @CYBAI @mrobinson