Call eglMakeCurrent with non-null surfaces before anything else#27743
Merged
bors-servo merged 1 commit intoservo:masterfrom Nov 8, 2020
2dav:master
Merged
Call eglMakeCurrent with non-null surfaces before anything else#27743bors-servo merged 1 commit intoservo:masterfrom 2dav:master
bors-servo merged 1 commit intoservo:masterfrom
2dav:master
Conversation
…ack window on Nvidia/X11. This change ensures first call to eglMakeCurrent made with non-null surfaces.
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 7119eb7 has been approved by |
Contributor
bors-servo
added a commit
that referenced
this pull request
Nov 8, 2020
Call eglMakeCurrent with non-null surfaces before anything else First call to eglMakeCurrent with no draw or read surface leads to black window on Nvidia/X11. This change ensures first call to eglMakeCurrent made with non-null surfaces. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #26353 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
@bors-servo retry |
Contributor
Contributor
|
☀️ Test successful - status-taskcluster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First call to eglMakeCurrent with no draw or read surface leads to black window on Nvidia/X11. This change ensures first call to eglMakeCurrent made with non-null surfaces.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors