Skip to content

improve reliability of hang monitor tests#27193

Merged
bors-servo merged 1 commit intoservo:masterfrom
gterzian:fix_monitor_test_timeout
Jul 7, 2020
Merged

improve reliability of hang monitor tests#27193
bors-servo merged 1 commit intoservo:masterfrom
gterzian:fix_monitor_test_timeout

Conversation

@gterzian
Copy link
Copy Markdown
Member

@gterzian gterzian commented Jul 7, 2020

FIX #27191


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 7, 2020
@gterzian
Copy link
Copy Markdown
Member Author

gterzian commented Jul 7, 2020

@jdm r?

@jdm
Copy link
Copy Markdown
Member

jdm commented Jul 7, 2020

@bors-servo r+

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 256167e has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 7, 2020
@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 256167e with merge 840167e...

bors-servo added a commit that referenced this pull request Jul 7, 2020
improve reliability of hang monitor tests

<!-- Please describe your changes on the following line: -->

FIX #27191

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Copy Markdown
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 7, 2020
@jdm
Copy link
Copy Markdown
Member

jdm commented Jul 7, 2020

bors-servo added a commit that referenced this pull request Jul 7, 2020
improve reliability of hang monitor tests

<!-- Please describe your changes on the following line: -->

FIX #27191

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 256167e with merge 2a95233...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 7, 2020
@bors-servo
Copy link
Copy Markdown
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 7, 2020
@jdm
Copy link
Copy Markdown
Member

jdm commented Jul 7, 2020

@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 256167e with merge e616284...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 7, 2020
@bors-servo
Copy link
Copy Markdown
Contributor

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing e616284 to master...

@bors-servo bors-servo merged commit e616284 into servo:master Jul 7, 2020
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 7, 2020
@gterzian gterzian deleted the fix_monitor_test_timeout branch July 7, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent timeout in test_hang_monitoring_exit_signal

4 participants